Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: v9 Dialog animations are causing integration tests to fail #29704

Closed
bsunderhus opened this issue Oct 31, 2023 · 0 comments · Fixed by #29692
Closed

[Bug]: v9 Dialog animations are causing integration tests to fail #29704

bsunderhus opened this issue Oct 31, 2023 · 0 comments · Fixed by #29692
Assignees
@bsunderhus
Labels
Component: Dialog Fluent UI react-components (v9) Status: In PR

Comments

@bsunderhus
Copy link
Contributor

bsunderhus commented Oct 31, 2023 •
edited
Loading

Library

React Components / v9 (@fluentui/react-components)

Bug Description

Actual Behavior

After #29391 got merged, animations were introduced. The introduction of animations on test environment might be problematic as they might alter the visibility of certain elements on the DOM, which might cause some problems on integration tests!

Expected Behavior

Animation should be disabled on test environments to ensure this won't be a problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsunderhus bsunderhus

Labels
Component: Dialog Fluent UI react-components (v9) Status: In PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(react-dialog): remove animation from test environments bsunderhus/fluentui
1 participant
@bsunderhus