chore(react-dialog): remove animation from test environments #29692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsunderhus
changed the title
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 61 | 58 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 632 | 687 | 5000 | |
| Button | mount | 317 | 318 | 5000 | |
| Field | mount | 1169 | 1132 | 5000 | |
| FluentProvider | mount | 720 | 715 | 5000 | |
| FluentProviderWithTheme | mount | 74 | 81 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 61 | 58 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 69 | 79 | 10 | |
| MakeStyles | mount | 874 | 899 | 50000 | |
| Persona | mount | 1799 | 1752 | 5000 | |
| SpinButton | mount | 1415 | 1381 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 53199e7:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4c4558791182fbe2a62992e2ff76e4e048a42bf7 (build) |
🕵 fluentuiv9 No visual regressions between this PR and main |
ling1726
reviewed
Oct 30, 2023
packages/react-components/react-dialog/src/components/Dialog/renderDialog.tsx
Show resolved
Hide resolved
ling1726
approved these changes
Oct 30, 2023
bsunderhus
force-pushed
the
react-dialog/chore--remove-animation-from-test-environments
branch
from
07db9b4 to
53199e7
Compare
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 31, 2023
* master: (34 commits) Remove redundant pipeline yaml. It is now replaced iwth azure-pipelines-ci.yml and azure-pipelines-pr.yml (microsoft#29706) chore(TimePicker-compat): preview release with added stories and docs (microsoft#29677) Enable 1ES PT to be compliant for all production pipelines (microsoft#29702) chore: restrict node versions to 18 ||| 20 (microsoft#29676) chore(TimePicker-compat): renames and code polish (microsoft#29695) chore: remove animation from test environments (microsoft#29692) applying package updates docs: fix defaultSelectedOptions for Dropdown and Combobox examples (microsoft#29700) revert accidentally pushed changes (microsoft#29696) Added scale factor to minHeight logic (microsoft#29653) Fixing the mistake in useArrowNavigationGroup - axis values in the doc (microsoft#29667) applying package updates 🧪 🧪 🧪 🧪 🧪 Rever accidentally pushed pipeline changes (microsoft#29685) applying package updates 🧪 ...
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Conditionally removes the usage of
Transitioncomponent to disable animations on tests environmentsRelated Issue(s)