chore(bundle-size): extract classname consts to separate files #13145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
mnajdova
changed the title
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 446bf39dcf55c1a306c9e9674960f8c0027c71c9 (build) |
mnajdova
changed the title
# Conflicts: # packages/fluentui/react-northstar/src/components/Dropdown/DropdownSelectedItem.tsx # packages/fluentui/react-northstar/src/themes/teams/components/Dropdown/dropdownSelectedItemStyles.ts
|
@mnajdova Is this intended to be checked in or is it just for demo purposes? If it's just a demo and is no longer needed we should close it. |
|
This pull request has been automatically marked as stale because it was marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 5 days of this comment. Thank you for your contributions to Fluent UI! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is experimenting with some optimization for the bundle size. I was doing some investigation of why for an application with one Button we are dragging all components in the bundle. The reason was quite surprising - because we are importing the constants for the classNames and slot's classNames from the component's file. Just extracting these constants to a separate file, removed the components from the bundle. This PR is showcasing the dropping of the Dropdown components from the bundle.
Before:
After:
We should probably do some more deeper investigation of why this is happening, and whether this is the default behavior of webpack (as one representative of the bundlers), but this seems like a low hanging fruit for dropping the bundle size for sure.