Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding componentRef support, BaseComponent warnings, and initial Customizer component. #1389

Merged
merged 12 commits into from
Apr 4, 2017
Merged

Adding componentRef support, BaseComponent warnings, and initial Customizer component. #1389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
917ab34
Updates to BaseComponent to support componentRef, adding initial Cust…
dzearing Apr 1, 2017
568c6f7
Updating components to use warning helpers.
dzearing Apr 1, 2017
2bac382
Updates to use componentRef
dzearing Apr 1, 2017
eadb066
Updating typings pr feedback, upgrading typescript.
dzearing Apr 3, 2017
0d6dacf
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
dzearing Apr 3, 2017
70bc13a
Updating test.
dzearing Apr 3, 2017
063db6e
Adding componentRef to all the props interfaces, so that it consisten…
dzearing Apr 3, 2017
aaf6220
lint
dzearing Apr 3, 2017
2c02959
more lint
dzearing Apr 3, 2017
85aafdf
Merge branch 'master' into general-updates
dzearing Apr 3, 2017
9ce8a1b
Adding change file. Updating all components to use BaseComponent. Rem…
dzearing Apr 4, 2017
7a5c103
Updating comment, passing along context.
dzearing Apr 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/fabric-website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"source-map-loader": "0.1.5",
"tslint": "^3.15.1",
"tslint-microsoft-contrib": "^2.0.9",
"typescript": "^2.1.5",
"typescript": "^2.2.2",
"vinyl-ftp": "0.4.5",
"webpack-bundle-analyzer": "^2.2.1"
},
Expand Down
2 changes: 1 addition & 1 deletion apps/todo-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@
"office-ui-fabric-react": ">=2.10.5 <3.0.0",
"react": "^15.4.2",
"react-dom": "^15.4.2",
"typescript": "^2.0.6"
"typescript": "^2.2.2"
}
}
20 changes: 20 additions & 0 deletions common/changes/general-updates_2017-04-04-00-01.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "In components which expose a public API such as `Dropdown` which implements `IDropdown`, to access the exact interface we've exposed a `componentRef` property on all components. This property replaces typical `ref={ c => this._component = c }` usage, as componentRef is guaranteed to access the public contract of the component regardless of the higher-order component or decorator wrapping it. If you are accessing the public API of a component, replace your `ref` usage with `componentRef`.",
"type": "minor"
},
{
"packageName": "@uifabric/utilities",
"comment": "BaseComponent: added support for resolving `componentRef` automatically. Also added `_warnDeprecations` and `_warnMutualExclusion` helpers for warning on misuse.",
"type": "minor"
},
{
"comment": "",
"packageName": "@uifabric/example-app-base",
"type": "none"
}
],
"email": "dzearing@microsoft.com"
}
Loading