Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove default exports [P2] #13915

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jul 3, 2020

Description of changes

This PR is a second round of default exports removal, see #12953 (comment).

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4e1c185:

Sandbox Source
Fluent UI Button Configuration
affectionate-pascal-pu40f Configuration

@DustyTheBot
Copy link

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against 4e1c185

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 912 898 5000
ButtonNext mount 564 584 5000
Checkbox mount 1540 1552 5000
CheckboxBase mount 1299 1261 5000
CheckboxNext mount 1584 1568 5000
ChoiceGroup mount 4944 4900 5000
ComboBox mount 916 947 1000
CommandBar mount 7608 7628 1000
ContextualMenu mount 14424 13809 1000
DefaultButton mount 1099 1122 5000
DetailsRow mount 3532 3525 5000
DetailsRowFast mount 3572 3558 5000
DetailsRowNoStyles mount 3285 3327 5000
Dialog mount 1513 1475 1000
DocumentCardTitle mount 1823 1797 1000
Dropdown mount 2486 2466 5000
FocusZone mount 1816 1843 5000
IconButton mount 1675 1687 5000
Label mount 342 330 5000
Link mount 433 438 5000
LinkNext mount 456 457 5000
MenuButton mount 1445 1443 5000
Nav mount 3247 3249 1000
Panel mount 1440 1451 1000
Persona mount 822 857 1000
Pivot mount 1557 1387 1000
PivotNext mount 1361 1411 1000
PrimaryButton mount 1288 1256 5000
SearchBox mount 1254 1277 5000
SearchBoxNext mount 1331 1323 5000
Slider mount 1497 1502 5000
SliderNext mount 1920 1875 5000
Spinner mount 417 414 5000
SplitButton mount 3124 3136 5000
Stack mount 516 539 5000
StackWithIntrinsicChildren mount 2003 2004 5000
StackWithTextChildren mount 5005 5089 5000
TagPicker mount 2754 2681 5000
Text mount 423 394 5000
TextField mount 1340 1359 5000
ThemeProvider mount 2927 2966 5000
ThemeProvider virtual-rerender 518 524 5000
Toggle mount 847 841 5000
ToggleNext mount 810 826 5000
button mount 122 116 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.48 0.92:1 2000 880
🦄 Button.Fluent 0.11 0.19 0.58:1 5000 525
🔧 Checkbox.Fluent 0.62 0.36 1.72:1 1000 624
🦄 Dialog.Fluent 0.15 0.22 0.68:1 5000 761
🔧 Dropdown.Fluent 3.32 0.46 7.22:1 1000 3316
🔧 Icon.Fluent 0.14 0.05 2.8:1 5000 685
🎯 Image.Fluent 0.07 0.1 0.7:1 5000 348
🔧 Slider.Fluent 1.66 0.37 4.49:1 1000 1661
🔧 Text.Fluent 0.06 0.02 3:1 5000 322
🦄 Tooltip.Fluent 0.1 19.15 0.01:1 5000 491

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FormMinimalPerf.default 413 370 1.12:1
AttachmentSlotsPerf.default 1187 1090 1.09:1
ButtonMinimalPerf.default 173 158 1.09:1
PortalMinimalPerf.default 125 117 1.07:1
IconMinimalPerf.default 684 639 1.07:1
TableMinimalPerf.default 400 377 1.06:1
VideoMinimalPerf.default 624 590 1.06:1
AvatarMinimalPerf.default 463 443 1.05:1
HeaderMinimalPerf.default 343 327 1.05:1
SegmentMinimalPerf.default 335 319 1.05:1
BoxMinimalPerf.default 335 322 1.04:1
CardMinimalPerf.default 558 536 1.04:1
LayoutMinimalPerf.default 367 352 1.04:1
RadioGroupMinimalPerf.default 408 391 1.04:1
Avatar.Fluent 880 849 1.04:1
AccordionMinimalPerf.default 141 137 1.03:1
FlexMinimalPerf.default 271 262 1.03:1
MenuMinimalPerf.default 830 808 1.03:1
MenuButtonMinimalPerf.default 1533 1489 1.03:1
ReactionMinimalPerf.default 381 371 1.03:1
RefMinimalPerf.default 212 206 1.03:1
TextAreaMinimalPerf.default 449 435 1.03:1
TooltipMinimalPerf.default 779 757 1.03:1
Dialog.Fluent 761 742 1.03:1
Slider.Fluent 1661 1606 1.03:1
ChatWithPopoverPerf.default 472 463 1.02:1
SliderMinimalPerf.default 1646 1620 1.02:1
Icon.Fluent 685 672 1.02:1
AttachmentMinimalPerf.default 149 148 1.01:1
CheckboxMinimalPerf.default 2885 2854 1.01:1
DropdownManyItemsPerf.default 1395 1386 1.01:1
DropdownMinimalPerf.default 3332 3311 1.01:1
HeaderSlotsPerf.default 761 750 1.01:1
SplitButtonMinimalPerf.default 3704 3669 1.01:1
StatusMinimalPerf.default 662 656 1.01:1
Dropdown.Fluent 3316 3282 1.01:1
ButtonSlotsPerf.default 580 582 1:1
DialogMinimalPerf.default 761 761 1:1
GridMinimalPerf.default 322 321 1:1
ImageMinimalPerf.default 352 353 1:1
LoaderMinimalPerf.default 721 723 1:1
ProviderMergeThemesPerf.default 1940 1945 1:1
ProviderMinimalPerf.default 879 875 1:1
TableManyItemsPerf.default 2163 2159 1:1
TextMinimalPerf.default 325 324 1:1
TreeMinimalPerf.default 837 840 1:1
Image.Fluent 348 347 1:1
DividerMinimalPerf.default 345 347 0.99:1
LabelMinimalPerf.default 389 392 0.99:1
ListMinimalPerf.default 443 449 0.99:1
ListNestedPerf.default 866 875 0.99:1
PopupMinimalPerf.default 649 654 0.99:1
CustomToolbarPrototype.default 3746 3800 0.99:1
ToolbarMinimalPerf.default 903 910 0.99:1
TreeWith60ListItems.default 217 219 0.99:1
Checkbox.Fluent 624 628 0.99:1
Text.Fluent 322 326 0.99:1
ChatDuplicateMessagesPerf.default 413 423 0.98:1
ChatMinimalPerf.default 581 595 0.98:1
InputMinimalPerf.default 1042 1067 0.98:1
ItemLayoutMinimalPerf.default 1228 1249 0.98:1
ListWith60ListItems.default 1051 1072 0.98:1
Button.Fluent 525 533 0.98:1
Tooltip.Fluent 491 500 0.98:1
AlertMinimalPerf.default 278 286 0.97:1
CarouselMinimalPerf.default 446 458 0.97:1
EmbedMinimalPerf.default 1844 1903 0.97:1
ListCommonPerf.default 915 942 0.97:1
AnimationMinimalPerf.default 356 370 0.96:1
HierarchicalTreeMinimalPerf.default 420 532 0.79:1

@size-auditor
Copy link

size-auditor bot commented Jul 3, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 523f1ed72368da18cb33a6d620a730bd271e8905 (build)

@layershifter layershifter merged commit a489863 into master Jul 3, 2020
@layershifter layershifter deleted the chore/no-default-export-p2 branch July 3, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants