Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove default exports [P4] #13917

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Conversation

layershifter
Copy link
Member

Description of changes

This PR is a fourth round of default exports removal, see #12953 (comment).

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 56e86ee:

Sandbox Source
Fluent UI Button Configuration
cocky-wind-0ppr3 Configuration

@DustyTheBot
Copy link

DustyTheBot commented Jul 3, 2020

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against 56e86ee

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Jul 3, 2020

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 671 683 5000
ButtonNext mount 471 431 5000
Checkbox mount 1218 1252 5000
CheckboxBase mount 1008 1016 5000
CheckboxNext mount 1203 1198 5000
ChoiceGroup mount 3910 3820 5000
ComboBox mount 695 692 1000
CommandBar mount 5928 5982 1000
ContextualMenu mount 10557 10282 1000
DefaultButton mount 839 816 5000
DetailsRow mount 2713 2699 5000
DetailsRowFast mount 2704 2745 5000
DetailsRowNoStyles mount 2675 2648 5000
Dialog mount 1137 1181 1000
DocumentCardTitle mount 1466 1439 1000
Dropdown mount 1942 1949 5000
FocusZone mount 1409 1428 5000
IconButton mount 1329 1356 5000
Label mount 305 273 5000
Link mount 321 366 5000
LinkNext mount 340 337 5000
MenuButton mount 1113 1127 5000
Nav mount 2536 2532 1000
Panel mount 1134 1102 1000
Persona mount 656 668 1000
Pivot mount 1132 1082 1000
PivotNext mount 1040 1097 1000
PrimaryButton mount 954 971 5000
SearchBox mount 961 989 5000
SearchBoxNext mount 986 1014 5000
Slider mount 1140 1161 5000
SliderNext mount 1569 1547 5000
Spinner mount 330 319 5000
SplitButton mount 2447 2492 5000
Stack mount 400 398 5000
StackWithIntrinsicChildren mount 1479 1517 5000
StackWithTextChildren mount 3938 3965 5000
TagPicker mount 2154 2163 5000
Text mount 371 316 5000
TextField mount 1028 1087 5000
ThemeProvider mount 2366 2323 5000
ThemeProvider virtual-rerender 389 406 5000
Toggle mount 649 662 5000
ToggleNext mount 628 626 5000
button mount 84 84 5000

Perf Analysis (Fluent)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
GridMinimalPerf.default 249 247 1.01:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.35 0.35 1:1 2000 707
🦄 Button.Fluent 0.08 0.15 0.53:1 5000 397
🔧 Checkbox.Fluent 0.49 0.26 1.88:1 1000 490
🎯 Dialog.Fluent 0.12 0.17 0.71:1 5000 598
🔧 Dropdown.Fluent 2.64 0.35 7.54:1 1000 2643
🔧 Icon.Fluent 0.11 0.04 2.75:1 5000 530
🦄 Image.Fluent 0.05 0.08 0.63:1 5000 273
🔧 Slider.Fluent 1.23 0.26 4.73:1 1000 1229
🔧 Text.Fluent 0.05 0.02 2.5:1 5000 246
🦄 Tooltip.Fluent 0.08 13.3 0.01:1 5000 388

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ReactionMinimalPerf.default 313 283 1.11:1
TextAreaMinimalPerf.default 363 329 1.1:1
TooltipMinimalPerf.default 643 585 1.1:1
LoaderMinimalPerf.default 620 574 1.08:1
CarouselMinimalPerf.default 359 336 1.07:1
DialogMinimalPerf.default 613 575 1.07:1
AttachmentMinimalPerf.default 119 112 1.06:1
StatusMinimalPerf.default 526 497 1.06:1
Avatar.Fluent 707 664 1.06:1
DividerMinimalPerf.default 274 261 1.05:1
FlexMinimalPerf.default 214 204 1.05:1
LayoutMinimalPerf.default 298 283 1.05:1
PortalMinimalPerf.default 90 86 1.05:1
SliderMinimalPerf.default 1294 1227 1.05:1
TableMinimalPerf.default 299 284 1.05:1
ButtonSlotsPerf.default 459 440 1.04:1
EmbedMinimalPerf.default 1540 1475 1.04:1
ListCommonPerf.default 781 752 1.04:1
ListWith60ListItems.default 881 847 1.04:1
AnimationMinimalPerf.default 299 291 1.03:1
ButtonMinimalPerf.default 123 119 1.03:1
InputMinimalPerf.default 835 807 1.03:1
MenuButtonMinimalPerf.default 1191 1159 1.03:1
TextMinimalPerf.default 250 243 1.03:1
Button.Fluent 397 385 1.03:1
Dropdown.Fluent 2643 2573 1.03:1
AlertMinimalPerf.default 225 220 1.02:1
BoxMinimalPerf.default 263 258 1.02:1
CheckboxMinimalPerf.default 2185 2150 1.02:1
Icon.Fluent 530 518 1.02:1
DropdownManyItemsPerf.default 1119 1107 1.01:1
FormMinimalPerf.default 320 316 1.01:1
HierarchicalTreeMinimalPerf.default 316 313 1.01:1
ListMinimalPerf.default 347 345 1.01:1
PopupMinimalPerf.default 515 508 1.01:1
ProviderMergeThemesPerf.default 1478 1464 1.01:1
SplitButtonMinimalPerf.default 2934 2916 1.01:1
CustomToolbarPrototype.default 2914 2892 1.01:1
Checkbox.Fluent 490 486 1.01:1
ChatDuplicateMessagesPerf.default 326 326 1:1
ItemLayoutMinimalPerf.default 972 968 1:1
MenuMinimalPerf.default 662 659 1:1
RadioGroupMinimalPerf.default 329 328 1:1
SegmentMinimalPerf.default 243 243 1:1
Dialog.Fluent 598 600 1:1
Slider.Fluent 1229 1225 1:1
CardMinimalPerf.default 433 438 0.99:1
DropdownMinimalPerf.default 2566 2586 0.99:1
LabelMinimalPerf.default 319 323 0.99:1
ProviderMinimalPerf.default 658 668 0.99:1
TreeMinimalPerf.default 659 664 0.99:1
ChatMinimalPerf.default 461 471 0.98:1
ChatWithPopoverPerf.default 359 368 0.98:1
HeaderMinimalPerf.default 280 287 0.98:1
HeaderSlotsPerf.default 589 602 0.98:1
ImageMinimalPerf.default 283 289 0.98:1
ToolbarMinimalPerf.default 735 748 0.98:1
Text.Fluent 246 250 0.98:1
AvatarMinimalPerf.default 355 367 0.97:1
TableManyItemsPerf.default 1677 1725 0.97:1
VideoMinimalPerf.default 466 480 0.97:1
IconMinimalPerf.default 488 509 0.96:1
Image.Fluent 273 283 0.96:1
TreeWith60ListItems.default 166 174 0.95:1
Tooltip.Fluent 388 410 0.95:1
AttachmentSlotsPerf.default 881 938 0.94:1
ListNestedPerf.default 662 706 0.94:1
RefMinimalPerf.default 148 165 0.9:1
AccordionMinimalPerf.default 90 108 0.83:1

@size-auditor
Copy link

size-auditor bot commented Jul 3, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 523f1ed72368da18cb33a6d620a730bd271e8905 (build)

@layershifter layershifter merged commit 9cf1be4 into master Jul 7, 2020
@layershifter layershifter deleted the chore/no-default-export-p4 branch July 7, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants