-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use Babel plugins to annotate pure calls #14007
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7888c38:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ae46225e1b94e6b348daa23fe90d983a285ce4ad (build) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! If you're able to share a writeup at some point of all the things you've learned from investigating these bundling issues, that would be really interesting.
Related to #12953.
Description of changes
This PR:
/*#__PURE__*/
babel-plugin-iife-wrap-react-components
wraps components that have static properties into IIFE and marks them as purebabel-plugin-annotate-pure-imports
annotates calls to functions from listed moduleswhatInput.ts
prop-types
dependency underreact-component-event-listener
&react-component-ref
utils/index.ts
module commonPropTypes
commonPropInterfaces.ts
was empty after compilation and was a reason ofModuleConcatenation bailout: Module is not an ECMAScript module
Results
Based on
AccordionDefault.bsize.tsx
I have following results on minified code: