Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update rollup config and incorrect readme import #14392

Conversation

chrisdholt
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Fixes an issue where the rollup build didn't match the unpkg config.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0481481:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@chrisdholt chrisdholt merged commit ffe5831 into microsoft:master Aug 6, 2020
@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 928 846 5000
ButtonNext mount 580 589 5000
Checkbox mount 1574 1536 5000
CheckboxBase mount 1288 1378 5000
CheckboxNext mount 1603 1608 5000
ChoiceGroup mount 5041 4861 5000
ComboBox mount 913 913 1000
CommandBar mount 7560 7633 1000
ContextualMenu mount 13695 13728 1000
DefaultButton mount 1098 1144 5000
DetailsRow mount 3472 3592 5000
DetailsRowFast mount 3520 3586 5000
DetailsRowNoStyles mount 3347 3336 5000
Dialog mount 1488 1512 1000
DocumentCardTitle mount 1785 1852 1000
Dropdown mount 2566 2512 5000
FocusZone mount 1810 1828 5000
IconButton mount 1702 1713 5000
Label mount 340 351 5000
Link mount 468 467 5000
LinkNext mount 475 485 5000
MenuButton mount 1425 1409 5000
Nav mount 3215 3226 1000
Panel mount 1449 1470 1000
Persona mount 848 881 1000
Pivot mount 1399 1436 1000
PivotNext mount 1370 1378 1000
PrimaryButton mount 1267 1256 5000
SearchBox mount 1286 1319 5000
SearchBoxNext mount 1304 1317 5000
Slider mount 1500 1521 5000
SliderNext mount 1970 1909 5000
SpinButton mount 4952 4950 5000
SpinButtonNext mount 5080 4946 5000
Spinner mount 417 425 5000
SplitButton mount 3148 3094 5000
Stack mount 529 522 5000
StackWithIntrinsicChildren mount 1989 1947 5000
StackWithTextChildren mount 5059 5041 5000
TagPicker mount 2725 2691 5000
Text mount 412 408 5000
TextField mount 1361 1351 5000
ThemeProvider mount 2926 3047 5000
ThemeProvider virtual-rerender 520 538 5000
Toggle mount 829 819 5000
ToggleNext mount 815 827 5000
button mount 120 117 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.47 0.94:1 2000 871
🦄 Button.Fluent 0.11 0.19 0.58:1 5000 530
🔧 Checkbox.Fluent 0.64 0.33 1.94:1 1000 640
🦄 Dialog.Fluent 0.15 0.22 0.68:1 5000 739
🔧 Dropdown.Fluent 2.92 0.46 6.35:1 1000 2918
🔧 Icon.Fluent 0.13 0.05 2.6:1 5000 669
🦄 Image.Fluent 0.07 0.11 0.64:1 5000 358
🔧 Slider.Fluent 1.59 0.36 4.42:1 1000 1585
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 325
🦄 Tooltip.Fluent 0.1 17.73 0.01:1 5000 510

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FormMinimalPerf.default 398 368 1.08:1
TreeWith60ListItems.default 226 210 1.08:1
AvatarMinimalPerf.default 462 433 1.07:1
ChatDuplicateMessagesPerf.default 443 414 1.07:1
GridMinimalPerf.default 324 302 1.07:1
VideoMinimalPerf.default 639 598 1.07:1
CarouselMinimalPerf.default 464 438 1.06:1
ChatWithPopoverPerf.default 486 461 1.05:1
ListNestedPerf.default 891 849 1.05:1
ListWith60ListItems.default 1117 1063 1.05:1
MenuMinimalPerf.default 836 793 1.05:1
LabelMinimalPerf.default 401 387 1.04:1
PortalMinimalPerf.default 119 114 1.04:1
StatusMinimalPerf.default 659 632 1.04:1
AccordionMinimalPerf.default 151 146 1.03:1
AttachmentMinimalPerf.default 144 140 1.03:1
ButtonSlotsPerf.default 592 575 1.03:1
ListMinimalPerf.default 465 451 1.03:1
ProviderMinimalPerf.default 913 886 1.03:1
Image.Fluent 358 347 1.03:1
ButtonMinimalPerf.default 161 158 1.02:1
CardMinimalPerf.default 535 522 1.02:1
DialogMinimalPerf.default 782 767 1.02:1
DividerMinimalPerf.default 333 328 1.02:1
InputMinimalPerf.default 1328 1303 1.02:1
IconMinimalPerf.default 657 641 1.02:1
TextMinimalPerf.default 338 333 1.02:1
TextAreaMinimalPerf.default 451 440 1.02:1
CustomToolbarPrototype.default 3778 3712 1.02:1
DropdownMinimalPerf.default 3020 2987 1.01:1
ListCommonPerf.default 937 931 1.01:1
LoaderMinimalPerf.default 718 708 1.01:1
ProviderMergeThemesPerf.default 1959 1931 1.01:1
SplitButtonMinimalPerf.default 3721 3685 1.01:1
ToolbarMinimalPerf.default 925 913 1.01:1
TreeMinimalPerf.default 841 834 1.01:1
Text.Fluent 325 321 1.01:1
CheckboxMinimalPerf.default 2812 2815 1:1
FlexMinimalPerf.default 264 263 1:1
HierarchicalTreeMinimalPerf.default 414 415 1:1
LayoutMinimalPerf.default 382 382 1:1
PopupMinimalPerf.default 660 660 1:1
SegmentMinimalPerf.default 327 328 1:1
Button.Fluent 530 532 1:1
BoxMinimalPerf.default 322 324 0.99:1
ChatMinimalPerf.default 585 591 0.99:1
DropdownManyItemsPerf.default 723 730 0.99:1
HeaderMinimalPerf.default 346 351 0.99:1
HeaderSlotsPerf.default 745 750 0.99:1
ImageMinimalPerf.default 345 348 0.99:1
ReactionMinimalPerf.default 377 380 0.99:1
SliderMinimalPerf.default 1634 1646 0.99:1
Checkbox.Fluent 640 645 0.99:1
Dialog.Fluent 739 745 0.99:1
Tooltip.Fluent 510 516 0.99:1
RadioGroupMinimalPerf.default 407 415 0.98:1
RefMinimalPerf.default 207 211 0.98:1
TableManyItemsPerf.default 2105 2153 0.98:1
TooltipMinimalPerf.default 758 775 0.98:1
Avatar.Fluent 871 891 0.98:1
Dropdown.Fluent 2918 2990 0.98:1
Slider.Fluent 1585 1613 0.98:1
AnimationMinimalPerf.default 368 379 0.97:1
AttachmentSlotsPerf.default 1093 1128 0.97:1
ItemLayoutMinimalPerf.default 1247 1283 0.97:1
MenuButtonMinimalPerf.default 1474 1514 0.97:1
TableMinimalPerf.default 378 388 0.97:1
AlertMinimalPerf.default 280 294 0.95:1
EmbedMinimalPerf.default 1879 2006 0.94:1
Icon.Fluent 669 743 0.9:1

@chrisdholt chrisdholt deleted the users/chhol/fix-unpkg-link-from-publish branch August 6, 2020 22:24
@msft-github-bot
Copy link
Contributor

🎉@fluentui/web-components@v0.1.1 has been released which incorporates this pull request.:tada:

Handy links:

tmaster628 pushed a commit to tmaster628/fluentui that referenced this pull request Aug 12, 2020
* fix: update rollup config and incorrect readme import

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants