Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure radio control does not shrink #14473

Conversation

chrisdholt
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

In rare scenarios the radio button control can end up shrinking slightly due to the use of flexbox. This PR ensures that the radio control itself does not shrink in those scenarios.

Focus areas to test

(optional)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a3dedeb:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 891 897 5000
ButtonNext mount 586 586 5000
Checkbox mount 1568 1598 5000
CheckboxBase mount 1280 1315 5000
CheckboxNext mount 1611 1657 5000
ChoiceGroup mount 5034 4992 5000
ComboBox mount 953 940 1000
CommandBar mount 7861 7916 1000
ContextualMenu mount 15586 15724 1000
DefaultButton mount 1111 1122 5000
DetailsRow mount 3544 3571 5000
DetailsRowFast mount 3522 3613 5000
DetailsRowNoStyles mount 3374 3371 5000
Dialog mount 1536 1519 1000
DocumentCardTitle mount 1886 1860 1000
Dropdown mount 2586 2587 5000
FocusZone mount 1824 1845 5000
IconButton mount 1736 1725 5000
Label mount 340 342 5000
Link mount 447 459 5000
LinkNext mount 484 475 5000
MenuButton mount 1469 1454 5000
Nav mount 3234 3237 1000
Panel mount 1486 1446 1000
Persona mount 842 850 1000
Pivot mount 1456 1430 1000
PivotNext mount 1417 1417 1000
PrimaryButton mount 1282 1291 5000
SearchBox mount 1283 1282 5000
SearchBoxNext mount 1334 1357 5000
Slider mount 1510 1540 5000
SliderNext mount 1937 1953 5000
SpinButton mount 5372 4992 5000
SpinButtonNext mount 5092 5071 5000
Spinner mount 437 436 5000
SplitButton mount 3159 3189 5000
Stack mount 525 531 5000
StackWithIntrinsicChildren mount 1926 1958 5000
StackWithTextChildren mount 4975 5005 5000
TagPicker mount 2773 2776 5000
Text mount 424 409 5000
TextField mount 1400 1416 5000
ThemeProvider mount 2932 2932 5000
ThemeProvider virtual-rerender 489 471 5000
Toggle mount 822 847 5000
ToggleNext mount 849 860 5000
button mount 112 110 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.43 0.48 0.9:1 2000 864
🦄 Button.Fluent 0.11 0.19 0.58:1 5000 534
🔧 Checkbox.Fluent 0.63 0.35 1.8:1 1000 633
🦄 Dialog.Fluent 0.15 0.22 0.68:1 5000 764
🔧 Dropdown.Fluent 2.97 0.46 6.46:1 1000 2966
🔧 Icon.Fluent 0.14 0.05 2.8:1 5000 689
🎯 Image.Fluent 0.07 0.1 0.7:1 5000 357
🔧 Slider.Fluent 1.61 0.35 4.6:1 1000 1614
🔧 Text.Fluent 0.06 0.03 2:1 5000 322
🦄 Tooltip.Fluent 0.1 20.23 0:1 5000 518

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 152 140 1.09:1
ButtonMinimalPerf.default 178 165 1.08:1
AnimationMinimalPerf.default 406 382 1.06:1
HierarchicalTreeMinimalPerf.default 425 405 1.05:1
ChatWithPopoverPerf.default 473 454 1.04:1
ListWith60ListItems.default 1123 1075 1.04:1
AvatarMinimalPerf.default 465 452 1.03:1
DividerMinimalPerf.default 357 347 1.03:1
IconMinimalPerf.default 672 654 1.03:1
TextMinimalPerf.default 339 328 1.03:1
TreeWith60ListItems.default 223 217 1.03:1
Button.Fluent 534 519 1.03:1
Checkbox.Fluent 633 615 1.03:1
CarouselMinimalPerf.default 444 437 1.02:1
ChatDuplicateMessagesPerf.default 425 417 1.02:1
DropdownManyItemsPerf.default 777 759 1.02:1
DropdownMinimalPerf.default 3029 2974 1.02:1
FlexMinimalPerf.default 280 275 1.02:1
FormMinimalPerf.default 388 382 1.02:1
ImageMinimalPerf.default 367 361 1.02:1
ItemLayoutMinimalPerf.default 1238 1219 1.02:1
ListCommonPerf.default 965 948 1.02:1
SegmentMinimalPerf.default 335 327 1.02:1
SliderMinimalPerf.default 1631 1604 1.02:1
TableMinimalPerf.default 390 383 1.02:1
ToolbarMinimalPerf.default 936 919 1.02:1
Dialog.Fluent 764 749 1.02:1
AlertMinimalPerf.default 292 289 1.01:1
ButtonSlotsPerf.default 588 583 1.01:1
ChatMinimalPerf.default 579 576 1.01:1
InputMinimalPerf.default 1313 1303 1.01:1
MenuButtonMinimalPerf.default 1531 1511 1.01:1
ReactionMinimalPerf.default 374 371 1.01:1
SplitButtonMinimalPerf.default 3739 3709 1.01:1
TooltipMinimalPerf.default 784 776 1.01:1
Avatar.Fluent 864 856 1.01:1
DialogMinimalPerf.default 757 759 1:1
EmbedMinimalPerf.default 1914 1908 1:1
HeaderMinimalPerf.default 347 348 1:1
ListMinimalPerf.default 461 460 1:1
LoaderMinimalPerf.default 732 730 1:1
MenuMinimalPerf.default 835 836 1:1
PopupMinimalPerf.default 665 666 1:1
ProviderMergeThemesPerf.default 1939 1945 1:1
ProviderMinimalPerf.default 931 930 1:1
RadioGroupMinimalPerf.default 406 408 1:1
RefMinimalPerf.default 212 212 1:1
CustomToolbarPrototype.default 3791 3805 1:1
Dropdown.Fluent 2966 2959 1:1
Slider.Fluent 1614 1608 1:1
AccordionMinimalPerf.default 141 142 0.99:1
CardMinimalPerf.default 528 533 0.99:1
LabelMinimalPerf.default 390 395 0.99:1
LayoutMinimalPerf.default 377 382 0.99:1
ListNestedPerf.default 865 871 0.99:1
SkeletonMinimalPerf.default 390 393 0.99:1
StatusMinimalPerf.default 654 660 0.99:1
TextAreaMinimalPerf.default 441 444 0.99:1
TreeMinimalPerf.default 853 860 0.99:1
Image.Fluent 357 360 0.99:1
Text.Fluent 322 326 0.99:1
Tooltip.Fluent 518 521 0.99:1
AttachmentSlotsPerf.default 1117 1142 0.98:1
BoxMinimalPerf.default 324 332 0.98:1
CheckboxMinimalPerf.default 2837 2885 0.98:1
GridMinimalPerf.default 316 323 0.98:1
TableManyItemsPerf.default 2124 2160 0.98:1
Icon.Fluent 689 704 0.98:1
HeaderSlotsPerf.default 756 776 0.97:1
PortalMinimalPerf.default 116 120 0.97:1
VideoMinimalPerf.default 604 621 0.97:1

@size-auditor
Copy link

size-auditor bot commented Aug 11, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 44befb4af953e60cfb3d5c27dbfc5736bd40a452 (build)

@chrisdholt chrisdholt merged commit 68d4bb6 into microsoft:master Aug 11, 2020
@chrisdholt chrisdholt deleted the users/chhol/ensure-radios-do-not-shrink branch August 11, 2020 18:23
@msft-github-bot
Copy link
Contributor

🎉@fluentui/web-components@v0.1.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants