-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ie11 polyfill package and test with react-button package #14567
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 99a0d92:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 17e0cf28afe34918bce1d80454d3ee2c022f8467 (build) |
…into ie11-polyfill
…into ie11-polyfill
…into ie11-polyfill
packages/example-app-base/src/components/CodeSnippet/CodeSnippet.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving from the Button
legacy start perspective.
Waiting until we figure out licensing to merge this PR. |
change/@fluentui-ie11-custom-properties-2020-08-27-12-13-14-ie11-polyfill.json
Outdated
Show resolved
Hide resolved
change/@uifabric-experiments-2020-08-27-14-11-31-ie11-polyfill.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once you delete the extra change file.
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
…ft#14567) * Add ie11 polyfill package and test with react-button package * change package name and add typings file * Fix getResolveAlias * more getResolveAlias fixes * update readme and get latest polyfill script version * clean up script file * Updating example-app-base version in react-button. * Removing the need for a theme and wrapping legacy examples with ThemeProvider. * Change files * Change files * Update version in react-button and README in polyfill package * remove unused import * Update packages/ie11-custom-properties/README.md Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com> * update example-app-base version * update package to use external polyfill as devDependency * Change files * update example-app-base package to latest version * Exporting ie11-custom-properties from ie11-polyfills. * update example-app-base version * add more info to README & fix LICENSE * Clean up README and change package to use JS * delete redundant change file Co-authored-by: Elizabeth Craig <elcraig@microsoft.com> Co-authored-by: KHMakoto <humbertomakotomorimoto@gmail.com> Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com>
Pull request checklist
$ yarn change
Description of changes
(give an overview)
Focus areas to test
(optional)