fix: button and accordion controls not inheriting font-family styles and update fast packages #14828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 31, 2020 13:10
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
Asset size changes
Baseline commit: 3f948ab0e851b17f156af306070e3c498f00d93c (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b7faae0:
|
chrisdholt
reviewed
Aug 31, 2020
chrisdholt
reviewed
Aug 31, 2020
chrisdholt
approved these changes
Aug 31, 2020
|
Thanks @SethDonohue! |
|
🎉 Handy links: |
hutchcodes
pushed a commit
to hutchcodes/fluentui
that referenced
this pull request
Sep 10, 2020
…and update fast packages (microsoft#14828) * update fast packages and add inherit to controls for button and accordion item * Change files * add yarn lock Co-authored-by: Seth Donohue <sethdonohue@Admins-MBP.guest.corp.microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
buttonelement on the shadow DOM for the accordion-item and button components does not inherit the font-family as it should.