Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add floating picker to react-next to make it concurrent #14908

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Add floating picker to react-next to make it concurrent #14908

merged 2 commits into from
Sep 16, 2020

Conversation

joschect
Copy link
Contributor

@joschect joschect commented Sep 4, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 4, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Sep 4, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 914 877 5000
Breadcrumb mount 43252 43107 5000
BreadcrumbNext mount 164551 163480 5000
ButtonNext mount 589 591 5000
Checkbox mount 1547 1621 5000
CheckboxBase mount 1358 1364 5000
CheckboxNext mount 1528 1507 5000
ChoiceGroup mount 4952 5007 5000
ChoiceGroupNext mount 5153 5076 5000
ComboBox mount 942 905 1000
CommandBar mount 7662 7702 1000
ContextualMenu mount 14485 14507 1000
DefaultButton mount 1078 1157 5000
DetailsRow mount 3565 3653 5000
DetailsRowFast mount 3509 3487 5000
DetailsRowNoStyles mount 3407 3455 5000
Dialog mount 1532 1501 1000
DocumentCardTitle mount 1830 1854 1000
Dropdown mount 2578 2592 5000
FocusZone mount 1818 1855 5000
IconButton mount 1798 1732 5000
Label mount 332 351 5000
Link mount 454 456 5000
LinkNext mount 451 471 5000
MenuButton mount 1499 1481 5000
MessageBar mount 2132 2075 5000
MessageBarNext mount 2041 2026 5000
Nav mount 3172 3280 1000
OverflowSet mount 1442 1347 5000
OverflowSetNext mount 1037 1062 5000
Panel mount 1486 1427 1000
Persona mount 844 835 1000
Pivot mount 1525 1475 1000
PivotNext mount 1463 1411 1000
PrimaryButton mount 1258 1266 5000
Rating mount 7561 7682 5000
RatingNext mount 7486 7447 5000
SearchBox mount 1341 1313 5000
SearchBoxNext mount 1334 1345 5000
Shimmer mount 2644 2600 5000
ShimmerNext mount 2488 2574 5000
Slider mount 1590 1488 5000
SliderNext mount 1925 1951 5000
SpinButton mount 4980 5003 5000
SpinButtonNext mount 5304 5239 5000
Spinner mount 452 448 5000
SplitButton mount 3169 3129 5000
Stack mount 551 527 5000
StackWithIntrinsicChildren mount 1975 1972 5000
StackWithTextChildren mount 5016 5090 5000
SwatchColorPicker mount 10354 10532 5000
SwatchColorPickerNext mount 10297 10496 5000
TagPicker mount 2754 2847 5000
TeachingBubble mount 52177 52012 5000
TeachingBubbleNext mount 51635 51990 5000
Text mount 427 426 5000
TextField mount 1389 1422 5000
ThemeProvider mount 4983 5014 5000
ThemeProvider virtual-rerender 555 518 5000
Toggle mount 835 828 5000
ToggleNext mount 844 822 5000
button mount 108 126 5000

Perf Analysis (Fluent)

⚠️ 5 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 1735 45 38.56:1 analysis
ButtonUseCssNestingPerf.default 1111 44 25.25:1 analysis
ButtonUseCssPerf.default 836 43 19.44:1 analysis
ChatWithPopoverPerf.default 473 468 1.01:1 analysis
ListCommonPerf.default 684 937 0.73:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.48 0.92:1 2000 877
🦄 Button.Fluent 0.12 0.2 0.6:1 5000 580
🔧 Checkbox.Fluent 0.66 0.39 1.69:1 1000 659
🎯 Dialog.Fluent 0.16 0.22 0.73:1 5000 803
🔧 Dropdown.Fluent 3.09 0.49 6.31:1 1000 3090
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 768
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 413
🔧 Slider.Fluent 1.6 0.37 4.32:1 1000 1602
🔧 Text.Fluent 0.08 0.04 2:1 5000 399
🦄 Tooltip.Fluent 0.12 18.93 0.01:1 5000 593

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 169 119 1.42:1
RefMinimalPerf.default 256 198 1.29:1
StatusMinimalPerf.default 808 637 1.27:1
SkeletonMinimalPerf.default 476 383 1.24:1
AccordionMinimalPerf.default 169 139 1.22:1
ReactionMinimalPerf.default 437 357 1.22:1
SegmentMinimalPerf.default 392 322 1.22:1
FlexMinimalPerf.default 323 266 1.21:1
Image.Fluent 413 348 1.19:1
RadioGroupMinimalPerf.default 468 396 1.18:1
TextAreaMinimalPerf.default 529 447 1.18:1
CardMinimalPerf.default 631 539 1.17:1
GridMinimalPerf.default 370 316 1.17:1
ImageMinimalPerf.default 407 349 1.17:1
AttachmentMinimalPerf.default 168 145 1.16:1
AnimationMinimalPerf.default 433 376 1.15:1
BoxMinimalPerf.default 386 336 1.15:1
ChatMinimalPerf.default 686 601 1.14:1
TreeWith60ListItems.default 247 218 1.13:1
Text.Fluent 399 352 1.13:1
LayoutMinimalPerf.default 426 379 1.12:1
IconMinimalPerf.default 743 662 1.12:1
TextMinimalPerf.default 368 329 1.12:1
TooltipMinimalPerf.default 896 802 1.12:1
Tooltip.Fluent 593 529 1.12:1
CarouselMinimalPerf.default 476 431 1.1:1
DividerMinimalPerf.default 392 356 1.1:1
LabelMinimalPerf.default 434 395 1.1:1
PopupMinimalPerf.default 726 659 1.1:1
MenuMinimalPerf.default 905 836 1.08:1
MenuButtonMinimalPerf.default 1670 1542 1.08:1
ButtonSlotsPerf.default 654 612 1.07:1
DialogMinimalPerf.default 786 737 1.07:1
DropdownManyItemsPerf.default 807 753 1.07:1
HeaderSlotsPerf.default 807 752 1.07:1
ListMinimalPerf.default 494 461 1.07:1
ProviderMergeThemesPerf.default 2079 1949 1.07:1
TableMinimalPerf.default 440 413 1.07:1
VideoMinimalPerf.default 660 618 1.07:1
Checkbox.Fluent 659 618 1.07:1
ItemLayoutMinimalPerf.default 1307 1232 1.06:1
ProviderMinimalPerf.default 999 940 1.06:1
CustomToolbarPrototype.default 3994 3769 1.06:1
ButtonMinimalPerf.default 174 165 1.05:1
TableManyItemsPerf.default 2191 2089 1.05:1
Dropdown.Fluent 3090 2954 1.05:1
AttachmentSlotsPerf.default 1175 1134 1.04:1
ToolbarMinimalPerf.default 965 931 1.04:1
TreeMinimalPerf.default 886 848 1.04:1
Button.Fluent 580 559 1.04:1
Dialog.Fluent 803 773 1.04:1
FormMinimalPerf.default 421 407 1.03:1
HeaderMinimalPerf.default 390 378 1.03:1
Avatar.Fluent 877 863 1.02:1
ChatDuplicateMessagesPerf.default 445 441 1.01:1
DropdownMinimalPerf.default 2995 2970 1.01:1
EmbedMinimalPerf.default 1917 1901 1.01:1
SplitButtonMinimalPerf.default 3783 3730 1.01:1
Icon.Fluent 768 757 1.01:1
Slider.Fluent 1602 1592 1.01:1
InputMinimalPerf.default 1358 1354 1:1
SliderMinimalPerf.default 1594 1599 1:1
CheckboxMinimalPerf.default 2883 2918 0.99:1
LoaderMinimalPerf.default 733 738 0.99:1
AlertMinimalPerf.default 307 316 0.97:1
AvatarMinimalPerf.default 490 519 0.94:1
ListWith60ListItems.default 975 1086 0.9:1
ListNestedPerf.default 593 878 0.68:1

@size-auditor
Copy link

size-auditor bot commented Sep 4, 2020 •
edited
Loading

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-next-FloatingPicker 231.559 kB 244.406 kB ExceedsTolerance     12.847 kB

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: a206613fdde9717a5c1f77a57368d83916a608d7 (build)

@joschect joschect merged commit c1dfa56 into microsoft:master Sep 16, 2020
@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-next@v8.0.0-alpha.109 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@dzearing dzearing Awaiting requested review from dzearing

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@layershifter layershifter Awaiting requested review from layershifter

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@mnajdova mnajdova Awaiting requested review from mnajdova

@pompomon pompomon Awaiting requested review from pompomon

Assignees
No one assigned
Labels
Component: Pickers PR: API Modified PR: Possible Perf Regression 🐌
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joschect @msft-github-bot @ecraig12345