Vertical stacked bar chart combined callout and other tweaks #14912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerticalStackedBarChart - props for custom rendering the callout and choosing between combined and per-point callouts - props for customizing the style or position of the callout - skip outputting bars for zero-value points - remove ref array where indexes were not deterministic
|
The screenshot above showing a custom combined callout uses this code: onRenderCalloutPerStack={props => (
<pre>{JSON.stringify(props, null, 2)}</pre>
)}Of course, in real use, it would output a pretty version of the data. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit da41823:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d0bdb5b1f6dae8c39be8ef012f70c3a5688a10f0 (build) |
…shouldn't be exported)
|
Can you please resolve the conflicts |
…rChart-callout-improvements
Raghurk
approved these changes
Sep 10, 2020
|
🎉 Handy links: |
hutchcodes
pushed a commit
to hutchcodes/fluentui
that referenced
this pull request
Sep 10, 2020
…ft#14912) * Vertical stacked bar chart combined callout and other tweaks VerticalStackedBarChart - props for custom rendering the callout and choosing between combined and per-point callouts - props for customizing the style or position of the callout - skip outputting bars for zero-value points - remove ref array where indexes were not deterministic * Change files * changing to "major" due to removed exports (internal state interface shouldn't be exported) * maintain earlier update
ecraig12345
reviewed
Sep 10, 2020
| */ | ||
| chartTitle?: string; | ||
| xAxisCalloutData?: string; |
There was a problem hiding this comment.
Was this intentional? It seems like xAxisCalloutData should have been a new prop, not a replacement for chartTitle.
There was a problem hiding this comment.
chartTitle was not being used. It's not technically a replacement.
ecraig12345
reviewed
Sep 10, 2020
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "type": "major", | |||
There was a problem hiding this comment.
I'm pretty sure this should NOT have been a major change. Major version bumps should be reserved for backwards-incompatible API changes, which I don't think I'm seeing in this PR.
There was a problem hiding this comment.
@Raghurk wanted it to be major due to the changes to IVerticalStackedBarChartState, which had previously been exported.
There was a problem hiding this comment.
Never mind, talked to @Raghurk and he said this was intentional
Merged
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
VerticalStackedBarChart
Screenshots
Customize position and display (formatting value)
Custom callout for whole stack
Design