Feat: adds automatic card background color calculation #15126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating my fork with changes
Wanted latest master
chrisdholt
reviewed
Sep 18, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a83779e:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 98a2265:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d792de036aeb9a703603b76cd81f09462e298633 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
chrisdholt
reviewed
Sep 21, 2020
change/@fluentui-web-components-2020-09-18-12-06-28-users-jes-card-improvements.json
Show resolved
Hide resolved
chrisdholt
reviewed
Sep 21, 2020
nicholasrice
approved these changes
Sep 21, 2020
eljefe223
force-pushed
the
users/jes/card-improvements
branch
from
f07d5d5
to
d2034bd
Compare
chrisdholt
approved these changes
Sep 21, 2020
eljefe223
force-pushed
the
users/jes/card-improvements
branch
from
ec88de6
to
45f5fdc
Compare
eljefe223
force-pushed
the
users/jes/card-improvements
branch
from
45f5fdc
to
095e287
Compare
eljefe223
force-pushed
the
users/jes/card-improvements
branch
from
1fc6995
to
7125657
Compare
eljefe223
force-pushed
the
users/jes/card-improvements
branch
from
7125657
to
98a2265
Compare
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
By default
fluent-cardnow automatically appliesneutralFillCardto its background, which that is calculated from its parent design system provider. If a custom background color is desired the attributecard-background-coloris now available, this will reset the cards design system to that value.