Merge OUFR into react and update references #15271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecraig12345
requested review from
aditima,
assuncaocharles,
atneik,
behowell,
dzearing,
evlevy,
hyoshis,
Jacqueline-ms,
Jahnp,
JasonGore,
jdhuntington,
joschect,
jurokapsiar,
khmakoto,
layershifter,
leddie24,
lorejoh12,
Markionium,
micahgodbolt,
miroslavstastny,
mtennoe,
natalieethell,
pompomon,
Raghurk,
ThomasMichon,
Vitalius1,
wsmd,
xugao and
yiminwu
as code owners
ecraig12345
force-pushed
the
merge-oufr-react
branch
from
2b3be89
to
a5dd058
Compare
Perf Analysis
All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
ecraig12345
force-pushed
the
merge-oufr-react
branch
from
ccad08a
to
8162294
Compare
ecraig12345
added a commit
to ecraig12345/office-ui-fabric-react
that referenced
this pull request
Oct 2, 2020
Merged
msft-github-bot
pushed a commit
that referenced
this pull request
Oct 3, 2020
Delete the accidental extra copy of ComponentConformance.test.tsx that was causing size auditor to fail after #15271. And somewhat related changes: - Update release notes to reflect changes from #15271 - Clean up test-bundles package, including deleting stuff which appeared to only be used in a previous implementation of bundle size measurement. None of these things turned out to be the problem, but I made these changes while investigating.
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all OUFR files into
reactorreact-internaland update references tooffice-ui-fabric-react(to either@fluentui/react,@fluentui/react-internal, justreact, or occasionally something else).To prevent circular dependencies with the per-component packages (
react-checkboxetc), we decided to make a separate INTERNAL USE ONLY package@fluentui/react-internal. Note that directly importing from the@fluentui/react-internalpackage (the root or any file within it) is not supported, and the structure of this package may change at any time. Importing from individual component packages or@fluentui/reacttop-level files is fine.Components were moved as follows:
@fluentui/react-internal):@fluentui/react-checkbox)@fluentui/react-link)@fluentui/react-tabs)@fluentui/react-slider)@fluentui/react-toggle)@fluentui/reactdue to having a dependency on one of the individual component packages (avoid circular dep):@fluentui/react-internalAssorted other changes included in this PR (please see the commit history for a complete list):
Related to #15152