Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test only PR in 7.0 #15277

Closed
wants to merge 2 commits into from
Closed

Test only PR in 7.0 #15277

wants to merge 2 commits into from

Conversation

xugao
Copy link
Contributor

@xugao xugao commented Sep 28, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

@msft-github-bot
Copy link
Contributor

We are currently in the v8 Snap period. This is a reminder to cherry-pick your changes to master branch (required). See more details here. Thank you for your contribution and understanding!

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9dba39d:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
Avatar mount 956 884 5000
BaseButton mount 991 982 5000
Breadcrumb mount 40731 42309 5000
ButtonNext mount 624 585 5000
Checkbox mount 1621 1592 5000
CheckboxBase mount 1372 1405 5000
ChoiceGroup mount 5147 5047 5000
ComboBox mount 948 1012 1000
CommandBar mount 7640 7511 1000
ContextualMenu mount 12851 13006 1000
DefaultButton mount 1145 1169 5000
DetailsRow mount 3755 3748 5000
DetailsRowFast mount 3753 3778 5000
DetailsRowNoStyles mount 3576 3609 5000
Dialog mount 1538 1513 1000
DocumentCardTitle mount 1844 1805 1000
Dropdown mount 2694 2691 5000
FocusTrapZone mount 1749 1732 5000
FocusZone mount 1826 1816 5000
IconButton mount 1851 1845 5000
Label mount 339 328 5000
Layer mount 2033 2015 5000
Link mount 475 472 5000
MenuButton mount 1538 1548 5000
MessageBar mount 2073 2029 5000
Nav mount 3432 3316 1000
OverflowSet mount 1449 1440 5000
Panel mount 1506 1481 1000
Persona mount 838 864 1000
Pivot mount 1484 1460 1000
PrimaryButton mount 1329 1329 5000
Rating mount 8011 7922 5000
SearchBox mount 1384 1346 5000
Shimmer mount 2693 2707 5000
Slider mount 1522 1537 5000
SpinButton mount 5136 5103 5000
Spinner mount 405 422 5000
SplitButton mount 3248 3302 5000
Stack mount 538 530 5000
StackWithIntrinsicChildren mount 2000 1950 5000
StackWithTextChildren mount 5343 5203 5000
SwatchColorPicker mount 10706 10611 5000
TagPicker mount 2899 2877 5000
TeachingBubble mount 49186 48690 5000
Text mount 443 448 5000
TextField mount 1478 1522 5000
ThemeProvider mount 3115 3080 5000
ThemeProvider virtual-rerender 596 605 5000
Toggle mount 860 817 5000
button mount 112 114 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.48 0.53 0.91:1 2000 967
🦄 Button.Fluent 0.13 0.22 0.59:1 5000 672
🔧 Checkbox.Fluent 0.71 0.38 1.87:1 1000 708
🎯 Dialog.Fluent 0.18 0.24 0.75:1 5000 887
🔧 Dropdown.Fluent 3.06 0.52 5.88:1 1000 3055
🔧 Icon.Fluent 0.16 0.06 2.67:1 5000 812
🎯 Image.Fluent 0.09 0.12 0.75:1 5000 464
🔧 Slider.Fluent 1.65 0.39 4.23:1 1000 1648
🔧 Text.Fluent 0.09 0.03 3:1 5000 464
🦄 Tooltip.Fluent 0.12 16.31 0.01:1 5000 605

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AlertMinimalPerf.default 359 0 Infinity:1
AnimationMinimalPerf.default 486 0 Infinity:1
AttachmentMinimalPerf.default 191 0 Infinity:1
AttachmentSlotsPerf.default 1265 0 Infinity:1
AvatarMinimalPerf.default 540 0 Infinity:1
ButtonMinimalPerf.default 205 0 Infinity:1
ButtonOverridesMissPerf.default 1810 0 Infinity:1
ButtonUseCssPerf.default 928 0 Infinity:1
ButtonUseCssNestingPerf.default 1214 0 Infinity:1
CardMinimalPerf.default 654 0 Infinity:1
CarouselMinimalPerf.default 523 0 Infinity:1
ChatDuplicateMessagesPerf.default 482 0 Infinity:1
ChatMinimalPerf.default 698 0 Infinity:1
ChatWithPopoverPerf.default 514 0 Infinity:1
DialogMinimalPerf.default 895 0 Infinity:1
DividerMinimalPerf.default 430 0 Infinity:1
DropdownManyItemsPerf.default 839 0 Infinity:1
DropdownMinimalPerf.default 3068 0 Infinity:1
EmbedMinimalPerf.default 2103 0 Infinity:1
FlexMinimalPerf.default 338 0 Infinity:1
FormMinimalPerf.default 491 0 Infinity:1
GridMinimalPerf.default 421 0 Infinity:1
HeaderMinimalPerf.default 444 0 Infinity:1
HeaderSlotsPerf.default 906 0 Infinity:1
InputMinimalPerf.default 1417 0 Infinity:1
ItemLayoutMinimalPerf.default 1479 0 Infinity:1
LayoutMinimalPerf.default 481 0 Infinity:1
ListCommonPerf.default 744 0 Infinity:1
ListMinimalPerf.default 562 0 Infinity:1
ListNestedPerf.default 656 0 Infinity:1
ListWith60ListItems.default 987 0 Infinity:1
LoaderMinimalPerf.default 799 0 Infinity:1
MenuMinimalPerf.default 961 0 Infinity:1
MenuButtonMinimalPerf.default 1729 0 Infinity:1
PopupMinimalPerf.default 750 0 Infinity:1
PortalMinimalPerf.default 177 0 Infinity:1
ProviderMergeThemesPerf.default 2126 0 Infinity:1
ProviderMinimalPerf.default 1123 0 Infinity:1
RadioGroupMinimalPerf.default 503 0 Infinity:1
ReactionMinimalPerf.default 476 0 Infinity:1
RefMinimalPerf.default 259 0 Infinity:1
SegmentMinimalPerf.default 406 0 Infinity:1
SkeletonMinimalPerf.default 496 0 Infinity:1
SliderMinimalPerf.default 1666 0 Infinity:1
SplitButtonMinimalPerf.default 4115 0 Infinity:1
StatusMinimalPerf.default 863 0 Infinity:1
IconMinimalPerf.default 805 0 Infinity:1
TableManyItemsPerf.default 2500 0 Infinity:1
TableMinimalPerf.default 504 0 Infinity:1
TextMinimalPerf.default 432 0 Infinity:1
CustomToolbarPrototype.default 4139 0 Infinity:1
ToolbarMinimalPerf.default 1071 0 Infinity:1
TooltipMinimalPerf.default 919 0 Infinity:1
TreeMinimalPerf.default 1018 0 Infinity:1
TreeWith60ListItems.default 226 0 Infinity:1
VideoMinimalPerf.default 701 0 Infinity:1
Avatar.Fluent 967 0 Infinity:1
Button.Fluent 672 0 Infinity:1
Checkbox.Fluent 708 0 Infinity:1
Dialog.Fluent 887 0 Infinity:1
Dropdown.Fluent 3055 0 Infinity:1
Icon.Fluent 812 0 Infinity:1
Image.Fluent 464 0 Infinity:1
Slider.Fluent 1648 0 Infinity:1
Text.Fluent 464 0 Infinity:1
Tooltip.Fluent 605 0 Infinity:1
CheckboxMinimalPerf.default 3033 1 3033:1
ButtonSlotsPerf.default 693 1 693:1
TextAreaMinimalPerf.default 604 1 604:1
LabelMinimalPerf.default 502 1 502:1
ImageMinimalPerf.default 460 1 460:1
BoxMinimalPerf.default 444 1 444:1
AccordionMinimalPerf.default 185 1 185:1

@xugao xugao closed this Sep 28, 2020
@size-auditor
Copy link

size-auditor bot commented Sep 28, 2020

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 718e248

Possible causes

  • The baseline build 718e248 is broken
  • The Size Auditor run for the baseline build 718e248 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmakoto khmakoto Awaiting requested review from khmakoto khmakoto is a code owner

Assignees

@miroslavstastny miroslavstastny

Labels
Component: Checkbox Status: Do Not Merge 🚫
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xugao @msft-github-bot @miroslavstastny