Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expand/collapse for grouping in DetailsList (#15284) #15287

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Fix expand/collapse for grouping in DetailsList (#15284) #15287

merged 1 commit into from
Sep 29, 2020

Conversation

dzearing
Copy link
Member

Cherrypicking Thomas' change into 7.0.

@ThomasMichon @dzearing
Fix expand/collapse for grouping in DetailsList (#15284)
08bfde0 
* Ensure GroupedList version is invalidated when parent list is invalidated

* Update API signatures

* Change files

(cherry picked from commit 371d5ed)
@msft-github-bot
Copy link
Contributor

We are currently in the v8 Snap period. This is a reminder to cherry-pick your changes to master branch (required). See more details here. Thank you for your contribution and understanding!

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 08bfde0:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
Avatar mount 863 841 5000
BaseButton mount 943 944 5000
Breadcrumb mount 40463 40673 5000
ButtonNext mount 585 608 5000
Checkbox mount 1617 1616 5000
CheckboxBase mount 1416 1388 5000
ChoiceGroup mount 5085 5182 5000
ComboBox mount 1008 989 1000
CommandBar mount 7496 7424 1000
ContextualMenu mount 12728 12687 1000
DefaultButton mount 1178 1145 5000
DetailsRow mount 3662 3755 5000
DetailsRowFast mount 3658 3713 5000
DetailsRowNoStyles mount 3467 3668 5000
Dialog mount 1524 1501 1000
DocumentCardTitle mount 1757 1778 1000
Dropdown mount 2711 2673 5000
FocusTrapZone mount 1708 1707 5000
FocusZone mount 1773 1755 5000
IconButton mount 1832 1838 5000
Label mount 351 342 5000
Layer mount 2035 2024 5000
Link mount 476 466 5000
MenuButton mount 1529 1528 5000
MessageBar mount 2081 2006 5000
Nav mount 3288 3306 1000
OverflowSet mount 1426 1430 5000
Panel mount 1426 1432 1000
Persona mount 827 867 1000
Pivot mount 1439 1428 1000
PrimaryButton mount 1328 1331 5000
Rating mount 7822 7816 5000
SearchBox mount 1318 1301 5000
Shimmer mount 2719 2658 5000
Slider mount 1526 1516 5000
SpinButton mount 5141 5106 5000
Spinner mount 406 432 5000
SplitButton mount 3187 3210 5000
Stack mount 550 533 5000
StackWithIntrinsicChildren mount 1835 1916 5000
StackWithTextChildren mount 5056 5064 5000
SwatchColorPicker mount 10515 10389 5000
TagPicker mount 2753 2744 5000
TeachingBubble mount 49567 49486 5000
Text mount 432 445 5000
TextField mount 1432 1395 5000
ThemeProvider mount 3027 2993 5000
ThemeProvider virtual-rerender 584 592 5000
Toggle mount 870 843 5000
button mount 126 108 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.47 0.48 0.98:1 2000 939
🦄 Button.Fluent 0.12 0.21 0.57:1 5000 609
🔧 Checkbox.Fluent 0.65 0.37 1.76:1 1000 653
🎯 Dialog.Fluent 0.17 0.23 0.74:1 5000 834
🔧 Dropdown.Fluent 2.97 0.5 5.94:1 1000 2974
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 772
🎯 Image.Fluent 0.09 0.12 0.75:1 5000 456
🔧 Slider.Fluent 1.53 0.36 4.25:1 1000 1532
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 407
🦄 Tooltip.Fluent 0.11 15.14 0.01:1 5000 562

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 180 0 Infinity:1
AlertMinimalPerf.default 335 0 Infinity:1
AnimationMinimalPerf.default 424 0 Infinity:1
AttachmentMinimalPerf.default 179 0 Infinity:1
AttachmentSlotsPerf.default 1197 0 Infinity:1
AvatarMinimalPerf.default 508 0 Infinity:1
BoxMinimalPerf.default 409 0 Infinity:1
ButtonMinimalPerf.default 202 0 Infinity:1
ButtonOverridesMissPerf.default 1680 0 Infinity:1
ButtonUseCssNestingPerf.default 1109 0 Infinity:1
CardMinimalPerf.default 634 0 Infinity:1
ChatDuplicateMessagesPerf.default 426 0 Infinity:1
ChatMinimalPerf.default 689 0 Infinity:1
ChatWithPopoverPerf.default 478 0 Infinity:1
CheckboxMinimalPerf.default 2905 0 Infinity:1
DialogMinimalPerf.default 843 0 Infinity:1
DividerMinimalPerf.default 422 0 Infinity:1
DropdownManyItemsPerf.default 787 0 Infinity:1
DropdownMinimalPerf.default 2883 0 Infinity:1
EmbedMinimalPerf.default 1992 0 Infinity:1
FormMinimalPerf.default 463 0 Infinity:1
GridMinimalPerf.default 389 0 Infinity:1
HeaderMinimalPerf.default 423 0 Infinity:1
HeaderSlotsPerf.default 841 0 Infinity:1
ImageMinimalPerf.default 445 0 Infinity:1
InputMinimalPerf.default 1332 0 Infinity:1
ItemLayoutMinimalPerf.default 1380 0 Infinity:1
LayoutMinimalPerf.default 446 0 Infinity:1
ListCommonPerf.default 701 0 Infinity:1
ListMinimalPerf.default 533 0 Infinity:1
ListNestedPerf.default 635 0 Infinity:1
ListWith60ListItems.default 1001 0 Infinity:1
LoaderMinimalPerf.default 750 0 Infinity:1
MenuButtonMinimalPerf.default 1628 0 Infinity:1
PopupMinimalPerf.default 736 0 Infinity:1
ProviderMergeThemesPerf.default 1994 0 Infinity:1
ProviderMinimalPerf.default 992 0 Infinity:1
RadioGroupMinimalPerf.default 462 0 Infinity:1
ReactionMinimalPerf.default 459 0 Infinity:1
RefMinimalPerf.default 244 0 Infinity:1
SegmentMinimalPerf.default 411 0 Infinity:1
SkeletonMinimalPerf.default 484 0 Infinity:1
SliderMinimalPerf.default 1547 0 Infinity:1
SplitButtonMinimalPerf.default 3934 0 Infinity:1
StatusMinimalPerf.default 791 0 Infinity:1
TableMinimalPerf.default 451 0 Infinity:1
TextMinimalPerf.default 387 0 Infinity:1
TextAreaMinimalPerf.default 585 0 Infinity:1
CustomToolbarPrototype.default 3824 0 Infinity:1
TooltipMinimalPerf.default 863 0 Infinity:1
TreeWith60ListItems.default 209 0 Infinity:1
VideoMinimalPerf.default 694 0 Infinity:1
Avatar.Fluent 939 0 Infinity:1
Button.Fluent 609 0 Infinity:1
Checkbox.Fluent 653 0 Infinity:1
Dialog.Fluent 834 0 Infinity:1
Dropdown.Fluent 2974 0 Infinity:1
Icon.Fluent 772 0 Infinity:1
Image.Fluent 456 0 Infinity:1
Slider.Fluent 1532 0 Infinity:1
Text.Fluent 407 0 Infinity:1
Tooltip.Fluent 562 0 Infinity:1
TableManyItemsPerf.default 2327 1 2327:1
ToolbarMinimalPerf.default 1020 1 1020:1
MenuMinimalPerf.default 949 1 949:1
TreeMinimalPerf.default 925 1 925:1
ButtonUseCssPerf.default 866 1 866:1
IconMinimalPerf.default 730 1 730:1
ButtonSlotsPerf.default 631 1 631:1
CarouselMinimalPerf.default 489 1 489:1
LabelMinimalPerf.default 471 1 471:1
FlexMinimalPerf.default 339 1 339:1
PortalMinimalPerf.default 176 1 176:1

@size-auditor
Copy link

size-auditor bot commented Sep 28, 2020

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: f3ed22a

Possible causes

  • The baseline build f3ed22a is broken
  • The Size Auditor run for the baseline build f3ed22a was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@dzearing dzearing merged commit 3ce8f97 into microsoft:7.0 Sep 29, 2020
@dzearing dzearing deleted the chore/cherry-pick-1 branch September 29, 2020 00:24
@msft-github-bot
Copy link
Contributor

🎉office-ui-fabric-react@v7.143.0 has been released which incorporates this pull request.:tada:

Handy links:

@khmakoto khmakoto mentioned this pull request Oct 9, 2020
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@aditima aditima Awaiting requested review from aditima

Assignees

@miroslavstastny miroslavstastny

Labels
Component: GroupedList PR: API Modified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dzearing @msft-github-bot @ecraig12345 @miroslavstastny @ThomasMichon