export design system interface #15313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs cherry-pick
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7fe1774:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesUnable to find bundle size details for Baseline commit: ad56ce6 Possible causes
Recommendations
|
| @@ -571,3 +571,5 @@ export class FluentDesignSystemProvider extends DesignSystemProvider | |||
| }) | |||
| public neutralOutlineFocusDelta: number; | |||
| } | |||
|
|
|||
| export { DesignSystem }; | |||
There was a problem hiding this comment.
On line 47 you'll see this element actually omits a few properties from the DesignSystem interface. You should probably create an interface that is that omission, implement the new interface into the FluentDesignSystemProvider and export the new interface.
nicholasrice
approved these changes
Sep 30, 2020
chrisdholt
changed the title
chrisdholt
force-pushed
the
users/chhol/export-design-system-interface
branch
from
14157ab to
dd668ef
Compare
eljefe223
approved these changes
Oct 1, 2020
|
🎉 Handy links: |
40 tasks
2 tasks
xugao
removed
the
needs cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Exports the DesignSystem interface to support better typing of Fluent Design System instances.
Focus areas to test
(optional)