Image: move Image component to react and delete from react-next #15367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khmakoto
previously requested changes
Oct 5, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 12e55a9:
|
Asset size changes
Baseline commit: 424951d0fd5b15fccdf4234d546e993316acb285 (build) |
ecraig12345
reviewed
Oct 6, 2020
ecraig12345
approved these changes
Oct 6, 2020
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
|
This is nice |
Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com>
khmakoto
approved these changes
Oct 6, 2020
change/@fluentui-react-next-2020-10-05-12-10-48-image-migration-react.json
Outdated
Show resolved
Hide resolved
change/@fluentui-react-2020-10-05-12-10-48-image-migration-react.json
Outdated
Show resolved
Hide resolved
…n-react.json Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR moves the version of
Imageexisting in@fluentui/react-nextto@fluentui/react-internal. As part of this API and snapshots were updated, the@fluentui/react-nextexamples of the component were removed, and the versions of these components in@fluentui/react-nextnow re-export the versions in@fluentui/react-internal.(The Image changes in this PR are originally from #12908 where Image was converted to a function component.)
Focus areas to test
(optional)