Moving FocusTrapZone and Modal from react-next to react-internal #15368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecraig12345
reviewed
Oct 5, 2020
packages/react-internal/src/components/Dialog/__snapshots__/Dialog.deprecated.test.tsx.snap
Outdated
Show resolved
Hide resolved
|
Can you delete the FocusTrapZoneNext perf-tests and vr-tests? |
ecraig12345
reviewed
Oct 5, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 38e924b:
|
…g resetIds beforeEach and afterAll tests that were affected by these changes.
ecraig12345
reviewed
Oct 5, 2020
packages/react-internal/src/components/FocusTrapZone/FocusTrapZone.types.ts
Outdated
Show resolved
Hide resolved
Asset size changes
Baseline commit: 72907bfda0cd61232232c62de4448b6bfabd487f (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
ecraig12345
reviewed
Oct 6, 2020
packages/react-internal/src/components/Dialog/__snapshots__/Dialog.deprecated.test.tsx.snap
Outdated
Show resolved
Hide resolved
tomi-msft
approved these changes
Oct 7, 2020
ecraig12345
reviewed
Oct 7, 2020
| } else if (!newForceFocusInsideTrap || newDisabled) { | ||
| // Transition from forceFocusInsideTrap / FTZ enabled to disabled. | ||
| returnFocusToInitiator(); | ||
| if (unmodalize) { |
There was a problem hiding this comment.
Thanks for adding this part! However I think it needs to be handled a bit differently to replicate the class component behavior: the unmodalize callback should be stored in internalState, and in addition to this part you'll need to add another useEffect for componentWillUnmount.
I started trying to make this change last night and then noticed potentially a bunch of other issues with lifecycles that may not have been ported properly...so we definitely want to test this one carefully.
There was a problem hiding this comment.
I think I did this properly but let me know which other issues you've found.
ecraig12345
approved these changes
Oct 13, 2020
|
Hello @khmakoto! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
xugao
approved these changes
Oct 13, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR moves the versions of
ModalandFocusTrapZoneexisting in@fluentui/react-nextto@fluentui/react-internal. As part of this API and snapshots were updated, the@fluentui/react-nextexamples, vr tests and perf tests of these components were removed, and the versions of these components in@fluentui/react-nextnow re-export the versions in@fluentui/react-internal.Another change in this PR is that
resetIdsis now being called in those tests that were affected by this change.Focus areas to test
(optional)