Move Fabric from react-next to react-internal #15388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomi-msft
commented
Oct 6, 2020
| // import { Checkbox } from '../../Checkbox'; | ||
| // import { Customizer } from '../../Utilities'; | ||
| // import { createTheme } from '../../Styling'; | ||
| import { Checkbox } from '@fluentui/react/lib/Checkbox'; |
There was a problem hiding this comment.
@dzearing This component is not present in react-internal. What component within react-internal would you recommend using instead?
There was a problem hiding this comment.
For now let's just comment out this import and the parts of the test that use it, unless someone has a suggestion right away for another component to use.
|
/azp run |
|
No pipelines are associated with this pull request. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b5df64d:
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
You'll probably need to update snapshots in |
ecraig12345
approved these changes
Oct 7, 2020
Asset size changes
Baseline commit: 424951d0fd5b15fccdf4234d546e993316acb285 (build) |
Perf Analysis
All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeThis PR moves the version of
Fabricexisting in@fluentui/react-nextto@fluentui/react-internal. As part of this API and snapshots were updated, and the versions of these components in @fluentui/react-next now re-export the versions in @fluentui/react-internal.Focus areas to test
(optional)