-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move v8 ResizeGroup changes from react-next to react #15401
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8593ed8:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changes
Over Tolerance (1024 B) Over Baseline Below Baseline New Removed 1 kB = 1000 B Baseline commit: 1eff0e0d24d99c9feaf5b4dc9e7d6d1763e19498 (build) |
# Conflicts: # packages/react-examples/src/react/__snapshots__/CommandBar.CommandBarButtonAs.Example.tsx.shot
/azp run |
No pipelines are associated with this pull request. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Will this PR be merged into 7.0 and publish to npm as 8.0.0-alpha version? The current version (7.0 branch) is breaking the SSR. https://github.com/microsoft/fluentui/blob/7.0/packages/office-ui-fabric-react/src/utilities/hooks/useResponsiveMode.tsx#L18 |
@Gerhut Generally at this point we're not planning to port version 8 changes from master to 7, since we're going to start publishing |
Pull request checklist
$ yarn change
Description of changes
Moving ResizeGroup function component conversion from #13013 and other v8 changes from react-next back to react-internal.