[Do not review] Enabling selection for input changed for UnifiedPicker and updating example for that case #15412
Conversation
|
Thanks for submitting this change, but due to work currently in progress to prepare |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f58590f:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 66ba3997a888bc97e0ec33fc752f3be553d5ccf0 (build) |
| @@ -270,12 +270,25 @@ export const UnifiedPicker = <T extends {}>(props: IUnifiedPickerProps<T>): JSX. | |||
| props.inputProps.onClick(ev as React.MouseEvent<HTMLInputElement>); | |||
| } | |||
| }; | |||
| const _onInputChange = (value: string, composing?: boolean) => { | |||
| const _onInputChange = (value: string, composing?: boolean, resultItemsList?: T[]) => { | |||
There was a problem hiding this comment.
Would this (resultItemList) ever have a value?
There was a problem hiding this comment.
yes, it would, this is what is getting updated
| const updatedItems: IPersonaProps[] = []; | ||
| const currentItems: IPersonaProps[] = [...peopleSelectedItems]; | ||
|
|
||
| for (let i = 0; i < currentItems.length; i++) { |
There was a problem hiding this comment.
I don't think you need this, you can have the declaration be this right?
const updatedItems: IPersonaProps[] = [...peopleSelectedItems];
|
There's paste logic in the other two examples, should those get updated as well? |
Pull request checklist
$ yarn changeDescription of changes
(give an overview)
Focus areas to test
(optional)