Moving SelectedItemsList to @fluentui/react-internal package #15430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this change, but due to work currently in progress to prepare |
czearing
changed the title
ecraig12345
reviewed
Oct 8, 2020
| @@ -139,8 +139,8 @@ export class ExtendedPeoplePickerControlledExample extends React.Component<{}, I | |||
| copyMenuItemText: 'Copy name', | |||
| editMenuItemText: 'Edit', | |||
| getEditingItemText: this._getEditingItemText, | |||
| onRenderFloatingPicker: FloatingPeoplePicker, | |||
| floatingPickerProps: this._floatingPickerProps, | |||
| onRenderFloatingPicker: FloatingPeoplePicker as any, | |||
There was a problem hiding this comment.
Do you know why this was needed?
There was a problem hiding this comment.
It is because the import for SelectedItemsList comes from react-internal while FloatingPeoplePicker comes from react-next.
ecraig12345
approved these changes
Oct 8, 2020
ecraig12345
added
Component: SelectedItemsList
and removed
v8 snap: potential conflict
labels
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c17b863:
|
Asset size changes
Baseline commit: bbef6869c91cf388b5a1e7f33a869ef23476973c (build) |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
SelectedItemsListfrom react-next to react-internal (including strict mode fixes from Floating Pickers: Make pickers strict mode compliant #15131)SelectedItemsListin react-internal.SelectedItemsListNextto be removed.SelectedItemsList.