Fix issues with SpinButton revealed by eslint-plugin-react-hooks

change/@fluentui-react-internal-2020-10-08-11-29-41-feat-react-internal-spinButton-onChange.json

@@ -0,0 +1,8 @@
+{
+  "type": "prerelease",
+  "comment": "Updating react-internal SpinButton to handle onChange.",
+  "packageName": "@fluentui/react-internal",
+  "email": "czearing@outlook.com",
+  "dependentChangeType": "patch",
+  "date": "2020-10-08T18:29:41.503Z"
+}

packages/react-examples/src/react/SpinButton/SpinButton.Stateful.Example.tsx

@@ -42,18 +42,26 @@ const onSpinButtonValidate = (value: string) => {
   return String(value) + suffix;
 };
 
-export const SpinButtonStatefulExample: React.FC = () => (
-  <div style={{ width: '400px' }}>
-    <SpinButton
-      label={'SpinButton with custom implementation:'}
-      min={0}
-      max={100}
-      value={'7' + suffix}
-      onValidate={onSpinButtonValidate}
-      onIncrement={onSpinButtonIncrement}
-      onDecrement={onSpinButtonDecrement}
-      incrementButtonAriaLabel={'Increase value by 2'}
-      decrementButtonAriaLabel={'Decrease value by 2'}
-    />
-  </div>
-);
+export const SpinButtonStatefulExample: React.FC = () => {
+  const [spinButtonValue, setSpinButtonValue] = React.useState<string>('7' + suffix);
+
+  return (
+    <div style={{ width: '400px' }}>
+      <SpinButton
+        label={'SpinButton with custom implementation:'}
+        min={0}
+        max={100}
+        value={spinButtonValue}
+        onValidate={onSpinButtonValidate}
+        onIncrement={onSpinButtonIncrement}
+        onDecrement={onSpinButtonDecrement}
+        // eslint-disable-next-line react/jsx-no-bind
+        onChange={(ev: React.FormEvent<HTMLInputElement | HTMLTextAreaElement>, newValue: string): void =>
+          setSpinButtonValue(newValue)
+        }
+        incrementButtonAriaLabel={'Increase value by 2'}
+        decrementButtonAriaLabel={'Decrease value by 2'}
+      />
+    </div>
+  );
+};

packages/react-examples/src/react/__snapshots__/SpinButton.Stateful.Example.tsx.shot

@@ -95,6 +95,7 @@ exports[`Component Examples renders SpinButton.Stateful.Example.tsx correctly 1`
             border-color: Highlight;
           }
       data-ktp-target={true}
+      onChange={[Function]}
     >
       <input
         aria-disabled={false}

packages/react-internal/etc/react-internal.api.md

@@ -4597,7 +4597,7 @@ export interface ISpinButton {
 }
 
 // @public (undocumented)
-export interface ISpinButtonProps extends React.HTMLAttributes<HTMLDivElement>, React.RefAttributes<HTMLDivElement> {
+export interface ISpinButtonProps extends React.HTMLAttributes<HTMLInputElement | HTMLTextAreaElement>, React.RefAttributes<HTMLDivElement> {
     ariaDescribedBy?: string;
     ariaLabel?: string;
     ariaPositionInSet?: number;
@@ -4623,6 +4623,7 @@ export interface ISpinButtonProps extends React.HTMLAttributes<HTMLDivElement>,
     max?: number;
     min?: number;
     onBlur?: React.FocusEventHandler<HTMLInputElement>;
+    onChange?: (ev?: React.FormEvent<HTMLInputElement | HTMLTextAreaElement>, newValue?: string) => void;
     onDecrement?: (value: string, event?: React.MouseEvent<HTMLElement> | React.KeyboardEvent<HTMLElement>) => string | void;
     onFocus?: React.FocusEventHandler<HTMLInputElement>;
     onIncrement?: (value: string, event?: React.MouseEvent<HTMLElement> | React.KeyboardEvent<HTMLElement>) => string | void;