Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UI builder): Add ability to compute screen reader narration of focused element in … …use mode #15464

Merged
merged 40 commits into from
Oct 12, 2020
Merged

feat(UI builder): Add ability to compute screen reader narration of focused element in … …use mode #15464

merged 40 commits into from
Oct 12, 2020

Commits on Sep 4, 2020

  1. Integrated the message computation script by Adam into UI Builder

    @adamsamec
    adamsamec committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    37afedc View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. Rename and reformat changes

    @adamsamec
    adamsamec committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    b464da0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into narration-computation

    @adamsamec
    adamsamec committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    9e8f8f2 View commit details
    Browse the repository at this point in the history

  3. Fix type errors

    @adamsamec
    adamsamec committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    dd0fdfd View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. Implement suggestions from PR for better readability of the code

    @adamsamec
    adamsamec committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    d6d371b View commit details
    Browse the repository at this point in the history

  2. Refactorring of the code. Mainly rewritten the large computeMessage()… 

    … function into smaller ones.
    @adamsamec
    adamsamec committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    b56ca8e View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2020

  1. Fix narration computation for elements with checked DOM property as s… 

    …tate. Fix textarea not to narrate value. Refactoring and comment edit and addition.
    @adamsamec
    adamsamec committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    03de7e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2020

  1. Rename to screen reader narration computation

    @adamsamec
    adamsamec committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    0e77c3f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into narration-computation

    @adamsamec
    adamsamec committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    63df501 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. Refactor getDefinitionName() method in NarrationComputer.tsx for conc… 

    …iseness

Co-authored-by: Charles Assunção <junioassuncaocharles@gmail.com>
    @adamsamec @assuncaocharles
    adamsamec and assuncaocharles authored Sep 17, 2020
    Configuration menu
    Copy the full SHA
    69b3abf View commit details
    Browse the repository at this point in the history

  2. Replace default exports with named exports.

    @adamsamec
    adamsamec committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    5228b78 View commit details
    Browse the repository at this point in the history

  3. Remove private modifier

    @adamsamec
    adamsamec committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    6d66188 View commit details
    Browse the repository at this point in the history

  4. Change to a more readable type

    @adamsamec
    adamsamec committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    a495f92 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. Rewrite the code not to use label for the for-loop and refactoring

    @adamsamec
    adamsamec committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    20e58b8 View commit details
    Browse the repository at this point in the history

  2. Update packages/fluentui/react-builder/src/components/NarrationComput… 

    …er.tsx

Co-authored-by: Charles Assunção <junioassuncaocharles@gmail.com>
    @adamsamec @assuncaocharles
    adamsamec and assuncaocharles authored Sep 18, 2020
    Configuration menu
    Copy the full SHA
    dadfa36 View commit details
    Browse the repository at this point in the history

  3. Reverting the last commit,

    @adamsamec
    adamsamec committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    a13abc7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'narration-computation' of https://github.com/adamsamec/… 

    …fluentui into narration-computation
    @adamsamec
    adamsamec committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    5a4ff5e View commit details
    Browse the repository at this point in the history

  5. Comment change

    @adamsamec
    adamsamec committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    cb47801 View commit details
    Browse the repository at this point in the history

  6. Replace for loop with Array.forEach().

    @adamsamec
    adamsamec committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    3cd647c View commit details
    Browse the repository at this point in the history

  7. Resolve lint errors

    @adamsamec
    adamsamec committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    dae82f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2020

  1. Remove empty file northstar. Have no idea how it was created-

    @adamsamec
    adamsamec committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    742ddff View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Remove showNarration condition

    @adamsamec
    adamsamec committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    9ec256d View commit details
    Browse the repository at this point in the history

  2. Replace condition with ternary operator.

    @adamsamec
    adamsamec committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    ae51ced View commit details
    Browse the repository at this point in the history

  3. Add missing quotes in a CSS definition. 

    Co-authored-by: Charles Assunção <junioassuncaocharles@gmail.com>
    @adamsamec @assuncaocharles
    adamsamec and assuncaocharles authored Sep 23, 2020
    Configuration menu
    Copy the full SHA
    8b3a33f View commit details
    Browse the repository at this point in the history

  4. Replace condition with ternary operator

    @adamsamec
    adamsamec committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    d9c23ee View commit details
    Browse the repository at this point in the history

  5. Rename parameter and add type"

    @adamsamec
    adamsamec committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    70149fa View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Merge branch 'master' into narration-computation

    @adamsamec
    adamsamec committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    146c5dd View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Integrate descendant element screen reader narration computation into… 

    … the UI Builder
    @adamsamec
    adamsamec committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    8a6d454 View commit details
    Browse the repository at this point in the history

  2. Refactoring and handle the case where there are no elements for the s… 

    …elected component.
    @adamsamec
    adamsamec committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    79b8d4a View commit details
    Browse the repository at this point in the history

  3. Refactoring, narration now computes for all focusable elements, and p… 

    …ath shows computed name of element.
    @adamsamec
    adamsamec committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    d59e7e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2020

  1. Fix for duplicate narration of the text 'Narration: '

    @adamsamec
    adamsamec committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    84a826d View commit details
    Browse the repository at this point in the history

  2. Add a small comment

    @adamsamec
    adamsamec committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    f1dc8e9 View commit details
    Browse the repository at this point in the history

  3. Add a comment and parenthesis around a arrow function parameter

    @adamsamec
    adamsamec committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    298d267 View commit details
    Browse the repository at this point in the history

  4. Edit comment and try to add parenthesis again

    @adamsamec
    adamsamec committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    4913cd5 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2020

  1. Revert the change to config.ts and refactoring of a if statement

    @adamsamec
    adamsamec committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    074daa1 View commit details
    Browse the repository at this point in the history

  2. Refactor for loop into forEach loop

    @adamsamec
    adamsamec committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    03c9ea7 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Merge master

    @adamsamec
    adamsamec committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    17ebcc1 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. Screen reader now computes the narration immediately on every change … 

    …of component props
    @adamsamec
    adamsamec committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    a5b5bfe View commit details
    Browse the repository at this point in the history

  2. Merge master

    @adamsamec
    adamsamec committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    378ad9b View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2020

  1. Add ability to compute screen reader narration of focused element in … 

    …use mode. Fix bug with narration path dropdown always selecting the first option.
    @adamsamec
    adamsamec committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    ffebdd1 View commit details
    Browse the repository at this point in the history