Add custom KeyUp support to Group Header #15478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs cherry-pick
40 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 861894f:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 33a6732:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changes
Baseline commit: 172f3340317a7f3d434d82334716db24b3b63ede (build) |
Is there something that I should be doing about this? |
dzearing
reviewed
Oct 15, 2020
packages/office-ui-fabric-react/etc/office-ui-fabric-react.api.md
Outdated
Show resolved
Hide resolved
dzearing
reviewed
Oct 15, 2020
packages/office-ui-fabric-react/src/components/GroupedList/GroupHeader.base.tsx
Outdated
Show resolved
Hide resolved
dzearing
reviewed
Oct 15, 2020
packages/office-ui-fabric-react/src/components/GroupedList/GroupHeader.base.tsx
Outdated
Show resolved
Hide resolved
dzearing
reviewed
Oct 15, 2020
packages/office-ui-fabric-react/src/components/GroupedList/GroupedList.types.ts
Outdated
Show resolved
Hide resolved
|
Hello @khmakoto! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
2 tasks
msft-github-bot
pushed a commit
that referenced
this pull request
Oct 20, 2020
…15624) <!-- !!!!!!! IMPORTANT !!!!!!! Due to work we're currently doing to prepare master branch for our version 8 beta release, please hold-off submitting the PR until around October 12 if it's not urgent. If it is urgent, please submit the PR targeting the 7.0 branch. This change does not apply to react-northstar contributors. See #15222 for more details. Sorry for the inconvenience and short notice. --> #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes _Cherry-pick of #15478._ _Original PR description:_ Give the user the ability to override what happens with KeyUp. Currently it is only used with Right/Left to expand and collapse the group. #### Focus areas to test Ensure that Right/Left to expand and collapse still works.
SethDonohue
pushed a commit
to SethDonohue/fluentui
that referenced
this pull request
Nov 2, 2020
…icrosoft#15624) <!-- !!!!!!! IMPORTANT !!!!!!! Due to work we're currently doing to prepare master branch for our version 8 beta release, please hold-off submitting the PR until around October 12 if it's not urgent. If it is urgent, please submit the PR targeting the 7.0 branch. This change does not apply to react-northstar contributors. See microsoft#15222 for more details. Sorry for the inconvenience and short notice. --> #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes _Cherry-pick of microsoft#15478._ _Original PR description:_ Give the user the ability to override what happens with KeyUp. Currently it is only used with Right/Left to expand and collapse the group. #### Focus areas to test Ensure that Right/Left to expand and collapse still works.
ecraig12345
removed
the
needs cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Give the user the ability to override what happens with KeyUp. Currently it is only used with Right/Left to expand and collapse the group.
Focus areas to test
Ensure that Right/Left to expand and collapse still works.