Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Avoid React.Children.count traversal for empty state early return #15503

Merged
merged 7 commits into from
Nov 13, 2020
Merged

[Perf] Avoid React.Children.count traversal for empty state early return #15503

merged 7 commits into from
Nov 13, 2020
+22 −5

Commits on Oct 13, 2020

  1. Refactor empty child conditionals

    @KevinTCoughlin
    KevinTCoughlin committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    421ecad View commit details
    Browse the repository at this point in the history

  2. Change files

    @KevinTCoughlin
    KevinTCoughlin committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    a41cdc2 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. Explicitly check children are undefined to handle 0 as falsey

    @KevinTCoughlin
    KevinTCoughlin committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    ce3d9bb View commit details
    Browse the repository at this point in the history

  2. Prefer == null per review comment

    @KevinTCoughlin
    KevinTCoughlin committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    5d3e0fe View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2020

  1. Update change/@fluentui-react-internal-2020-10-13-16-47-27-keco-react… 

    …-children-for-empty.json
    @ecraig12345
    ecraig12345 authored Oct 24, 2020
    Configuration menu
    Copy the full SHA
    165e68f View commit details
    Browse the repository at this point in the history

  2. Update change/@uifabric-react-cards-2020-10-13-16-47-27-keco-react-ch… 

    …ildren-for-empty.json
    @ecraig12345
    ecraig12345 authored Oct 24, 2020
    Configuration menu
    Copy the full SHA
    341f12b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into keco/react-children-for-empty

    @ecraig12345
    ecraig12345 authored Oct 24, 2020
    Configuration menu
    Copy the full SHA
    c3def6f View commit details
    Browse the repository at this point in the history