Removing findDOMNode usage from Pivot #15558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this change, but due to work currently in progress to prepare |
ecraig12345
reviewed
Oct 16, 2020
ecraig12345
reviewed
Oct 16, 2020
ecraig12345
reviewed
Oct 16, 2020
|
Hmm actually never mind, the build seems to have passed with no snapshot changes?? |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d63fd49:
|
Asset size changes
Baseline commit: d2fedc85c81bb0e2d86495ec1e928604bf2260f4 (build) |
behowell
approved these changes
Oct 16, 2020
Comment on lines
69
to
86
| const { componentRef, theme, linkSize, linkFormat, overflowBehavior } = props; | ||
| const pivotId: string = useId('Pivot'); | ||
| let linkCollection = getLinkItems(props, pivotId); | ||
| const focusZoneRef = React.useRef<IFocusZone>(null); | ||
| const divProps = getNativeProps<React.HTMLAttributes<HTMLDivElement>>(props, divProperties); | ||
| const overflowMenuButtonComponentRef = React.useRef<IButton>(null); | ||
| const pivotId: string = useId('Pivot'); | ||
|
|
||
| const [selectedKey, setSelectedKey] = useControllableValue(props.selectedKey, props.defaultSelectedKey); | ||
|
|
||
| const { componentRef, theme, linkSize, linkFormat, overflowBehavior } = props; | ||
| // The overflow menu starts empty and items[] is updated as the overflow items change | ||
| const overflowMenuProps: IContextualMenuProps = { | ||
| items: [], | ||
| doNotLayer: true, | ||
| alignTargetEdge: true, | ||
| directionalHint: DirectionalHint.bottomRightEdge, | ||
| }; | ||
|
|
||
| let classNames: { [key in keyof IPivotStyles]: string }; | ||
| const divProps = getNativeProps<React.HTMLAttributes<HTMLDivElement>>(props, divProperties); | ||
|
|
||
| let linkCollection = getLinkItems(props, pivotId); |
There was a problem hiding this comment.
(nit) out of curiosity, why are you moving around so many lines of code in this function? It's fine to clean things up if the code is messy, but this doesn't necessarily seem better than it was before. (E.g. previously, overflowMenuProps was declared closer to where it's used, which makes more sense to me). It's not necessarily a problem, but it seems unnecessary and makes the diff harder to read.
There was a problem hiding this comment.
I reverted the overflowMenuProps move and the diffing should be improved. The intention is to help keep consistency in Pivot’s useRef and useState/useControllableValue placement to follow patterns in other functional components.
…eat/react-internal-pivot-findDOMNode
ecraig12345
approved these changes
Oct 17, 2020
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Removing findDOMNode usage from the react-tabs
Pivotcomponent.Changing BaseButton's wrapper span to a fragment in react-internal
(This change was made to allow elementRef to recieve the root element.)
Adding an elementRef to Pivot's CommandButton
Updating Pivot's CommandButton className
Other Minor Changes
setOverflowMenuButtonRefand replacing it withoverflowMenuButtonRefFocus areas to test
Pivot,BaseButton