Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable marquee selection undesirable in UPP #15589

Merged
merged 24 commits into from
Oct 20, 2020
Merged

Disable marquee selection undesirable in UPP #15589

merged 24 commits into from
Oct 20, 2020

Conversation

sjadelson
Copy link
Contributor

@sjadelson sjadelson commented Oct 19, 2020 •
edited
Loading

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

MarqueeSelection is not the desired mouse selection paradigm for UPP. It also "hijacks" mouse selection in the message body. This CL will remove MS in UPP, giving us the same experience as shipped OWA - no drag mouse selection. We will give a better experience in a future checkin.

Focus areas to test

(optional)

Steve Adelson added 23 commits August 12, 2020 09:45
Preliminary dual wells
90555ab
Merge branch 'master' of https://github.com/microsoft/fluentui
30de4d1
Revert changes in this file
d3ab999
Change files
a6b4e75
Modify comment on change file to reflect change
4702218
Fixed comma :(
6e28377
Change files
c290cfa
Add a second recipient well example and fix the Remove ctx menu examples
7a1b91c
Change files
732c123
Merge branch 'master' of https://github.com/microsoft/fluentui
7b1044b
Merge branch 'master' of https://github.com/sjadelson/fluentui
502bde5
Reverting UnifiedPeoplePicked.Example.tsx
eed1acb
Merge branch 'master' of https://github.com/microsoft/fluentui
9187093
Per CR suggestion, importing shared code from UPP
8847865
eslint wants imports to be absolute paths
9d048af
Trying to work around build eslint check issue
6133123
Merge branch 'master' of https://github.com/microsoft/fluentui
bbe0bc0
Merge branch 'master' of https://github.com/microsoft/fluentui
34c314b
Merge branch 'master' of https://github.com/microsoft/fluentui
4a8020a
Merge branch 'master' of https://github.com/microsoft/fluentui into m…
f92badc 
…aster
Remove undesired MarqueeSelection in UPP
a12dcd0
Change files
133bf32
Remove old unused change file
d9c7c85
@msft-github-bot
Copy link
Contributor

Thanks for submitting this change, but due to work currently in progress to prepare master for our version 8 beta release, we're asking contributors to either wait a couple weeks to submit changes (if it's not urgent) or submit to the new 7.0 branch (if it's urgent). See #15222 for more details. Thank you for your contribution and understanding!

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 19, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e19187e:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Oct 19, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 847 853 5000
BaseButtonCompat mount 903 937 5000
Breadcrumb mount 166552 167874 5000
Checkbox mount 1512 1532 5000
CheckboxBase mount 1346 1291 5000
ChoiceGroup mount 4789 4877 5000
ComboBox mount 983 986 1000
CommandBar mount 22767 22853 1000
ContextualMenu mount 6410 6420 1000
DefaultButtonCompat mount 1187 1179 5000
DetailsRow mount 3720 3825 5000
DetailsRowFast mount 3752 3737 5000
DetailsRowNoStyles mount 3596 3553 5000
Dialog mount 1525 1555 1000
DocumentCardTitle mount 1877 1915 1000
Dropdown mount 3844 3841 5000
FocusTrapZone mount 1859 1821 5000
FocusZone mount 1821 1822 5000
IconButtonCompat mount 1833 1796 5000
Label mount 340 342 5000
Layer mount 1837 1819 5000
Link mount 468 466 5000
MenuButtonCompat mount 1504 1497 5000
MessageBar mount 2101 2130 5000
Nav mount 3330 3299 1000
OverflowSet mount 1076 1080 5000
Panel mount 1443 1463 1000
Persona mount 876 897 1000
Pivot mount 1407 1418 1000
PrimaryButtonCompat mount 1313 1349 5000
Rating mount 7575 7746 5000
SearchBox mount 1385 1354 5000
Shimmer mount 2626 2546 5000
Slider mount 1963 1968 5000
SpinButton mount 5294 5194 5000
Spinner mount 456 421 5000
SplitButtonCompat mount 3307 3260 5000
Stack mount 553 505 5000
StackWithIntrinsicChildren mount 1929 1967 5000
StackWithTextChildren mount 5025 4981 5000
SwatchColorPicker mount 10504 10481 5000
TagPicker mount 2790 2736 5000
TeachingBubble mount 11860 11814 5000
Text mount 437 421 5000
TextField mount 1424 1441 5000
ThemeProvider mount 2024 2000 5000
ThemeProvider virtual-rerender 679 683 5000
Toggle mount 825 804 5000
button mount 580 549 5000
buttonNative mount 115 121 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.46 0.52 0.88:1 2000 917
🦄 Button.Fluent 0.12 0.21 0.57:1 5000 584
🔧 Checkbox.Fluent 0.68 0.35 1.94:1 1000 675
🦄 Dialog.Fluent 0.16 0.24 0.67:1 5000 820
🔧 Dropdown.Fluent 3.09 0.45 6.87:1 1000 3090
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 768
🦄 Image.Fluent 0.08 0.13 0.62:1 5000 412
🔧 Slider.Fluent 1.66 0.46 3.61:1 1000 1659
🔧 Text.Fluent 0.08 0.04 2:1 5000 407
🦄 Tooltip.Fluent 0.12 0.92 0.13:1 5000 599

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
SkeletonMinimalPerf.default 485 427 1.14:1
PortalMinimalPerf.default 193 176 1.1:1
ListMinimalPerf.default 553 518 1.07:1
VideoMinimalPerf.default 677 630 1.07:1
AnimationMinimalPerf.default 443 419 1.06:1
IconMinimalPerf.default 760 717 1.06:1
TableMinimalPerf.default 456 430 1.06:1
ButtonUseCssPerf.default 884 843 1.05:1
HeaderSlotsPerf.default 840 798 1.05:1
ListNestedPerf.default 609 579 1.05:1
RadioGroupMinimalPerf.default 473 450 1.05:1
Text.Fluent 407 388 1.05:1
Tooltip.Fluent 599 570 1.05:1
AttachmentSlotsPerf.default 1212 1166 1.04:1
ImageMinimalPerf.default 425 408 1.04:1
InputMinimalPerf.default 1421 1364 1.04:1
Image.Fluent 412 397 1.04:1
AvatarMinimalPerf.default 512 498 1.03:1
LayoutMinimalPerf.default 440 429 1.03:1
ListWith60ListItems.default 990 964 1.03:1
LoaderMinimalPerf.default 785 764 1.03:1
AccordionMinimalPerf.default 179 175 1.02:1
ButtonOverridesMissPerf.default 1813 1773 1.02:1
ChatDuplicateMessagesPerf.default 457 450 1.02:1
ChatWithPopoverPerf.default 512 503 1.02:1
HeaderMinimalPerf.default 406 398 1.02:1
MenuButtonMinimalPerf.default 1666 1635 1.02:1
SegmentMinimalPerf.default 382 375 1.02:1
StatusMinimalPerf.default 766 749 1.02:1
Checkbox.Fluent 675 665 1.02:1
Dropdown.Fluent 3090 3041 1.02:1
BoxMinimalPerf.default 392 389 1.01:1
FormMinimalPerf.default 427 423 1.01:1
LabelMinimalPerf.default 455 451 1.01:1
PopupMinimalPerf.default 755 749 1.01:1
TableManyItemsPerf.default 2259 2230 1.01:1
CustomToolbarPrototype.default 4151 4107 1.01:1
ToolbarMinimalPerf.default 982 977 1.01:1
CardMinimalPerf.default 590 591 1:1
CarouselMinimalPerf.default 472 473 1:1
CheckboxMinimalPerf.default 2998 2985 1:1
DropdownMinimalPerf.default 3082 3088 1:1
EmbedMinimalPerf.default 1994 1995 1:1
GridMinimalPerf.default 364 364 1:1
ProviderMergeThemesPerf.default 2188 2187 1:1
ProviderMinimalPerf.default 1090 1085 1:1
ButtonUseCssNestingPerf.default 1143 1150 0.99:1
DialogMinimalPerf.default 833 843 0.99:1
DropdownManyItemsPerf.default 781 791 0.99:1
ItemLayoutMinimalPerf.default 1333 1346 0.99:1
ListCommonPerf.default 670 674 0.99:1
SliderMinimalPerf.default 1632 1652 0.99:1
SplitButtonMinimalPerf.default 3872 3909 0.99:1
Avatar.Fluent 917 926 0.99:1
Dialog.Fluent 820 828 0.99:1
Slider.Fluent 1659 1682 0.99:1
ButtonMinimalPerf.default 181 185 0.98:1
TreeMinimalPerf.default 918 935 0.98:1
AttachmentMinimalPerf.default 171 176 0.97:1
ChatMinimalPerf.default 651 668 0.97:1
MenuMinimalPerf.default 899 924 0.97:1
RefMinimalPerf.default 247 254 0.97:1
TextAreaMinimalPerf.default 515 531 0.97:1
TooltipMinimalPerf.default 865 895 0.97:1
TreeWith60ListItems.default 218 225 0.97:1
Button.Fluent 584 599 0.97:1
ButtonSlotsPerf.default 614 637 0.96:1
FlexMinimalPerf.default 312 326 0.96:1
TextMinimalPerf.default 380 394 0.96:1
Icon.Fluent 768 797 0.96:1
DividerMinimalPerf.default 387 406 0.95:1
AlertMinimalPerf.default 313 340 0.92:1
ReactionMinimalPerf.default 426 473 0.9:1

@size-auditor
Copy link

size-auditor bot commented Oct 19, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 3346b09e82b41f6b5b96fe1a94c8d122b3a4625b (build)

@elisabethcvs elisabethcvs merged commit 6478d04 into microsoft:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebhatna nebhatna nebhatna approved these changes

@elisabethcvs elisabethcvs elisabethcvs approved these changes

@ecraig12345 ecraig12345 Awaiting requested review from ecraig12345

Assignees

@khmakoto khmakoto

@tomi-msft tomi-msft

Labels
Component: UnifiedPicker Package: experiments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sjadelson @msft-github-bot @elisabethcvs @nebhatna @ecraig12345 @khmakoto @tomi-msft