Rename @uifabric/variants to @fluentui/scheme-utilities #15598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecraig12345
approved these changes
Oct 19, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 09b68f6:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ddb628724b27b6be3d430ea0a7b728ac9adfb8ec (build) |
khmakoto
approved these changes
Oct 20, 2020
xugao
force-pushed
the
xgao/rename_variants_package
branch
from
f595958
to
09b68f6
Compare
phkuo
reviewed
Oct 20, 2020
|
|
||
| The following example uses [getTheme()](https://github.com/microsoft/fluentui/blob/master/packages/style-utilities/src/styles/theme.ts) to grab the current global theme, then creates a strong variant of the that theme, and applies that strong variant to the components wrapped by Customizer. | ||
| The following example creates a strong variant of a given theme, and applies that strong variant to the components wrapped by `ThemeProvider`. |
There was a problem hiding this comment.
are we renaming "variants" itself too?
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
rename @uifabric/variants to @fluentui/scheme-utilities
Related issue: #13384
Focus areas to test
(optional)