Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename @fluentui/react-icons to @fluentui/react-icons-mdl2 #15599

Merged
merged 4 commits into from
Oct 20, 2020
Merged

Rename @fluentui/react-icons to @fluentui/react-icons-mdl2 #15599

merged 4 commits into from
Oct 20, 2020

Conversation

tomi-msft
Copy link
Contributor

@tomi-msft tomi-msft commented Oct 19, 2020 •
edited
Loading

Pull request checklist

Description of changes

Rename @fluentui/react-icons to @fluentui/react-icons-mdl2

Majority of the files are svg icons that are renamed, but implementation unchanged

Focus areas to test

(optional)

@tomi-msft tomi-msft mentioned this pull request Oct 19, 2020
Closed
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 19, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bb85b04:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Oct 19, 2020 •
edited
Loading

Perf Analysis

Scenario Render type Master Ticks PR Ticks Iterations Status
StackWithIntrinsicChildren mount 1583 1906 5000 Possible regression
StackWithTextChildren mount 4680 4983 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 838 861 5000
BaseButtonCompat mount 898 914 5000
Breadcrumb mount 159730 160600 5000
Checkbox mount 1524 1476 5000
CheckboxBase mount 1281 1232 5000
ChoiceGroup mount 4654 4709 5000
ComboBox mount 971 966 1000
CommandBar mount 21896 21861 1000
ContextualMenu mount 6120 6241 1000
DefaultButtonCompat mount 1130 1132 5000
DetailsRow mount 3642 3662 5000
DetailsRowFast mount 3601 3624 5000
DetailsRowNoStyles mount 3515 3452 5000
Dialog mount 1515 1498 1000
DocumentCardTitle mount 1822 1831 1000
Dropdown mount 3712 3734 5000
FocusTrapZone mount 1798 1804 5000
FocusZone mount 1852 1801 5000
IconButtonCompat mount 1753 1730 5000
Label mount 336 334 5000
Layer mount 1788 1777 5000
Link mount 473 482 5000
MenuButtonCompat mount 1471 1480 5000
MessageBar mount 2042 2064 5000
Nav mount 3281 3264 1000
OverflowSet mount 1045 1058 5000
Panel mount 1426 1459 1000
Persona mount 862 880 1000
Pivot mount 1414 1414 1000
PrimaryButtonCompat mount 1267 1318 5000
Rating mount 7470 7461 5000
SearchBox mount 1314 1324 5000
Shimmer mount 2545 2573 5000
Slider mount 1936 1917 5000
SpinButton mount 5540 5141 5000
Spinner mount 423 431 5000
SplitButtonCompat mount 3183 3187 5000
Stack mount 492 518 5000
StackWithIntrinsicChildren mount 1583 1906 5000 Possible regression
StackWithTextChildren mount 4680 4983 5000 Possible regression
SwatchColorPicker mount 10324 10285 5000
TagPicker mount 2759 2762 5000
TeachingBubble mount 11609 11590 5000
Text mount 417 443 5000
TextField mount 1374 1364 5000
ThemeProvider mount 1954 1977 5000
ThemeProvider virtual-rerender 646 647 5000
Toggle mount 798 779 5000
button mount 533 552 5000
buttonNative mount 109 112 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.45 0.51 0.88:1 2000 902
🦄 Button.Fluent 0.12 0.23 0.52:1 5000 582
🔧 Checkbox.Fluent 0.65 0.34 1.91:1 1000 646
🎯 Dialog.Fluent 0.16 0.23 0.7:1 5000 808
🔧 Dropdown.Fluent 2.99 0.45 6.64:1 1000 2990
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 745
🦄 Image.Fluent 0.08 0.13 0.62:1 5000 389
🔧 Slider.Fluent 1.62 0.45 3.6:1 1000 1617
🔧 Text.Fluent 0.08 0.04 2:1 5000 375
🦄 Tooltip.Fluent 0.12 0.92 0.13:1 5000 620

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 177 163 1.09:1
Tooltip.Fluent 620 574 1.08:1
ButtonMinimalPerf.default 191 179 1.07:1
AttachmentMinimalPerf.default 178 168 1.06:1
RefMinimalPerf.default 251 240 1.05:1
BoxMinimalPerf.default 396 382 1.04:1
HeaderSlotsPerf.default 826 794 1.04:1
LabelMinimalPerf.default 441 424 1.04:1
ListCommonPerf.default 681 656 1.04:1
ListMinimalPerf.default 517 495 1.04:1
RadioGroupMinimalPerf.default 474 455 1.04:1
SkeletonMinimalPerf.default 454 438 1.04:1
ChatMinimalPerf.default 655 637 1.03:1
FormMinimalPerf.default 434 422 1.03:1
InputMinimalPerf.default 1357 1322 1.03:1
LoaderMinimalPerf.default 773 753 1.03:1
ToolbarMinimalPerf.default 985 955 1.03:1
ButtonSlotsPerf.default 623 613 1.02:1
ButtonUseCssPerf.default 854 839 1.02:1
CheckboxMinimalPerf.default 2989 2918 1.02:1
DialogMinimalPerf.default 822 802 1.02:1
EmbedMinimalPerf.default 1975 1939 1.02:1
ItemLayoutMinimalPerf.default 1311 1289 1.02:1
ListWith60ListItems.default 964 944 1.02:1
ProviderMinimalPerf.default 1074 1057 1.02:1
ReactionMinimalPerf.default 427 419 1.02:1
SegmentMinimalPerf.default 371 365 1.02:1
SliderMinimalPerf.default 1615 1579 1.02:1
TreeWith60ListItems.default 214 210 1.02:1
VideoMinimalPerf.default 676 661 1.02:1
Button.Fluent 582 572 1.02:1
AlertMinimalPerf.default 318 314 1.01:1
AvatarMinimalPerf.default 492 486 1.01:1
ButtonUseCssNestingPerf.default 1127 1112 1.01:1
ChatWithPopoverPerf.default 489 482 1.01:1
DropdownManyItemsPerf.default 762 751 1.01:1
DropdownMinimalPerf.default 2986 2971 1.01:1
FlexMinimalPerf.default 324 320 1.01:1
GridMinimalPerf.default 369 365 1.01:1
HeaderMinimalPerf.default 389 387 1.01:1
CustomToolbarPrototype.default 4027 3992 1.01:1
TooltipMinimalPerf.default 836 828 1.01:1
TreeMinimalPerf.default 900 887 1.01:1
Icon.Fluent 745 740 1.01:1
ButtonOverridesMissPerf.default 1723 1718 1:1
ImageMinimalPerf.default 406 404 1:1
LayoutMinimalPerf.default 435 435 1:1
SplitButtonMinimalPerf.default 3822 3811 1:1
StatusMinimalPerf.default 737 738 1:1
TextMinimalPerf.default 376 377 1:1
TextAreaMinimalPerf.default 505 507 1:1
Checkbox.Fluent 646 646 1:1
Dropdown.Fluent 2990 2999 1:1
Text.Fluent 375 374 1:1
CarouselMinimalPerf.default 462 468 0.99:1
ChatDuplicateMessagesPerf.default 428 433 0.99:1
ListNestedPerf.default 589 592 0.99:1
MenuMinimalPerf.default 884 895 0.99:1
MenuButtonMinimalPerf.default 1580 1601 0.99:1
ProviderMergeThemesPerf.default 2120 2134 0.99:1
TableManyItemsPerf.default 2181 2196 0.99:1
Dialog.Fluent 808 815 0.99:1
CardMinimalPerf.default 578 592 0.98:1
DividerMinimalPerf.default 386 393 0.98:1
PopupMinimalPerf.default 726 740 0.98:1
TableMinimalPerf.default 421 431 0.98:1
Slider.Fluent 1617 1658 0.98:1
AnimationMinimalPerf.default 421 432 0.97:1
AttachmentSlotsPerf.default 1146 1176 0.97:1
Image.Fluent 389 403 0.97:1
IconMinimalPerf.default 692 722 0.96:1
Avatar.Fluent 902 935 0.96:1
PortalMinimalPerf.default 169 177 0.95:1

@size-auditor
Copy link

size-auditor bot commented Oct 20, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 9c92b506d8139d1ab596caaec276774d9ae27b81 (build)

@ecraig12345 ecraig12345 merged commit 53457a5 into microsoft:master Oct 20, 2020
@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-icons-mdl2@v1.0.0-beta.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-checkbox@v1.0.0-beta.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-button@v1.0.0-beta.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@dzearing dzearing Awaiting requested review from dzearing

@xugao xugao Awaiting requested review from xugao

@khmakoto khmakoto Awaiting requested review from khmakoto

Assignees

@tomi-msft tomi-msft

Labels
PR: Possible Perf Regression 🐌
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomi-msft @msft-github-bot @ecraig12345