Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VerticalStackedBarChart] bar gaps and rounded corners #15606

Merged
merged 5 commits into from
Oct 21, 2020
Merged

[VerticalStackedBarChart] bar gaps and rounded corners #15606

merged 5 commits into from
Oct 21, 2020

Conversation

mbest
Copy link
Member

@mbest mbest commented Oct 20, 2020 •
edited
Loading

Pull request checklist

  • Include a change request file using $ yarn change

Description of changes

Add support for two styling parameters for vertical stacked bar chart:

  • rounded top corners (border radius)
  • spacing between bars (bar gap); given as a maximum gap in pixels

image

@mbest mbest requested a review from Raghurk as a code owner October 20, 2020 04:34
@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 20, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 20, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6d685e5:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-next-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Oct 20, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
Avatar mount 915 868 5000
BaseButton mount 1023 1011 5000
Breadcrumb mount 43260 42812 5000
ButtonNext mount 787 753 5000
Checkbox mount 1767 1758 5000
CheckboxBase mount 1480 1497 5000
ChoiceGroup mount 5511 5471 5000
ComboBox mount 1007 1014 1000
CommandBar mount 8120 8109 1000
ContextualMenu mount 14581 14888 1000
DefaultButton mount 1272 1256 5000
DetailsRow mount 4057 3974 5000
DetailsRowFast mount 3988 4107 5000
DetailsRowNoStyles mount 3804 3739 5000
Dialog mount 1598 1626 1000
DocumentCardTitle mount 1860 1877 1000
Dropdown mount 2937 2821 5000
FocusTrapZone mount 1844 1874 5000
FocusZone mount 1999 1979 5000
IconButton mount 1953 1928 5000
Label mount 392 358 5000
Layer mount 2168 2175 5000
Link mount 521 491 5000
MenuButton mount 1661 1658 5000
MessageBar mount 2128 2196 5000
Nav mount 3502 3489 1000
OverflowSet mount 1528 1520 5000
Panel mount 1503 1559 1000
Persona mount 878 896 1000
Pivot mount 1500 1550 1000
PrimaryButton mount 1401 1448 5000
Rating mount 8534 8471 5000
SearchBox mount 1387 1424 5000
Shimmer mount 2855 2807 5000
Slider mount 1622 1636 5000
SpinButton mount 5403 5541 5000
Spinner mount 448 457 5000
SplitButton mount 3426 3402 5000
Stack mount 557 546 5000
StackWithIntrinsicChildren mount 1730 1660 5000
StackWithTextChildren mount 5209 5171 5000
SwatchColorPicker mount 11076 11239 5000
TagPicker mount 2922 2977 5000
TeachingBubble mount 51680 51232 5000
Text mount 476 484 5000
TextField mount 1565 1576 5000
ThemeProvider mount 1768 1809 5000
ThemeProvider virtual-rerender 674 659 5000
Toggle mount 919 888 5000
button mount 122 121 5000

@size-auditor
Copy link

size-auditor bot commented Oct 20, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 35627bb3ecb15110c1c0b36b74bdb0735039d26c (build)

@khmakoto khmakoto mentioned this pull request Oct 21, 2020
Closed
40 tasks
@Raghurk Raghurk merged commit 14ddc43 into microsoft:7.0 Oct 21, 2020
@mbest mbest deleted the VerticalStackedBarChart-bar-styling branch October 21, 2020 18:11
@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-examples@v0.7.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/charting@v4.8.0 has been released which incorporates this pull request.:tada:

Handy links:

@khmakoto khmakoto mentioned this pull request Oct 26, 2020
Merged
2 tasks
ecraig12345 pushed a commit that referenced this pull request Oct 26, 2020
@khmakoto
Charting: Adding support for bar gaps and rounded corners in Vertical…
8fa8f36 
…StackedBarChart (#15704)

Cherry-pick of #15606.
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@khmakoto
Charting: Adding support for bar gaps and rounded corners in Vertical…
4025063 
…StackedBarChart (microsoft#15704)

Cherry-pick of microsoft#15606.
@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raghurk Raghurk Raghurk approved these changes

Assignees

@tomi-msft tomi-msft

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mbest @msft-github-bot @Raghurk @ecraig12345 @tomi-msft