Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename @uifabric/date-time to @fluentui/react-date-time #15659

Merged
merged 10 commits into from
Oct 23, 2020
Merged

Rename @uifabric/date-time to @fluentui/react-date-time #15659

merged 10 commits into from
Oct 23, 2020

Conversation

ecraig12345
Copy link
Member

@ecraig12345 ecraig12345 commented Oct 22, 2020 •
edited by xugao
Loading

Pull request checklist

Description of changes

Rename @uifabric/date-time to @fluentui/react-date-time and update references.

Remove direct references to re-exported packages from react-next.

xugao
xugao approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@xugao xugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers!

@xugao xugao changed the title Rename @uifabric/date-time to @fluentui/date-time-utilities Rename @uifabric/date-time to @fluentui/react-date-time Oct 22, 2020
@ecraig12345 ecraig12345 mentioned this pull request Oct 22, 2020
Closed
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 22, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d283e8f:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Oct 22, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 839 827 5000
BaseButtonCompat mount 911 939 5000
Breadcrumb mount 154661 151703 5000
Checkbox mount 1535 1527 5000
CheckboxBase mount 1297 1310 5000
ChoiceGroup mount 4853 4819 5000
ComboBox mount 988 967 1000
CommandBar mount 20931 20904 1000
ContextualMenu mount 5865 6172 1000
DefaultButtonCompat mount 1173 1120 5000
DetailsRow mount 3659 3604 5000
DetailsRowFast mount 3617 3596 5000
DetailsRowNoStyles mount 3446 3503 5000
Dialog mount 1555 1548 1000
DocumentCardTitle mount 1789 1789 1000
Dropdown mount 3610 3547 5000
FocusTrapZone mount 1814 1813 5000
FocusZone mount 1815 1828 5000
IconButtonCompat mount 1853 1835 5000
Label mount 342 355 5000
Layer mount 1812 1862 5000
Link mount 472 457 5000
MenuButtonCompat mount 1502 1508 5000
MessageBar mount 1960 2064 5000
Nav mount 3241 3306 1000
OverflowSet mount 1036 1028 5000
Panel mount 1422 1398 1000
Persona mount 851 871 1000
Pivot mount 1381 1394 1000
PrimaryButtonCompat mount 1273 1281 5000
Rating mount 7694 7776 5000
SearchBox mount 1364 1378 5000
Shimmer mount 2672 2618 5000
Slider mount 1938 1891 5000
SpinButton mount 5034 5034 5000
Spinner mount 400 416 5000
SplitButtonCompat mount 3179 3107 5000
Stack mount 511 522 5000
StackWithIntrinsicChildren mount 1556 1513 5000
StackWithTextChildren mount 4833 4791 5000
SwatchColorPicker mount 10170 10152 5000
TagPicker mount 2825 2725 5000
TeachingBubble mount 11392 11361 5000
Text mount 425 448 5000
TextField mount 1396 1418 5000
ThemeProvider mount 1912 1941 5000
ThemeProvider virtual-rerender 630 626 5000
Toggle mount 806 796 5000
button mount 562 567 5000
buttonNative mount 120 109 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.47 0.5 0.94:1 2000 932
🦄 Button.Fluent 0.12 0.24 0.5:1 5000 623
🔧 Checkbox.Fluent 0.63 0.35 1.8:1 1000 631
🎯 Dialog.Fluent 0.17 0.22 0.77:1 5000 841
🔧 Dropdown.Fluent 3.03 0.43 7.05:1 1000 3030
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 759
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 429
🔧 Slider.Fluent 1.56 0.45 3.47:1 1000 1560
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 405
🦄 Tooltip.Fluent 0.12 0.87 0.14:1 5000 575

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 192 163 1.18:1
ButtonMinimalPerf.default 201 188 1.07:1
ImageMinimalPerf.default 449 421 1.07:1
RefMinimalPerf.default 250 234 1.07:1
VideoMinimalPerf.default 703 659 1.07:1
GridMinimalPerf.default 395 372 1.06:1
RadioGroupMinimalPerf.default 505 477 1.06:1
ChatMinimalPerf.default 682 650 1.05:1
MenuButtonMinimalPerf.default 1765 1675 1.05:1
SkeletonMinimalPerf.default 474 452 1.05:1
IconMinimalPerf.default 748 715 1.05:1
TooltipMinimalPerf.default 861 817 1.05:1
Button.Fluent 623 593 1.05:1
DividerMinimalPerf.default 412 395 1.04:1
FlexMinimalPerf.default 325 314 1.04:1
FormMinimalPerf.default 471 455 1.04:1
PopupMinimalPerf.default 731 704 1.04:1
Dialog.Fluent 841 812 1.04:1
Text.Fluent 405 389 1.04:1
AnimationMinimalPerf.default 427 415 1.03:1
BoxMinimalPerf.default 415 404 1.03:1
ButtonUseCssPerf.default 866 839 1.03:1
CarouselMinimalPerf.default 490 476 1.03:1
DialogMinimalPerf.default 839 811 1.03:1
ItemLayoutMinimalPerf.default 1460 1419 1.03:1
ReactionMinimalPerf.default 447 432 1.03:1
SplitButtonMinimalPerf.default 3901 3783 1.03:1
TextMinimalPerf.default 395 383 1.03:1
Checkbox.Fluent 631 615 1.03:1
EmbedMinimalPerf.default 2045 2013 1.02:1
LabelMinimalPerf.default 489 481 1.02:1
MenuMinimalPerf.default 985 965 1.02:1
ProviderMergeThemesPerf.default 2005 1965 1.02:1
SliderMinimalPerf.default 1569 1537 1.02:1
CustomToolbarPrototype.default 3840 3777 1.02:1
Slider.Fluent 1560 1524 1.02:1
AlertMinimalPerf.default 341 337 1.01:1
AttachmentSlotsPerf.default 1191 1179 1.01:1
AvatarMinimalPerf.default 501 494 1.01:1
CardMinimalPerf.default 618 612 1.01:1
ChatWithPopoverPerf.default 502 497 1.01:1
DropdownMinimalPerf.default 2889 2863 1.01:1
HeaderSlotsPerf.default 847 836 1.01:1
LayoutMinimalPerf.default 462 456 1.01:1
ListMinimalPerf.default 576 571 1.01:1
SegmentMinimalPerf.default 395 393 1.01:1
StatusMinimalPerf.default 791 785 1.01:1
TableManyItemsPerf.default 2359 2332 1.01:1
TableMinimalPerf.default 461 456 1.01:1
Tooltip.Fluent 575 570 1.01:1
AccordionMinimalPerf.default 173 173 1:1
ButtonSlotsPerf.default 615 617 1:1
ButtonUseCssNestingPerf.default 1095 1094 1:1
ChatDuplicateMessagesPerf.default 446 445 1:1
CheckboxMinimalPerf.default 2887 2882 1:1
ProviderMinimalPerf.default 982 981 1:1
ToolbarMinimalPerf.default 1000 997 1:1
Avatar.Fluent 932 931 1:1
HeaderMinimalPerf.default 394 398 0.99:1
ListNestedPerf.default 634 642 0.99:1
ListWith60ListItems.default 1024 1035 0.99:1
LoaderMinimalPerf.default 792 804 0.99:1
Icon.Fluent 759 768 0.99:1
ButtonOverridesMissPerf.default 1693 1724 0.98:1
DropdownManyItemsPerf.default 765 780 0.98:1
ListCommonPerf.default 731 748 0.98:1
TreeMinimalPerf.default 941 958 0.98:1
Dropdown.Fluent 3030 3086 0.98:1
Image.Fluent 429 437 0.98:1
PortalMinimalPerf.default 176 182 0.97:1
TextAreaMinimalPerf.default 550 568 0.97:1
TreeWith60ListItems.default 207 213 0.97:1
InputMinimalPerf.default 1314 1369 0.96:1

dzearing
dzearing approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@dzearing dzearing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot!

@size-auditor
Copy link

size-auditor bot commented Oct 23, 2020 •
edited
Loading

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: bcffe05

Possible causes

  • The baseline build bcffe05 is broken
  • The Size Auditor run for the baseline build bcffe05 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@ecraig12345 ecraig12345 merged commit 499bddf into microsoft:master Oct 23, 2020
@ecraig12345 ecraig12345 deleted the rename-date-time branch October 23, 2020 01:23
@msft-github-bot
Copy link
Contributor

🎉@fluentui/react@v8.0.0-beta.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-next@v9.0.0-alpha.0 has been released which incorporates this pull request.:tada:

Handy links:

SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@ecraig12345
Rename @uifabric/date-time to @fluentui/react-date-time (microsoft#15659
72839b7 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschect joschect joschect approved these changes

@xugao xugao xugao approved these changes

@dzearing dzearing dzearing approved these changes

@evlevy evlevy Awaiting requested review from evlevy

@Jahnp Jahnp Awaiting requested review from Jahnp

@lorejoh12 lorejoh12 Awaiting requested review from lorejoh12

@pompomon pompomon Awaiting requested review from pompomon

Assignees

@tomi-msft tomi-msft

Labels
Area: Build System Area: Packaging Package: date-time PR: API Modified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move @uifabric packages under @fluentui scope
6 participants
@ecraig12345 @msft-github-bot @dzearing @xugao @joschect @tomi-msft