Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charting: Adding tests for VerticalStackedBarChart #15709

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Charting: Adding tests for VerticalStackedBarChart #15709

merged 2 commits into from
Oct 27, 2020

Conversation

khmakoto
Copy link
Member

Pull request checklist

Description of changes

Cherry-pick of #15522.

Original PR description:

Implemented basic unit test cases and snapshot test cases to the vertical stacked bar chart.

Focus areas to test

Vertical stacked bar chart

@khmakoto khmakoto mentioned this pull request Oct 27, 2020
Closed
40 tasks
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 41301b4:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 859 887 5000
BaseButtonCompat mount 1048 984 5000
Breadcrumb mount 45362 44957 5000
Checkbox mount 1722 1676 5000
CheckboxBase mount 1404 1429 5000
ChoiceGroup mount 5252 5254 5000
ComboBox mount 1057 1044 1000
CommandBar mount 10783 10945 1000
ContextualMenu mount 6547 6652 1000
DefaultButtonCompat mount 1260 1275 5000
DetailsRow mount 4003 3975 5000
DetailsRowFast mount 3960 4127 5000
DetailsRowNoStyles mount 3788 3831 5000
Dialog mount 1587 1646 1000
DocumentCardTitle mount 1930 1980 1000
Dropdown mount 3758 3747 5000
FocusTrapZone mount 1939 1962 5000
FocusZone mount 1885 1928 5000
IconButtonCompat mount 1937 1926 5000
Label mount 379 378 5000
Layer mount 2007 2058 5000
Link mount 497 503 5000
MenuButtonCompat mount 1680 1684 5000
MessageBar mount 2308 2200 5000
Nav mount 3566 3549 1000
OverflowSet mount 1107 1094 5000
Panel mount 1566 1527 1000
Persona mount 960 927 1000
Pivot mount 1536 1602 1000
PrimaryButtonCompat mount 1425 1428 5000
Rating mount 8294 8347 5000
SearchBox mount 1447 1495 5000
Shimmer mount 2735 2858 5000
Slider mount 2121 2089 5000
SpinButton mount 5443 5362 5000
Spinner mount 432 465 5000
SplitButtonCompat mount 3465 3498 5000
Stack mount 559 545 5000
StackWithIntrinsicChildren mount 1721 1669 5000
StackWithTextChildren mount 5302 5321 5000
SwatchColorPicker mount 11237 11215 5000
TagPicker mount 3014 3085 5000
TeachingBubble mount 12390 12443 5000
Text mount 478 472 5000
TextField mount 1506 1574 5000
ThemeProvider mount 2077 2114 5000
ThemeProvider virtual-rerender 682 722 5000
Toggle mount 881 847 5000
button mount 595 605 5000
buttonNative mount 105 126 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.5 0.55 0.91:1 2000 993
🦄 Button.Fluent 0.13 0.25 0.52:1 5000 629
🔧 Checkbox.Fluent 0.64 0.37 1.73:1 1000 643
🎯 Dialog.Fluent 0.18 0.25 0.72:1 5000 912
🔧 Dropdown.Fluent 3.04 0.47 6.47:1 1000 3042
🔧 Icon.Fluent 0.17 0.07 2.43:1 5000 863
🦄 Image.Fluent 0.09 0.14 0.64:1 5000 445
🔧 Slider.Fluent 1.75 0.46 3.8:1 1000 1745
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 422
🦄 Tooltip.Fluent 0.13 0.94 0.14:1 5000 635

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
Icon.Fluent 863 769 1.12:1
ButtonMinimalPerf.default 205 187 1.1:1
ListNestedPerf.default 669 616 1.09:1
PortalMinimalPerf.default 186 170 1.09:1
SegmentMinimalPerf.default 469 429 1.09:1
IconMinimalPerf.default 784 718 1.09:1
HeaderMinimalPerf.default 467 433 1.08:1
CardMinimalPerf.default 692 647 1.07:1
ReactionMinimalPerf.default 500 466 1.07:1
TreeWith60ListItems.default 245 229 1.07:1
BoxMinimalPerf.default 433 408 1.06:1
ButtonSlotsPerf.default 682 646 1.06:1
CarouselMinimalPerf.default 511 482 1.06:1
LabelMinimalPerf.default 502 474 1.06:1
AccordionMinimalPerf.default 197 187 1.05:1
ChatDuplicateMessagesPerf.default 469 447 1.05:1
DividerMinimalPerf.default 460 440 1.05:1
FlexMinimalPerf.default 362 345 1.05:1
ImageMinimalPerf.default 451 431 1.05:1
SliderMinimalPerf.default 1768 1688 1.05:1
TableMinimalPerf.default 483 462 1.05:1
Tooltip.Fluent 635 606 1.05:1
PopupMinimalPerf.default 797 766 1.04:1
SkeletonMinimalPerf.default 526 506 1.04:1
TextMinimalPerf.default 420 403 1.04:1
Text.Fluent 422 405 1.04:1
AnimationMinimalPerf.default 465 453 1.03:1
AttachmentMinimalPerf.default 197 191 1.03:1
DialogMinimalPerf.default 891 862 1.03:1
HeaderSlotsPerf.default 946 916 1.03:1
InputMinimalPerf.default 1468 1426 1.03:1
LayoutMinimalPerf.default 474 460 1.03:1
ListCommonPerf.default 758 738 1.03:1
AttachmentSlotsPerf.default 1277 1257 1.02:1
DropdownManyItemsPerf.default 864 848 1.02:1
LoaderMinimalPerf.default 822 804 1.02:1
MenuMinimalPerf.default 1008 989 1.02:1
SplitButtonMinimalPerf.default 4256 4171 1.02:1
ToolbarMinimalPerf.default 1073 1057 1.02:1
Image.Fluent 445 437 1.02:1
AvatarMinimalPerf.default 550 546 1.01:1
MenuButtonMinimalPerf.default 1781 1759 1.01:1
ProviderMinimalPerf.default 1134 1121 1.01:1
TableManyItemsPerf.default 2515 2482 1.01:1
Slider.Fluent 1745 1728 1.01:1
ChatWithPopoverPerf.default 535 535 1:1
CheckboxMinimalPerf.default 3058 3048 1:1
DropdownMinimalPerf.default 3172 3179 1:1
ListWith60ListItems.default 1035 1036 1:1
ProviderMergeThemesPerf.default 2175 2170 1:1
TextAreaMinimalPerf.default 588 586 1:1
TooltipMinimalPerf.default 907 903 1:1
VideoMinimalPerf.default 722 725 1:1
Avatar.Fluent 993 991 1:1
AlertMinimalPerf.default 351 356 0.99:1
ButtonUseCssPerf.default 906 911 0.99:1
EmbedMinimalPerf.default 2126 2142 0.99:1
StatusMinimalPerf.default 820 829 0.99:1
TreeMinimalPerf.default 998 1009 0.99:1
Dropdown.Fluent 3042 3076 0.99:1
ButtonOverridesMissPerf.default 1823 1865 0.98:1
GridMinimalPerf.default 409 416 0.98:1
CustomToolbarPrototype.default 4159 4265 0.98:1
Dialog.Fluent 912 931 0.98:1
ButtonUseCssNestingPerf.default 1179 1210 0.97:1
FormMinimalPerf.default 505 520 0.97:1
ListMinimalPerf.default 553 568 0.97:1
RefMinimalPerf.default 266 273 0.97:1
Button.Fluent 629 651 0.97:1
ChatMinimalPerf.default 695 721 0.96:1
ItemLayoutMinimalPerf.default 1453 1523 0.95:1
Checkbox.Fluent 643 678 0.95:1
RadioGroupMinimalPerf.default 508 541 0.94:1

@ecraig12345 ecraig12345 merged commit 79c9a4c into microsoft:master Oct 27, 2020
@size-auditor
Copy link

size-auditor bot commented Oct 27, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f67490d9a7c81323c4358c3f5a40b36b758b7439 (build)

@khmakoto khmakoto deleted the verticalStackedBarChartTests branch October 27, 2020 04:04
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@khmakoto
Charting: Adding tests for VerticalStackedBarChart (microsoft#15709)
48cd06f 
Cherry-pick of microsoft#15522.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@Raghurk Raghurk Awaiting requested review from Raghurk

Assignees

@tomi-msft tomi-msft

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khmakoto @msft-github-bot @ecraig12345 @tomi-msft