Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charting: Adding tests for HeatMapChart and PieChart #15711

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Charting: Adding tests for HeatMapChart and PieChart #15711

merged 2 commits into from
Oct 27, 2020

Conversation

khmakoto
Copy link
Member

Pull request checklist

Description of changes

Cherry-pick of #15640.

Original PR description:

Basic unit test cases and snapshot test cases for Heat map chart and Pie chart.

Focus areas to test

Heat map chart
Pie chart

@khmakoto khmakoto mentioned this pull request Oct 27, 2020
Closed
40 tasks
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2344276:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 815 830 5000
BaseButtonCompat mount 886 886 5000
Breadcrumb mount 43947 43899 5000
Checkbox mount 1500 1515 5000
CheckboxBase mount 1241 1224 5000
ChoiceGroup mount 4668 4643 5000
ComboBox mount 973 992 1000
CommandBar mount 10158 10231 1000
ContextualMenu mount 6243 6173 1000
DefaultButtonCompat mount 1124 1105 5000
DetailsRow mount 3565 3552 5000
DetailsRowFast mount 3580 3590 5000
DetailsRowNoStyles mount 3461 3428 5000
Dialog mount 1502 1530 1000
DocumentCardTitle mount 1818 1791 1000
Dropdown mount 3402 3355 5000
FocusTrapZone mount 1803 1780 5000
FocusZone mount 1802 1842 5000
IconButtonCompat mount 1724 1735 5000
Label mount 331 335 5000
Layer mount 1781 1782 5000
Link mount 455 466 5000
MenuButtonCompat mount 1450 1472 5000
MessageBar mount 2029 2031 5000
Nav mount 3190 3205 1000
OverflowSet mount 1062 1040 5000
Panel mount 1445 1419 1000
Persona mount 855 850 1000
Pivot mount 1390 1402 1000
PrimaryButtonCompat mount 1285 1278 5000
Rating mount 7365 7291 5000
SearchBox mount 1284 1313 5000
Shimmer mount 2467 2489 5000
Slider mount 1854 1929 5000
SpinButton mount 4998 4958 5000
Spinner mount 427 424 5000
SplitButtonCompat mount 3144 3143 5000
Stack mount 500 510 5000
StackWithIntrinsicChildren mount 1511 1521 5000
StackWithTextChildren mount 4636 4624 5000
SwatchColorPicker mount 10042 10149 5000
TagPicker mount 2741 2745 5000
TeachingBubble mount 11492 11501 5000
Text mount 424 440 5000
TextField mount 1371 1351 5000
ThemeProvider mount 1967 1988 5000
ThemeProvider virtual-rerender 648 642 5000
Toggle mount 785 783 5000
button mount 568 557 5000
buttonNative mount 118 102 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.45 0.51 0.88:1 2000 897
🦄 Button.Fluent 0.12 0.21 0.57:1 5000 581
🔧 Checkbox.Fluent 0.64 0.34 1.88:1 1000 643
🎯 Dialog.Fluent 0.16 0.22 0.73:1 5000 802
🔧 Dropdown.Fluent 2.98 0.41 7.27:1 1000 2980
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 718
🦄 Image.Fluent 0.08 0.13 0.62:1 5000 414
🔧 Slider.Fluent 1.63 0.44 3.7:1 1000 1631
🔧 Text.Fluent 0.07 0.04 1.75:1 5000 367
🦄 Tooltip.Fluent 0.12 0.9 0.13:1 5000 584

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 171 152 1.13:1
FlexMinimalPerf.default 326 303 1.08:1
AvatarMinimalPerf.default 494 462 1.07:1
ListMinimalPerf.default 516 483 1.07:1
Image.Fluent 414 386 1.07:1
LabelMinimalPerf.default 449 429 1.05:1
ChatDuplicateMessagesPerf.default 439 421 1.04:1
GridMinimalPerf.default 372 359 1.04:1
ListNestedPerf.default 589 566 1.04:1
SegmentMinimalPerf.default 381 365 1.04:1
StatusMinimalPerf.default 764 735 1.04:1
IconMinimalPerf.default 686 658 1.04:1
TableMinimalPerf.default 437 421 1.04:1
TextAreaMinimalPerf.default 511 492 1.04:1
TreeWith60ListItems.default 218 210 1.04:1
BoxMinimalPerf.default 384 372 1.03:1
InputMinimalPerf.default 1353 1316 1.03:1
ReactionMinimalPerf.default 420 407 1.03:1
AttachmentMinimalPerf.default 174 171 1.02:1
ButtonUseCssPerf.default 850 835 1.02:1
CardMinimalPerf.default 580 568 1.02:1
HeaderSlotsPerf.default 804 786 1.02:1
RadioGroupMinimalPerf.default 457 450 1.02:1
ToolbarMinimalPerf.default 979 957 1.02:1
TooltipMinimalPerf.default 838 819 1.02:1
AnimationMinimalPerf.default 424 418 1.01:1
ChatWithPopoverPerf.default 492 486 1.01:1
CheckboxMinimalPerf.default 2887 2869 1.01:1
DialogMinimalPerf.default 807 797 1.01:1
DividerMinimalPerf.default 387 382 1.01:1
EmbedMinimalPerf.default 1934 1924 1.01:1
FormMinimalPerf.default 422 419 1.01:1
ListWith60ListItems.default 935 928 1.01:1
LoaderMinimalPerf.default 731 726 1.01:1
MenuButtonMinimalPerf.default 1601 1578 1.01:1
PopupMinimalPerf.default 710 701 1.01:1
ProviderMergeThemesPerf.default 2130 2118 1.01:1
RefMinimalPerf.default 247 244 1.01:1
SkeletonMinimalPerf.default 434 429 1.01:1
SliderMinimalPerf.default 1599 1576 1.01:1
SplitButtonMinimalPerf.default 3834 3793 1.01:1
Avatar.Fluent 897 892 1.01:1
Button.Fluent 581 573 1.01:1
Checkbox.Fluent 643 634 1.01:1
Slider.Fluent 1631 1615 1.01:1
Text.Fluent 367 365 1.01:1
Tooltip.Fluent 584 581 1.01:1
AttachmentSlotsPerf.default 1146 1141 1:1
ButtonUseCssNestingPerf.default 1107 1105 1:1
CarouselMinimalPerf.default 460 462 1:1
DropdownMinimalPerf.default 2986 2979 1:1
HeaderMinimalPerf.default 377 376 1:1
ImageMinimalPerf.default 404 403 1:1
ItemLayoutMinimalPerf.default 1289 1285 1:1
TextMinimalPerf.default 369 369 1:1
CustomToolbarPrototype.default 3993 3983 1:1
VideoMinimalPerf.default 656 656 1:1
Dialog.Fluent 802 802 1:1
Icon.Fluent 718 717 1:1
ButtonOverridesMissPerf.default 1699 1722 0.99:1
ChatMinimalPerf.default 617 624 0.99:1
PortalMinimalPerf.default 168 169 0.99:1
ProviderMinimalPerf.default 1037 1044 0.99:1
TableManyItemsPerf.default 2173 2202 0.99:1
TreeMinimalPerf.default 897 902 0.99:1
Dropdown.Fluent 2980 2995 0.99:1
LayoutMinimalPerf.default 416 425 0.98:1
ListCommonPerf.default 664 676 0.98:1
MenuMinimalPerf.default 870 886 0.98:1
AlertMinimalPerf.default 307 316 0.97:1
ButtonMinimalPerf.default 181 186 0.97:1
ButtonSlotsPerf.default 591 614 0.96:1
DropdownManyItemsPerf.default 741 771 0.96:1

@ecraig12345 ecraig12345 merged commit 5501927 into microsoft:master Oct 27, 2020
@size-auditor
Copy link

size-auditor bot commented Oct 27, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f67490d9a7c81323c4358c3f5a40b36b758b7439 (build)

@khmakoto khmakoto deleted the pieHeatMapChartsTests branch October 27, 2020 04:04
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@khmakoto
Charting: Adding tests for HeatMapChart and PieChart (microsoft#15711)
684c303 
Cherry-pick of microsoft#15640.
@kubkon kubkon mentioned this pull request Jan 27, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@Raghurk Raghurk Awaiting requested review from Raghurk

Assignees

@tomi-msft tomi-msft

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khmakoto @msft-github-bot @ecraig12345 @tomi-msft