Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charting: Donut chart test cases #15833

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Charting: Donut chart test cases #15833

merged 3 commits into from
Nov 11, 2020

Conversation

jameelakowsar
Copy link
Contributor

Pull request checklist

Description of changes

cherry-pick of #15761

Original description

Added basic unit test cases and snapshot test cases to the Donut chart. Little bit of code cleanup.

Focus areas to test

Donut chart

@jameelakowsar jameelakowsar changed the title User/v jasha/cherry pick donut chart test cases Charting: Donut chart test cases Nov 4, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 087e287:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Nov 4, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 838 873 5000
BaseButtonCompat mount 935 930 5000
Breadcrumb mount 43329 43821 5000
Checkbox mount 1646 1556 5000
CheckboxBase mount 1403 1367 5000
ChoiceGroup mount 5000 5159 5000
ComboBox mount 959 1013 1000
CommandBar mount 10052 10306 1000
ContextualMenu mount 6027 6024 1000
DefaultButtonCompat mount 1161 1159 5000
DetailsRow mount 3637 3629 5000
DetailsRowFast mount 3734 3735 5000
DetailsRowNoStyles mount 3570 3575 5000
Dialog mount 1537 1513 1000
DocumentCardTitle mount 1766 1824 1000
Dropdown mount 3490 3483 5000
FocusTrapZone mount 1835 1801 5000
FocusZone mount 1793 1806 5000
IconButtonCompat mount 1856 1840 5000
Label mount 316 330 5000
Layer mount 1830 1835 5000
Link mount 472 479 5000
MenuButtonCompat mount 1524 1567 5000
MessageBar mount 1997 2001 5000
Nav mount 3331 3384 1000
OverflowSet mount 1060 1024 5000
Panel mount 1463 1427 1000
Persona mount 882 874 1000
Pivot mount 1418 1426 1000
PrimaryButtonCompat mount 1368 1332 5000
Rating mount 7790 7721 5000
SearchBox mount 1415 1350 5000
Shimmer mount 2667 2635 5000
Slider mount 1936 1919 5000
SpinButton mount 5094 5068 5000
Spinner mount 425 423 5000
SplitButtonCompat mount 3326 3294 5000
Stack mount 511 537 5000
StackWithIntrinsicChildren mount 1627 1578 5000
StackWithTextChildren mount 5133 5142 5000
SwatchColorPicker mount 10969 10814 5000
Tabs mount 1512 1499 1000
TagPicker mount 2970 2954 5000
TeachingBubble mount 11780 11949 5000
Text mount 457 461 5000
TextField mount 1426 1387 5000
ThemeProvider mount 2017 1959 5000
ThemeProvider virtual-rerender 641 626 5000
Toggle mount 824 790 5000
button mount 575 569 5000
buttonNative mount 109 110 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.48 0.51 0.94:1 2000 952
🦄 Button.Fluent 0.13 0.26 0.5:1 5000 645
🔧 Checkbox.Fluent 0.67 0.35 1.91:1 1000 671
🎯 Dialog.Fluent 0.17 0.23 0.74:1 5000 855
🔧 Dropdown.Fluent 2.97 0.42 7.07:1 1000 2968
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 773
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 433
🔧 Slider.Fluent 1.61 0.44 3.66:1 1000 1611
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 403
🦄 Tooltip.Fluent 0.11 0.88 0.13:1 5000 574

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 223 191 1.17:1
ImageMinimalPerf.default 445 412 1.08:1
CarouselMinimalPerf.default 516 484 1.07:1
RefMinimalPerf.default 251 237 1.06:1
ListNestedPerf.default 645 616 1.05:1
AttachmentSlotsPerf.default 1283 1234 1.04:1
BoxMinimalPerf.default 441 426 1.04:1
ChatMinimalPerf.default 702 673 1.04:1
HeaderMinimalPerf.default 431 413 1.04:1
PopupMinimalPerf.default 737 712 1.04:1
PortalMinimalPerf.default 167 160 1.04:1
SegmentMinimalPerf.default 415 399 1.04:1
TableMinimalPerf.default 474 455 1.04:1
TooltipMinimalPerf.default 882 846 1.04:1
Dialog.Fluent 855 820 1.04:1
Image.Fluent 433 418 1.04:1
ButtonSlotsPerf.default 646 628 1.03:1
ButtonUseCssPerf.default 906 881 1.03:1
CardMinimalPerf.default 653 634 1.03:1
ChatWithPopoverPerf.default 512 496 1.03:1
EmbedMinimalPerf.default 2087 2036 1.03:1
FlexMinimalPerf.default 333 323 1.03:1
ListMinimalPerf.default 549 531 1.03:1
ListWith60ListItems.default 1007 976 1.03:1
LoaderMinimalPerf.default 786 761 1.03:1
RadioGroupMinimalPerf.default 493 478 1.03:1
SplitButtonMinimalPerf.default 4020 3919 1.03:1
TextAreaMinimalPerf.default 562 544 1.03:1
TreeMinimalPerf.default 973 944 1.03:1
Button.Fluent 645 625 1.03:1
Text.Fluent 403 390 1.03:1
AccordionMinimalPerf.default 176 172 1.02:1
DialogMinimalPerf.default 862 849 1.02:1
DropdownManyItemsPerf.default 826 808 1.02:1
FormMinimalPerf.default 482 474 1.02:1
HeaderSlotsPerf.default 874 859 1.02:1
InputMinimalPerf.default 1353 1332 1.02:1
LayoutMinimalPerf.default 451 441 1.02:1
CustomToolbarPrototype.default 3911 3836 1.02:1
Avatar.Fluent 952 935 1.02:1
Checkbox.Fluent 671 657 1.02:1
Tooltip.Fluent 574 561 1.02:1
ButtonOverridesMissPerf.default 1826 1808 1.01:1
ChatDuplicateMessagesPerf.default 457 451 1.01:1
ItemLayoutMinimalPerf.default 1403 1390 1.01:1
ReactionMinimalPerf.default 460 456 1.01:1
IconMinimalPerf.default 749 739 1.01:1
TableManyItemsPerf.default 2418 2385 1.01:1
Icon.Fluent 773 763 1.01:1
Slider.Fluent 1611 1598 1.01:1
CheckboxMinimalPerf.default 3036 3027 1:1
DropdownMinimalPerf.default 2979 2979 1:1
LabelMinimalPerf.default 458 459 1:1
MenuButtonMinimalPerf.default 1695 1700 1:1
ProviderMergeThemesPerf.default 2021 2018 1:1
SkeletonMinimalPerf.default 464 463 1:1
Dropdown.Fluent 2968 2954 1:1
AlertMinimalPerf.default 330 335 0.99:1
ButtonUseCssNestingPerf.default 1158 1165 0.99:1
GridMinimalPerf.default 396 402 0.99:1
ListCommonPerf.default 707 713 0.99:1
ProviderMinimalPerf.default 1001 1015 0.99:1
SliderMinimalPerf.default 1583 1596 0.99:1
StatusMinimalPerf.default 789 793 0.99:1
TextMinimalPerf.default 406 412 0.99:1
AnimationMinimalPerf.default 437 446 0.98:1
AttachmentMinimalPerf.default 185 189 0.98:1
AvatarMinimalPerf.default 535 548 0.98:1
DividerMinimalPerf.default 424 433 0.98:1
MenuMinimalPerf.default 941 956 0.98:1
ToolbarMinimalPerf.default 1005 1023 0.98:1
TreeWith60ListItems.default 211 221 0.95:1
VideoMinimalPerf.default 653 695 0.94:1

@size-auditor
Copy link

size-auditor bot commented Nov 4, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 08d28c85ddc861eb731df5ad30e7073128187a2d (build)

@jameelakowsar jameelakowsar reopened this Nov 5, 2020
@jameelakowsar jameelakowsar marked this pull request as ready for review November 5, 2020 12:17
@Raghurk Raghurk merged commit 950b07c into microsoft:master Nov 11, 2020
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 23, 2020
@jameelakowsar
Charting: Donut chart test cases (microsoft#15833)
b625744 
* Donut chart test cases cherry pick to master

* Change files

* email updated in change file

Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <v-jasha@microsoft.com>
@kubkon kubkon mentioned this pull request Jan 27, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raghurk Raghurk Raghurk approved these changes

Assignees

@behowell behowell

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jameelakowsar @msft-github-bot @Raghurk @behowell