charting: Grouped vertical bar chart code refactor. #15838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5225e7f:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 08d28c85ddc861eb731df5ad30e7073128187a2d (build) |
Raghurk
reviewed
Nov 9, 2020
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "type": "none", | |||
There was a problem hiding this comment.
should this be patch, minor or major?
There was a problem hiding this comment.
Hi raghu,
All other PR's (which were cherry-picked and ported to master) are with type:none only. And while adding change file they are only 2 options(Prerelease and None). So I have added None.
Raghurk
approved these changes
Nov 11, 2020
SethDonohue
pushed a commit
to SethDonohue/fluentui
that referenced
this pull request
Nov 23, 2020
* Grouped vertical bar chart code refactor cherry pick to port master * Change files * email updated in change files Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <v-jasha@microsoft.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Cherry-pick of ##15468
Original description
In the process of restructure of the Groped vertical bar chart,
Removed d3 related graph structure and updated with rectangles.
Implemented with Cartesian chart(Common component)
YMinValue and YMaxValue support added
Added support of yAxisTickFormat.
Customized callout support implemented.
Code cleanup
Snapshot and basic level unit test cases added
Deprecated below props(Made them as default props).
Note: As RTL support and word wrap of x axis already implemented for this chart, Now it's working as like previous. Attacked screenshots.
Focus areas to test
Grouped vertical bar chart
Grouped vertical bar chart with custom callout
yMax value support - with 100000 as Max value
RTL Support
Test link: http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/15468/merge/charting/dist/index.html#/examples/GroupedVerticalBarChart