Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace Stardust UI mentions, clean up docs #16369

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jan 5, 2021

@DustyTheBot
Copy link

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against 17fa481

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 17fa481:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 925 902 5000
BaseButtonCompat mount 1029 1013 5000
Breadcrumb mount 43746 44594 5000
Checkbox mount 1570 1554 5000
CheckboxBase mount 1365 1339 5000
ChoiceGroup mount 4973 4953 5000
ComboBox mount 943 990 1000
CommandBar mount 10878 11338 1000
ContextualMenu mount 6963 6544 1000
DefaultButtonCompat mount 1246 1278 5000
DetailsRow mount 4062 4023 5000
DetailsRowFast mount 4095 4074 5000
DetailsRowNoStyles mount 3720 3620 5000
Dialog mount 1719 1495 1000
DocumentCardTitle mount 2219 2010 1000
Dropdown mount 3801 3741 5000
FocusTrapZone mount 1994 2031 5000
FocusZone mount 1916 2019 5000
IconButtonCompat mount 1966 1904 5000
Label mount 379 355 5000
Layer mount 1957 1957 5000
Link mount 506 521 5000
MakeStyles mount 2125 2120 50000
MenuButtonCompat mount 1649 1607 5000
MessageBar mount 2223 2206 5000
Nav mount 3642 3668 1000
OverflowSet mount 1145 1092 5000
Panel mount 1629 1600 1000
Persona mount 932 970 1000
Pivot mount 1558 1546 1000
PrimaryButtonCompat mount 1431 1454 5000
Rating mount 8755 8591 5000
SearchBox mount 1496 1521 5000
Shimmer mount 2748 2857 5000
Slider mount 2037 2009 5000
SpinButton mount 5614 5285 5000
Spinner mount 470 433 5000
SplitButtonCompat mount 3411 3396 5000
Stack mount 542 556 5000
StackWithIntrinsicChildren mount 1622 1622 5000
StackWithTextChildren mount 4936 4940 5000
SwatchColorPicker mount 10508 10894 5000
Tabs mount 1531 1459 1000
TagPicker mount 3270 3222 5000
TeachingBubble mount 12417 12749 5000
Text mount 470 467 5000
TextField mount 1633 1568 5000
ThemeProvider mount 2153 2251 5000
ThemeProvider virtual-rerender 652 640 5000
Toggle mount 847 826 5000
button mount 699 736 5000
buttonNative mount 122 120 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.51 0.55 0.93:1 2000 1024
🦄 Button.Fluent 0.12 0.22 0.55:1 5000 616
🔧 Checkbox.Fluent 0.68 0.36 1.89:1 1000 680
🎯 Dialog.Fluent 0.17 0.23 0.74:1 5000 857
🔧 Dropdown.Fluent 3 0.41 7.32:1 1000 3000
🔧 Icon.Fluent 0.16 0.07 2.29:1 5000 784
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 438
🔧 Slider.Fluent 1.78 0.46 3.87:1 1000 1777
🔧 Text.Fluent 0.09 0.04 2.25:1 5000 474
🦄 Tooltip.Fluent 0.13 1.01 0.13:1 5000 669

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
Text.Fluent 474 423 1.12:1
AlertMinimalPerf.default 396 361 1.1:1
ButtonMinimalPerf.default 210 192 1.09:1
ListMinimalPerf.default 606 562 1.08:1
ChatDuplicateMessagesPerf.default 542 507 1.07:1
DialogMinimalPerf.default 965 901 1.07:1
GridMinimalPerf.default 430 403 1.07:1
ListNestedPerf.default 683 644 1.06:1
AnimationMinimalPerf.default 496 473 1.05:1
PortalMinimalPerf.default 189 180 1.05:1
Checkbox.Fluent 680 649 1.05:1
Dialog.Fluent 857 818 1.05:1
CarouselMinimalPerf.default 544 521 1.04:1
ChatWithPopoverPerf.default 571 551 1.04:1
RadioGroupMinimalPerf.default 533 513 1.04:1
SkeletonMinimalPerf.default 443 427 1.04:1
TableManyItemsPerf.default 2514 2419 1.04:1
AttachmentSlotsPerf.default 1358 1321 1.03:1
AvatarMinimalPerf.default 546 528 1.03:1
CardMinimalPerf.default 705 687 1.03:1
ChatMinimalPerf.default 763 744 1.03:1
FlexMinimalPerf.default 371 359 1.03:1
ListWith60ListItems.default 1046 1014 1.03:1
TreeMinimalPerf.default 931 901 1.03:1
Image.Fluent 438 427 1.03:1
InputMinimalPerf.default 1438 1407 1.02:1
ListCommonPerf.default 765 749 1.02:1
MenuButtonMinimalPerf.default 1801 1769 1.02:1
RefMinimalPerf.default 267 261 1.02:1
TextAreaMinimalPerf.default 574 561 1.02:1
Icon.Fluent 784 766 1.02:1
Tooltip.Fluent 669 655 1.02:1
AttachmentMinimalPerf.default 205 202 1.01:1
ButtonOverridesMissPerf.default 1818 1795 1.01:1
ButtonSlotsPerf.default 690 680 1.01:1
CheckboxMinimalPerf.default 3211 3185 1.01:1
HeaderMinimalPerf.default 421 415 1.01:1
ProviderMinimalPerf.default 1134 1125 1.01:1
SliderMinimalPerf.default 1664 1644 1.01:1
StatusMinimalPerf.default 853 843 1.01:1
TableMinimalPerf.default 499 492 1.01:1
TextMinimalPerf.default 421 416 1.01:1
Avatar.Fluent 1024 1017 1.01:1
Button.Fluent 616 610 1.01:1
BoxMinimalPerf.default 415 415 1:1
ButtonUseCssNestingPerf.default 1279 1278 1:1
EmbedMinimalPerf.default 4640 4626 1:1
FormMinimalPerf.default 503 503 1:1
HeaderSlotsPerf.default 919 920 1:1
PopupMinimalPerf.default 798 797 1:1
ReactionMinimalPerf.default 472 470 1:1
SegmentMinimalPerf.default 437 439 1:1
SplitButtonMinimalPerf.default 4144 4134 1:1
CustomToolbarPrototype.default 4176 4175 1:1
ToolbarMinimalPerf.default 1111 1108 1:1
TooltipMinimalPerf.default 916 918 1:1
Dropdown.Fluent 3000 3014 1:1
DividerMinimalPerf.default 472 478 0.99:1
DropdownManyItemsPerf.default 904 912 0.99:1
ItemLayoutMinimalPerf.default 1508 1525 0.99:1
LabelMinimalPerf.default 496 500 0.99:1
LoaderMinimalPerf.default 816 823 0.99:1
MenuMinimalPerf.default 990 996 0.99:1
VideoMinimalPerf.default 719 729 0.99:1
Slider.Fluent 1777 1787 0.99:1
ProviderMergeThemesPerf.default 2222 2275 0.98:1
IconMinimalPerf.default 754 767 0.98:1
ImageMinimalPerf.default 464 477 0.97:1
LayoutMinimalPerf.default 481 495 0.97:1
TreeWith60ListItems.default 230 236 0.97:1
AccordionMinimalPerf.default 189 196 0.96:1
ButtonUseCssPerf.default 974 1014 0.96:1
DropdownMinimalPerf.default 3407 3629 0.94:1
DatepickerMinimalPerf.default 49909 58383 0.85:1

@size-auditor
Copy link

size-auditor bot commented Jan 5, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 70b0efdeefd11fcc920d84b98a7f0bda6094698f (build)

@layershifter layershifter merged commit 6ecc063 into master Jan 5, 2021
@layershifter layershifter deleted the docs/update-image branch January 5, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An image belongs to Stardust UI is still existing in Accessibility page
7 participants