fix(useEventListener): avoid double handlers calls in React 17 #16514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
assuncaocharles,
dzearing,
jurokapsiar,
ling1726,
miroslavstastny and
pompomon
as code owners
msft-fluent-ui-bot
added
the
Fluent UI react-northstar (v0)
ling1726
reviewed
Jan 18, 2021
packages/fluentui/react-component-event-listener/src/useEventListener.ts
Show resolved
Hide resolved
ling1726
approved these changes
Jan 18, 2021
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1cf043d:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 134d782c8cedf6b2da632728d13ed433f0063279 (build) |
ling1726
pushed a commit
to ling1726/fluentui
that referenced
this pull request
Jan 18, 2021
…soft#16514) * fix(useEventListener): avoid double handlers calls in React 17 * add changelog entry
ling1726
added a commit
to ling1726/fluentui
that referenced
this pull request
Jan 18, 2021
ling1726
added a commit
that referenced
this pull request
Jan 18, 2021
…n React 17 #16514 (#16516) * fix(useEventListener): avoid double handlers calls in React 17 (#16514) * fix(useEventListener): avoid double handlers calls in React 17 * add changelog entry * chore(Backport): fix(useEventListener): avoid double handlers calls in React 17 #16514 Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com>
YuanboXue-Amber
pushed a commit
that referenced
this pull request
Jan 19, 2021
…n React 17 #16514 (#16516) * fix(useEventListener): avoid double handlers calls in React 17 (#16514) * fix(useEventListener): avoid double handlers calls in React 17 * add changelog entry * chore(Backport): fix(useEventListener): avoid double handlers calls in React 17 #16514 Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com>
assuncaocharles
pushed a commit
to assuncaocharles/fluentui
that referenced
this pull request
Feb 22, 2021
…soft#16514) * fix(useEventListener): avoid double handlers calls in React 17 * add changelog entry
assuncaocharles
added a commit
that referenced
this pull request
Feb 22, 2021
* fix(useEventListener): use a proper .event and clean up properly (#16991) * fix(useEventListener): use a proper .event and clean up properly * update impl to use refs * revert refs, use settimeout reset * add changelog entry * Export tree context (#16891) * export tree context * update changelog * fix(Dropdown): Add missing prop type (#16920) * Add missing prop type * Add changelog * fix(Tree): change selectionIndicator from visibility:hidden to display:none (#16922) …y:none - [ ] Addresses an existing issue: Fixes #0000 - [ ] Include a change request file using `$ yarn change` As described in title. `visibility: hidden` cause problem because the selectionIndicator still takes width (optional) * fix(useEventListener): avoid double handlers calls in React 17 (#16514) * fix(useEventListener): avoid double handlers calls in React 17 * add changelog entry * fix(MergeVariablesOverrides): return variables if they are defined (#16560) * fix(MergeVariablesOverrides): return variables if they are defined * fix(MergeVariablesOverrides): add changelog * Update packages/fluentui/react-bindings/src/utils/mergeVariablesOverrides.ts Co-authored-by: ling1726 <lingfangao@hotmail.com> * fix(MergeVariablesOverrides): check for plain objects * fix(MergeVariablesOverrides): fix test Co-authored-by: ling1726 <lingfangao@hotmail.com> * fix(react-context-selector): fix React warnings about setState() (#16714) * WIP on fixing contextSelector * fix(ContextSelector): fix * fix(ContextSelector): selectors * fix(ContextSelector): selectors tests fix * fix(ContextSelector): changelog * fix(ContextSelector): fix rollup * fix(ContextSelector): flatten context value * fix(ContextSelector): add comments * Update packages/fluentui/CHANGELOG.md Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * fix(ContextSelector): move scheduler to peerDependencies * Update packages/fluentui/react-context-selector/src/types.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-context-selector/src/types.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-context-selector/src/types.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-context-selector/src/createContext.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-context-selector/src/useContextSelector.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-context-selector/package.json Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * feat(Button): disabledFocusable for v0 Button (#16419) * button disabled focusable for v0 * fixes * changelog * disable pointer events only for disabled, not for disabledFocusable * fix * cleanup examples * small revert Co-authored-by: Juraj Kapsiar <jukapsia@microsoft.com> * adding Channel Share Icon for ODSP (#16619) * adding Channel Share Icon * feat(FormTextArea): Add new FormTextArea component (#16660) * feat(FormTextArea): add new FormTextArea component * feat(FormTextArea): add test * feat(FormTextArea): change type * feat(FormTextArea): add changelog * feat(TextArea): fix changelog * Update packages/fluentui/react-northstar/src/components/TextArea/TextArea.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * feat(TextArea): add error exampel * Update packages/fluentui/docs/src/examples/components/Form/Usage/FormExampleErrorAndSuccessful.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * feat(checkbox): add indeterminate support (#16081) * feat(checkbox): add indeterminate support * feat(checkbox): add props comment * feat(checkbox): add best practices * feat(checkbox): add changelog * feat(checkbox): rename indicator * feat(Checkbox): add mixed value support * feat(Checkbox): remove inderminate prop * feat(Checkbox): remove inderminate from state * feat(Checkbox): remove cast * Update packages/fluentui/CHANGELOG.md Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * feat(Checkbox): remove indeterminate from behavior * feat(Checkbox): remove unecessary check * feat(Checkbox): rename best practices * feat(Checkbox): remove indeterminate from styles * feat(Checkbox): rename example * feat(Checkbox): update contorl * Update packages/fluentui/react-northstar/src/themes/teams/components/Checkbox/checkboxStyles.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/themes/teams/components/Checkbox/checkboxStyles.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Checkbox/States/index.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * feat(Checkbox): update styles * feat(Checkbox): screener Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Adding imageAltText icon (#16884) * adding imageAltText icon * fix(felaRenderer): exclude className for CKEditor to avoid collisions (#17025) * fix(felaRenderer): exclude className for CKEditor to avoid collisions * add changelog entry * Update packages/fluentui/react-northstar-fela-renderer/src/createFelaRenderer.tsx * Update packages/fluentui/react-northstar-fela-renderer/src/createFelaRenderer.tsx * fix(useEventListener): use a proper .event and clean up properly (#16991) * fix(useEventListener): use a proper .event and clean up properly * update impl to use refs * revert refs, use settimeout reset * add changelog entry * fix(popupBehavior): remove role='complementary' from inline popup (#17032) * fix(popupBehavior): remove role='complementary' from inline popup * changelog * add popup test * chore: Automated release pipeline for fluent N* (#16866) * add pack-nightly task * Add nightly package to docsite * Add post publish validation script * Add canary release script * Fix dep url when pack nightly tarball * yaml pipeline * update redirect * fix pipeline * rename * nightly build fix * remove todo * gzip true * make dropdown display nightly version properly * update comment * update pipeline * put 0.0.0-nightly into const * Update scripts/tasks/fluentui-publish.ts Co-authored-by: ling1726 <lingfan.gao@microsoft.com> * Update azure-pipelines.release-fluentui.yml Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * update pipeline * update pipeline * update pipeline * hide clip board for nightly release * Update azure-pipelines.release-fluentui.yml Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * Update scripts/tasks/fluentui-publish.ts Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * Update scripts/tasks/fluentui-publish.ts Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * update packtarball * test pipeline * Update falsy check of nightlyRelease * fix doc build * fix * remove cruft * separate fluent ui tasks * store nightly tarballs in Build.ArtifactStagingDirectory * cleanup after tar; add --no-verify-access * add no-verify-access comment * update after trying out real release * add pipeline name * update pipeline description * Update scripts/fluentui-publish/index.ts Co-authored-by: ling1726 <lingfan.gao@microsoft.com> * fix screener build * test adding nightly date to nightly tarball versions * Update scripts/fluentui-publish/index.ts Co-authored-by: ling1726 <lingfan.gao@microsoft.com> * use newest folder for docsite * Revert "use newest folder for docsite" This reverts commit 2b8af70. * make codesandbox consistent for nightly release Co-authored-by: ling1726 <lingfan.gao@microsoft.com> Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> Co-authored-by: Amber <yuanboxue@microsoft.com> Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com> Co-authored-by: ling1726 <lingfangao@hotmail.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Juraj Kapsiar <jurokapsiar@gmail.com> Co-authored-by: Juraj Kapsiar <jukapsia@microsoft.com> Co-authored-by: Andrew Martin <andmarti@microsoft.com> Co-authored-by: ling1726 <lingfan.gao@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Semantic-Org/Semantic-UI-React#4110.
On Fluent N* side we will also have the same issues with
Portals, see facebook/react#20074 for more details. This PR performs a similar workaround as react-bootstrap/react-overlays#880.