Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change accordion item region to display block #16571

Merged
merged 20 commits into from
Jan 25, 2021

Conversation

eljefe223
Copy link
Contributor

@eljefe223 eljefe223 commented Jan 21, 2021

Pull request checklist

  • Addresses an existing issue: Fixes
  • Include a change request file using $ yarn change

Description of changes

Changes accordion item region to display block

eljefe223 and others added 20 commits September 17, 2020 15:03
Updating my fork with changes
@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 854 870 5000
BaseButtonCompat mount 963 1000 5000
Breadcrumb mount 42136 42627 5000
Checkbox mount 1587 1636 5000
CheckboxBase mount 1330 1322 5000
ChoiceGroup mount 4993 4888 5000
ComboBox mount 1062 1053 1000
CommandBar mount 10070 10428 1000
ContextualMenu mount 6090 6302 1000
DefaultButtonCompat mount 1169 1137 5000
DetailsRow mount 3710 3789 5000
DetailsRowFast mount 3952 3956 5000
DetailsRowNoStyles mount 3626 3650 5000
Dialog mount 1521 1563 1000
DocumentCardTitle mount 1785 1814 1000
Dropdown mount 3617 3688 5000
FocusTrapZone mount 1879 1878 5000
FocusZone mount 1866 1868 5000
IconButtonCompat mount 1810 1831 5000
Label mount 323 333 5000
Layer mount 1869 1804 5000
Link mount 456 518 5000
MakeStyles mount 1934 2026 50000
MenuButtonCompat mount 1540 1512 5000
MessageBar mount 2174 2209 5000
Nav mount 3407 3691 1000
OverflowSet mount 1104 1052 5000
Panel mount 1458 1461 1000
Persona mount 876 932 1000
Pivot mount 1407 1434 1000
PrimaryButtonCompat mount 1335 1359 5000
Rating mount 8370 8284 5000
SearchBox mount 1400 1397 5000
Shimmer mount 2717 2744 5000
Slider mount 1994 2096 5000
SpinButton mount 5184 5244 5000
Spinner mount 420 434 5000
SplitButtonCompat mount 3310 3413 5000
Stack mount 558 521 5000
StackWithIntrinsicChildren mount 1686 1704 5000
StackWithTextChildren mount 5014 4962 5000
SwatchColorPicker mount 10833 10791 5000
Tabs mount 1502 1451 1000
TagPicker mount 3118 2997 5000
TeachingBubble mount 11976 12362 5000
Text mount 460 449 5000
TextField mount 1542 1532 5000
ThemeProvider mount 2335 2326 5000
ThemeProvider virtual-rerender 685 687 5000
Toggle mount 858 870 5000
button mount 710 742 5000
buttonNative mount 113 119 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.18 0.52 0.35:1 2000 367
🦄 Button.Fluent 0.13 0.21 0.62:1 5000 632
🔧 Checkbox.Fluent 0.67 0.35 1.91:1 1000 674
🎯 Dialog.Fluent 0.18 0.24 0.75:1 5000 915
🔧 Dropdown.Fluent 3.22 0.44 7.32:1 1000 3219
🔧 Icon.Fluent 0.16 0.07 2.29:1 5000 792
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 451
🔧 Slider.Fluent 1.73 0.51 3.39:1 1000 1730
🔧 Text.Fluent 0.09 0.04 2.25:1 5000 433
🦄 Tooltip.Fluent 0.12 0.91 0.13:1 5000 619

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 227 204 1.11:1
SkeletonMinimalPerf.default 482 439 1.1:1
AccordionMinimalPerf.default 207 190 1.09:1
RefMinimalPerf.default 294 270 1.09:1
CarouselMinimalPerf.default 591 548 1.08:1
MenuButtonMinimalPerf.default 1817 1681 1.08:1
StatusMinimalPerf.default 849 789 1.08:1
TreeWith60ListItems.default 205 189 1.08:1
ReactionMinimalPerf.default 516 481 1.07:1
TextMinimalPerf.default 428 404 1.06:1
AttachmentMinimalPerf.default 207 197 1.05:1
ButtonSlotsPerf.default 716 685 1.05:1
DropdownMinimalPerf.default 3247 3087 1.05:1
HeaderSlotsPerf.default 977 927 1.05:1
SegmentMinimalPerf.default 463 442 1.05:1
SplitButtonMinimalPerf.default 4295 4072 1.05:1
Checkbox.Fluent 674 639 1.05:1
Text.Fluent 433 414 1.05:1
AnimationMinimalPerf.default 498 481 1.04:1
BoxMinimalPerf.default 434 416 1.04:1
DatepickerMinimalPerf.default 56417 54217 1.04:1
LayoutMinimalPerf.default 498 480 1.04:1
AttachmentSlotsPerf.default 1399 1353 1.03:1
ButtonUseCssNestingPerf.default 1295 1261 1.03:1
ChatDuplicateMessagesPerf.default 435 424 1.03:1
TableMinimalPerf.default 488 475 1.03:1
VideoMinimalPerf.default 725 702 1.03:1
Dialog.Fluent 915 892 1.03:1
Image.Fluent 451 439 1.03:1
CardMinimalPerf.default 677 664 1.02:1
ChatWithPopoverPerf.default 517 506 1.02:1
DropdownManyItemsPerf.default 858 844 1.02:1
EmbedMinimalPerf.default 4422 4351 1.02:1
ListMinimalPerf.default 604 593 1.02:1
ListWith60ListItems.default 744 730 1.02:1
LoaderMinimalPerf.default 810 798 1.02:1
TreeMinimalPerf.default 921 905 1.02:1
Button.Fluent 632 621 1.02:1
Icon.Fluent 792 774 1.02:1
ChatMinimalPerf.default 733 729 1.01:1
DialogMinimalPerf.default 921 908 1.01:1
FlexMinimalPerf.default 342 339 1.01:1
ItemLayoutMinimalPerf.default 1427 1413 1.01:1
ListCommonPerf.default 791 785 1.01:1
MenuMinimalPerf.default 1043 1031 1.01:1
IconMinimalPerf.default 743 736 1.01:1
TextAreaMinimalPerf.default 573 567 1.01:1
ToolbarMinimalPerf.default 1107 1096 1.01:1
TooltipMinimalPerf.default 944 931 1.01:1
Slider.Fluent 1730 1717 1.01:1
ButtonOverridesMissPerf.default 1925 1924 1:1
ButtonUseCssPerf.default 969 973 1:1
CheckboxMinimalPerf.default 3184 3191 1:1
GridMinimalPerf.default 406 405 1:1
ListNestedPerf.default 690 688 1:1
PortalMinimalPerf.default 169 169 1:1
RadioGroupMinimalPerf.default 539 537 1:1
TableManyItemsPerf.default 2223 2221 1:1
FormMinimalPerf.default 485 491 0.99:1
PopupMinimalPerf.default 752 758 0.99:1
AlertMinimalPerf.default 355 361 0.98:1
HeaderMinimalPerf.default 443 451 0.98:1
LabelMinimalPerf.default 491 500 0.98:1
SliderMinimalPerf.default 1762 1802 0.98:1
Dropdown.Fluent 3219 3270 0.98:1
InputMinimalPerf.default 1408 1460 0.96:1
ProviderMinimalPerf.default 1136 1179 0.96:1
Tooltip.Fluent 619 642 0.96:1
AvatarMinimalPerf.default 236 248 0.95:1
RosterPerf.default 1317 1382 0.95:1
ProviderMergeThemesPerf.default 1628 1719 0.95:1
CustomToolbarPrototype.default 4019 4209 0.95:1
DividerMinimalPerf.default 439 468 0.94:1
Avatar.Fluent 367 390 0.94:1
ImageMinimalPerf.default 463 499 0.93:1

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 574040d:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Jan 21, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2dc2216daa2afd1eb34a4051ddd6fe917a1f62c8 (build)

@chrisdholt chrisdholt merged commit 8abb40a into microsoft:master Jan 25, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/web-components@v0.11.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants