[web-components] add 'menuitemcheckbox' and 'menuitemradio' styles to fluent-menu-item #17305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
requested review from
ecraig12345,
Hotell and
nicholasrice
as code owners
chrisdholt
force-pushed
the
users/chhol/add-menu-item-checkbox-radio-styles
branch
from
8c7e70d
to
3ff2422
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9a3d9da:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 71010087992167fbc95e4fd1274f8ca5180b7cc8 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
khamudom
reviewed
Mar 6, 2021
| :host([aria-checked="true"]) ::slotted([slot="radio-indicator"]) { | ||
| display: block; | ||
| pointer-events: none; | ||
| } | ||
| `.withBehaviors( |
There was a problem hiding this comment.
to fix high contrast on the inputs you can add these rule sets to forcedColorsStylesheetBehavior
:host .checkbox,
:host .radio{
border-color: ${SystemColors.ButtonText};
background: ${SystemColors.HighlightText};
}
:host([checked="true"]) .checkbox,
:host([checked="true"]) .radio {
background: ${SystemColors.HighlightText};
border-color: ${SystemColors.HighlightText};
}
:host(:hover) .checkbox,
:host(:hover) .radio,
:host(:${focusVisible}) .checkbox,
:host(:${focusVisible}) .radio,
:host([checked="true"]:hover) .checkbox,
:host([checked="true"]:hover) .radio,
:host([checked="true"]:${focusVisible}) .checkbox,
:host([checked="true"]:${focusVisible}) .radio {
border-color: ${SystemColors.HighlightText};
}
:host([aria-checked="true"]) {
background: ${SystemColors.Highlight};
color: ${SystemColors.HighlightText};
}
:host([aria-checked="true"]) .checkbox-indicator,
:host([aria-checked="true"]) ::slotted([slot="checkbox-indicator"]),
:host([aria-checked="true"]) ::slotted([slot="radio-indicator"]) {
fill: ${SystemColors.Highlight};
}
:host([aria-checked="true"]) .radio-indicator {
background: ${SystemColors.Highlight};
}
:host([checked="true"]) .start,
:host([checked="true"]) .end {
fill: ${SystemColors.HighlightText};
}There was a problem hiding this comment.
Thanks @khamudom - updated!
khamudom
approved these changes
Mar 6, 2021
scomea
approved these changes
Mar 6, 2021
|
🎉 Handy links: |
joshualamusga1
pushed a commit
to joshualamusga1/fluentui
that referenced
this pull request
Mar 25, 2021
… fluent-menu-item (microsoft#17305) * add menuitemcheckbox and menuitemradio styling to menu-item * Change files * add high contrast styles
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
… fluent-menu-item (microsoft#17305) * add menuitemcheckbox and menuitemradio styling to menu-item * Change files * add high contrast styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
(give an overview)
Focus areas to test
(optional)