-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: moved disabled style into the button styles file #18195
fix: moved disabled style into the button styles file #18195
Conversation
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 7a8cfdba70f29d067c97e67a82f33db1f847c992 (build) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 05ff7ca:
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 843 | 863 | 5000 | |
BaseButton | mount | 872 | 879 | 5000 | |
Breadcrumb | mount | 2578 | 2578 | 1000 | |
ButtonNext | mount | 479 | 477 | 5000 | |
Checkbox | mount | 1502 | 1468 | 5000 | |
CheckboxBase | mount | 1245 | 1227 | 5000 | |
ChoiceGroup | mount | 4595 | 4656 | 5000 | |
ComboBox | mount | 965 | 944 | 1000 | |
CommandBar | mount | 9838 | 9892 | 1000 | |
ContextualMenu | mount | 5963 | 5960 | 1000 | |
DefaultButton | mount | 1067 | 1099 | 5000 | |
DetailsRow | mount | 3585 | 3605 | 5000 | |
DetailsRowFast | mount | 3664 | 3698 | 5000 | |
DetailsRowNoStyles | mount | 3399 | 3348 | 5000 | |
Dialog | mount | 2110 | 2101 | 1000 | |
DocumentCardTitle | mount | 134 | 148 | 1000 | |
Dropdown | mount | 3174 | 3143 | 5000 | |
FocusTrapZone | mount | 1770 | 1710 | 5000 | |
FocusZone | mount | 1780 | 1752 | 5000 | |
IconButton | mount | 1667 | 1685 | 5000 | |
Label | mount | 334 | 336 | 5000 | |
Layer | mount | 1726 | 1720 | 5000 | |
Link | mount | 445 | 456 | 5000 | |
MakeStyles | mount | 1765 | 1789 | 50000 | |
MenuButton | mount | 1393 | 1426 | 5000 | |
MessageBar | mount | 1961 | 1980 | 5000 | |
Nav | mount | 3160 | 3185 | 1000 | |
OverflowSet | mount | 1019 | 1011 | 5000 | |
Panel | mount | 1301 | 2014 | 1000 | |
Persona | mount | 809 | 810 | 1000 | |
Pivot | mount | 1378 | 1490 | 1000 | |
PrimaryButton | mount | 1246 | 1259 | 5000 | |
Rating | mount | 7414 | 7383 | 5000 | |
SearchBox | mount | 1293 | 1288 | 5000 | |
Shimmer | mount | 2457 | 2543 | 5000 | |
Slider | mount | 1922 | 1897 | 5000 | |
SpinButton | mount | 4802 | 4922 | 5000 | |
Spinner | mount | 406 | 413 | 5000 | |
SplitButton | mount | 3085 | 3041 | 5000 | |
Stack | mount | 492 | 472 | 5000 | |
StackWithIntrinsicChildren | mount | 1521 | 1496 | 5000 | |
StackWithTextChildren | mount | 4447 | 4456 | 5000 | |
SwatchColorPicker | mount | 9953 | 9959 | 5000 | |
Tabs | mount | 1359 | 1372 | 1000 | |
TagPicker | mount | 2375 | 2389 | 5000 | |
TeachingBubble | mount | 11527 | 11761 | 5000 | |
Text | mount | 396 | 401 | 5000 | |
TextField | mount | 1307 | 1311 | 5000 | |
ThemeProvider | mount | 1134 | 1149 | 5000 | |
ThemeProvider | virtual-rerender | 582 | 576 | 5000 | |
ThemeProviderNext | mount | 6789 | 6833 | 5000 | |
Toggle | mount | 787 | 794 | 5000 | |
buttonNative | mount | 118 | 112 | 5000 |
Perf Analysis (@fluentui/react-northstar
)
Potential regressions comparing to master
Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
---|---|---|---|---|
PortalMinimalPerf.default | 160 | 156 | 1.03:1 | analysis |
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
TreeWith60ListItems.default | 182 | 169 | 1.08:1 |
IconMinimalPerf.default | 616 | 579 | 1.06:1 |
TextAreaMinimalPerf.default | 480 | 451 | 1.06:1 |
AccordionMinimalPerf.default | 153 | 146 | 1.05:1 |
FlexMinimalPerf.default | 286 | 273 | 1.05:1 |
InputMinimalPerf.default | 1274 | 1213 | 1.05:1 |
SkeletonMinimalPerf.default | 365 | 348 | 1.05:1 |
TextMinimalPerf.default | 356 | 339 | 1.05:1 |
ListMinimalPerf.default | 490 | 473 | 1.04:1 |
CarouselMinimalPerf.default | 454 | 439 | 1.03:1 |
DatepickerMinimalPerf.default | 5319 | 5183 | 1.03:1 |
DropdownManyItemsPerf.default | 670 | 652 | 1.03:1 |
LayoutMinimalPerf.default | 360 | 351 | 1.03:1 |
ListNestedPerf.default | 531 | 518 | 1.03:1 |
MenuButtonMinimalPerf.default | 1523 | 1485 | 1.03:1 |
SegmentMinimalPerf.default | 347 | 338 | 1.03:1 |
VideoMinimalPerf.default | 603 | 587 | 1.03:1 |
AnimationMinimalPerf.default | 402 | 396 | 1.02:1 |
ButtonOverridesMissPerf.default | 1655 | 1624 | 1.02:1 |
ButtonSlotsPerf.default | 546 | 534 | 1.02:1 |
CardMinimalPerf.default | 545 | 534 | 1.02:1 |
ChatMinimalPerf.default | 601 | 587 | 1.02:1 |
CheckboxMinimalPerf.default | 2734 | 2668 | 1.02:1 |
DialogMinimalPerf.default | 715 | 703 | 1.02:1 |
HeaderSlotsPerf.default | 740 | 723 | 1.02:1 |
ListCommonPerf.default | 613 | 599 | 1.02:1 |
PopupMinimalPerf.default | 557 | 546 | 1.02:1 |
StatusMinimalPerf.default | 675 | 665 | 1.02:1 |
TooltipMinimalPerf.default | 940 | 923 | 1.02:1 |
AlertMinimalPerf.default | 256 | 253 | 1.01:1 |
AvatarMinimalPerf.default | 201 | 199 | 1.01:1 |
DividerMinimalPerf.default | 353 | 351 | 1.01:1 |
DropdownMinimalPerf.default | 3019 | 2993 | 1.01:1 |
EmbedMinimalPerf.default | 4094 | 4035 | 1.01:1 |
FormMinimalPerf.default | 397 | 393 | 1.01:1 |
ItemLayoutMinimalPerf.default | 1218 | 1205 | 1.01:1 |
ReactionMinimalPerf.default | 378 | 374 | 1.01:1 |
TableManyItemsPerf.default | 1889 | 1866 | 1.01:1 |
TableMinimalPerf.default | 404 | 399 | 1.01:1 |
CustomToolbarPrototype.default | 3787 | 3734 | 1.01:1 |
AttachmentMinimalPerf.default | 143 | 143 | 1:1 |
MenuMinimalPerf.default | 804 | 803 | 1:1 |
ProviderMinimalPerf.default | 966 | 966 | 1:1 |
RadioGroupMinimalPerf.default | 428 | 429 | 1:1 |
RefMinimalPerf.default | 234 | 233 | 1:1 |
SliderMinimalPerf.default | 1569 | 1571 | 1:1 |
SplitButtonMinimalPerf.default | 3672 | 3670 | 1:1 |
AttachmentSlotsPerf.default | 1104 | 1118 | 0.99:1 |
ChatWithPopoverPerf.default | 354 | 359 | 0.99:1 |
LabelMinimalPerf.default | 374 | 378 | 0.99:1 |
ListWith60ListItems.default | 622 | 628 | 0.99:1 |
LoaderMinimalPerf.default | 667 | 676 | 0.99:1 |
RosterPerf.default | 1145 | 1155 | 0.99:1 |
ToolbarMinimalPerf.default | 902 | 909 | 0.99:1 |
BoxMinimalPerf.default | 331 | 339 | 0.98:1 |
GridMinimalPerf.default | 319 | 324 | 0.98:1 |
HeaderMinimalPerf.default | 344 | 352 | 0.98:1 |
ProviderMergeThemesPerf.default | 1628 | 1654 | 0.98:1 |
TreeMinimalPerf.default | 750 | 769 | 0.98:1 |
ButtonMinimalPerf.default | 153 | 161 | 0.95:1 |
ChatDuplicateMessagesPerf.default | 275 | 290 | 0.95:1 |
ImageMinimalPerf.default | 350 | 369 | 0.95:1 |
change/@fluentui-web-components-33ee01f8-ba19-4b46-80cc-ec22b85b7483.json
Outdated
Show resolved
Hide resolved
🎉 Handy links: |
Pull request checklist
$ yarn change
Description of changes
Move the disabled styles from pattern styles into button styles so the anchor button will not inherit the styles.
Focus areas to test
(optional)