(web-components) Design token cleanup #18410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheston
requested review from
chrisdholt,
EisenbergEffect,
nicholasrice and
a team
as code owners
chrisdholt
requested changes
Jun 1, 2021
There was a problem hiding this comment.
@bheston I think you meant to open this against features/web-components-vNext
EisenbergEffect
approved these changes
Jun 2, 2021
chrisdholt
force-pushed
the
features/web-components-vNext
branch
from
b013a96
to
a5e0caf
Compare
…osoft#18187) * update accordion to use foundation element * update anchor to extend foundation element * update anchored region to extend foundation element * correct style exports * update badge to extend foundation * update breadcrumb to extend foundation element * update button to extend foundation element * update checkbox to extend foundation element * update combobox to extend foundation element * update dialog to extend foundation element * update divider styles * update flipper to extend foundation element * update horizontal scroll to extend foundation element * update listbox to extend foundation element * update listbox option to extend foundation element * update naming for exported registries * update menu and menu item to extend foundation * aupdate number field to extend foundation element * update progress to extend foundation element * update radio, radiogroup and select to extend foundation el * update skeleton to extend foundation element * update slider to extend foundation element * update switch to extend foundation component * correct prefix for export names * update text area to extend foundation element * update text field to extend foundation * update tooltip to extend foundation element * update tree view to extend foundation element * update comments v1 * export all custom element definitions * exportfluent design system and definitions from rollup * add data grid * update fast to fluent in rollup * add beta package to start updating w/ foundation element * update stories files * Change files
- neutralContrastFill -> neutralFillInverse - neutralFillToggle -> neutralFillContrast - neutralFocus -> focusStrokeOuter - neutralFocusInnerAccent -> focusStrokeInner - outline -> stroke - Removed 'selected' colors
Defining visual intent using adjective form opposed to implementation details
- cornerRadius -> controlConerRadius - elevatedCornerRadius -> surfaceCornerRadius - removed neutral foreground states
bheston
force-pushed
the
design-token-cleanup
branch
from
18ee066
to
98f8895
Compare
nicholasrice
approved these changes
Jun 9, 2021
chrisdholt
added a commit
that referenced
this pull request
Jul 2, 2021
* Rename and clean up of design tokens and recipe: - neutralContrastFill -> neutralFillInverse - neutralFillToggle -> neutralFillContrast - neutralFocus -> focusStrokeOuter - neutralFocusInnerAccent -> focusStrokeInner - outline -> stroke - Removed 'selected' colors * Added deprecated alias tokens for renames * Rename neutral fill "contrast" to "strong" Defining visual intent using adjective form opposed to implementation details * Updated a couple more design tokens - cornerRadius -> controlConerRadius - elevatedCornerRadius -> surfaceCornerRadius - removed neutral foreground states * Change files Co-authored-by: Chris Holt <chhol@microsoft.com>
chrisdholt
added a commit
that referenced
this pull request
Jul 2, 2021
* Rename and clean up of design tokens and recipe: - neutralContrastFill -> neutralFillInverse - neutralFillToggle -> neutralFillContrast - neutralFocus -> focusStrokeOuter - neutralFocusInnerAccent -> focusStrokeInner - outline -> stroke - Removed 'selected' colors * Added deprecated alias tokens for renames * Rename neutral fill "contrast" to "strong" Defining visual intent using adjective form opposed to implementation details * Updated a couple more design tokens - cornerRadius -> controlConerRadius - elevatedCornerRadius -> surfaceCornerRadius - removed neutral foreground states * Change files Co-authored-by: Chris Holt <chhol@microsoft.com>
PeterDraex
pushed a commit
to PeterDraex/fluentui
that referenced
this pull request
Aug 6, 2021
* Rename and clean up of design tokens and recipe: - neutralContrastFill -> neutralFillInverse - neutralFillToggle -> neutralFillContrast - neutralFocus -> focusStrokeOuter - neutralFocusInnerAccent -> focusStrokeInner - outline -> stroke - Removed 'selected' colors * Added deprecated alias tokens for renames * Rename neutral fill "contrast" to "strong" Defining visual intent using adjective form opposed to implementation details * Updated a couple more design tokens - cornerRadius -> controlConerRadius - elevatedCornerRadius -> surfaceCornerRadius - removed neutral foreground states * Change files Co-authored-by: Chris Holt <chhol@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Updated exported design token names to more closely follow the updated design language.
Focus areas to test
(optional)