Skip to content

Text Convergence Spec #18462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 30, 2021
Merged

Text Convergence Spec #18462

merged 13 commits into from
Jun 30, 2021

Conversation

@theerebuss
Copy link
Contributor

@theerebuss theerebuss commented Jun 7, 2021

Description of changes

Convergence spec for the Text component

@theerebuss theerebuss added this to the June Project Cycle Q2 2021 milestone Jun 7, 2021
@size-auditor
Copy link

size-auditor bot commented Jun 7, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5a6dd90efb20b162aa3883c34faa211b5620b334 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 7, 2021 •
edited
Loading

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
Panel mount 1980 1302 1000 Possible regression
Text mount 397 399 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 762 733 5000
BaseButton mount 849 834 5000
Breadcrumb mount 2471 2532 1000
ButtonNext mount 490 480 5000
Checkbox mount 1407 1369 5000
CheckboxBase mount 1236 1217 5000
ChoiceGroup mount 4515 4439 5000
ComboBox mount 895 946 1000
CommandBar mount 9693 9640 1000
ContextualMenu mount 5854 5895 1000
DefaultButton mount 1068 1060 5000
DetailsRow mount 3472 3466 5000
DetailsRowFast mount 3523 3519 5000
DetailsRowNoStyles mount 3345 3335 5000
Dialog mount 1988 1989 1000
DocumentCardTitle mount 135 137 1000
Dropdown mount 3048 3036 5000
FocusTrapZone mount 1688 1759 5000
FocusZone mount 1713 1710 5000
IconButton mount 1632 1610 5000
Label mount 305 310 5000
Layer mount 1684 1712 5000
Link mount 448 434 5000
MakeStyles mount 1703 1701 50000
MenuButton mount 1378 1336 5000
MessageBar mount 1922 1891 5000
Nav mount 3085 3055 1000
OverflowSet mount 986 987 5000
Panel mount 1980 1302 1000 Possible regression
Persona mount 782 763 1000
Pivot mount 1314 1318 1000
PrimaryButton mount 1195 1198 5000
Rating mount 7101 7110 5000
SearchBox mount 1244 1226 5000
Shimmer mount 2441 2368 5000
Slider mount 1856 1859 5000
SpinButton mount 4789 4709 5000
Spinner mount 393 398 5000
SplitButton mount 2949 3040 5000
Stack mount 465 466 5000
StackWithIntrinsicChildren mount 1425 1474 5000
StackWithTextChildren mount 4200 4218 5000
SwatchColorPicker mount 9589 9700 5000
Tabs mount 1305 1316 1000
TagPicker mount 2288 2332 5000
TeachingBubble mount 11299 11299 5000
Text mount 397 399 5000 Possible regression
TextField mount 1278 1286 5000
ThemeProvider mount 1132 1114 5000
ThemeProvider virtual-rerender 574 570 5000
ThemeProviderNext mount 6824 6735 5000
Toggle mount 748 766 5000
buttonNative mount 97 105 5000

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
HeaderMinimalPerf.default 340 337 1.01:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TextMinimalPerf.default 350 320 1.09:1
ChatDuplicateMessagesPerf.default 280 260 1.08:1
AvatarMinimalPerf.default 193 181 1.07:1
FormMinimalPerf.default 390 369 1.06:1
AlertMinimalPerf.default 259 246 1.05:1
GridMinimalPerf.default 319 308 1.04:1
MenuMinimalPerf.default 808 778 1.04:1
PortalMinimalPerf.default 173 166 1.04:1
SegmentMinimalPerf.default 326 314 1.04:1
IconMinimalPerf.default 590 565 1.04:1
BoxMinimalPerf.default 340 331 1.03:1
ButtonMinimalPerf.default 165 160 1.03:1
ButtonSlotsPerf.default 536 522 1.03:1
CarouselMinimalPerf.default 432 419 1.03:1
DropdownManyItemsPerf.default 651 635 1.03:1
ListCommonPerf.default 598 580 1.03:1
ListNestedPerf.default 525 511 1.03:1
SkeletonMinimalPerf.default 338 329 1.03:1
TooltipMinimalPerf.default 965 938 1.03:1
TreeWith60ListItems.default 161 157 1.03:1
ListMinimalPerf.default 491 481 1.02:1
ProviderMinimalPerf.default 927 909 1.02:1
ToolbarMinimalPerf.default 880 865 1.02:1
AttachmentSlotsPerf.default 1027 1020 1.01:1
CardMinimalPerf.default 520 513 1.01:1
ChatWithPopoverPerf.default 331 329 1.01:1
DropdownMinimalPerf.default 2972 2957 1.01:1
HeaderSlotsPerf.default 719 712 1.01:1
InputMinimalPerf.default 1209 1197 1.01:1
ItemLayoutMinimalPerf.default 1152 1142 1.01:1
PopupMinimalPerf.default 550 543 1.01:1
RadioGroupMinimalPerf.default 425 421 1.01:1
SplitButtonMinimalPerf.default 3567 3524 1.01:1
TableManyItemsPerf.default 1784 1761 1.01:1
VideoMinimalPerf.default 597 593 1.01:1
AnimationMinimalPerf.default 398 400 1:1
ChatMinimalPerf.default 613 616 1:1
CheckboxMinimalPerf.default 2609 2609 1:1
EmbedMinimalPerf.default 3926 3912 1:1
FlexMinimalPerf.default 262 262 1:1
LabelMinimalPerf.default 367 366 1:1
ProviderMergeThemesPerf.default 1607 1605 1:1
TableMinimalPerf.default 371 372 1:1
CustomToolbarPrototype.default 3580 3572 1:1
AttachmentMinimalPerf.default 144 146 0.99:1
ButtonOverridesMissPerf.default 1597 1608 0.99:1
DialogMinimalPerf.default 703 709 0.99:1
LayoutMinimalPerf.default 343 346 0.99:1
MenuButtonMinimalPerf.default 1501 1509 0.99:1
SliderMinimalPerf.default 1456 1469 0.99:1
StatusMinimalPerf.default 622 630 0.99:1
DatepickerMinimalPerf.default 5009 5130 0.98:1
ReactionMinimalPerf.default 360 366 0.98:1
TextAreaMinimalPerf.default 450 457 0.98:1
AccordionMinimalPerf.default 139 143 0.97:1
ImageMinimalPerf.default 350 359 0.97:1
LoaderMinimalPerf.default 646 663 0.97:1
TreeMinimalPerf.default 734 753 0.97:1
DividerMinimalPerf.default 328 340 0.96:1
RosterPerf.default 1116 1167 0.96:1
RefMinimalPerf.default 216 226 0.96:1
ListWith60ListItems.default 602 642 0.94:1

@theerebuss theerebuss mentioned this pull request Jun 7, 2021
Closed
44 tasks
@ling1726 ling1726 requested review from a team June 9, 2021 16:35
@theerebuss theerebuss removed request for a team June 9, 2021 16:39
André Dias and others added 6 commits June 14, 2021 15:20
@tringakrasniqi
Initial spec structure
18675a9 
Prop comparison

Co-authored-by: Tringa Krasniqi <tkrasniqi@microsoft.com>
@tringakrasniqi
Add background
f78a840 
Add prior art

Co-authored-by: Tringa Krasniqi <tkrasniqi@microsoft.com>
@tringakrasniqi
Add initial API proposal
142728b 
Co-authored-by: Tringa Krasniqi <tkrasniqi@microsoft.com>
@tringakrasniqi
Text API proposal finish
9e3d37a 
Sample code for Text/wrappers

Co-authored-by: Tringa Krasniqi <tkrasniqi@microsoft.com>
@tringakrasniqi
Behaviours and Accessibility
1181bab 
Co-authored-by: Tringa Krasniqi <tkrasniqi@microsoft.com>
@tringakrasniqi
Add API preface
43bd12d 
Co-authored-by: Tringa Krasniqi <tkrasniqi@microsoft.com>
khmakoto
khmakoto reviewed Jun 15, 2021
View reviewed changes
ling1726
ling1726 reviewed Jun 15, 2021
View reviewed changes
@tringakrasniqi
Add make-styles rule definition
a57ff7a 
Finish spec

Co-authored-by: Tringa Krasniqi <tkrasniqi@microsoft.com>
@theerebuss theerebuss marked this pull request as ready for review June 15, 2021 13:17
@theerebuss theerebuss requested review from a team June 15, 2021 13:18
@khmakoto
Update packages/react-text/Spec.md
11eafc8 
Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
André Dias and others added 2 commits June 15, 2021 15:39
Change files
5347187
@tringakrasniqi
Change 'as' prop type to keyof JSX.IntrinsicElements
544df11 
Co-authored-by: Tringa Krasniqi <tkrasniqi@microsoft.com>
layershifter
layershifter reviewed Jun 23, 2021
View reviewed changes
André Dias and others added 2 commits June 24, 2021 16:34
@tringakrasniqi
Limit as prop values
c159377 
Co-authored-by: Tringa Krasniqi <tkrasniqi@microsoft.com>
@tringakrasniqi
Change makeStyles solution's approach
b5ea948 
Co-authored-by: Tringa Krasniqi <tkrasniqi@microsoft.com>
ling1726
ling1726 reviewed Jun 25, 2021
View reviewed changes
@theerebuss theerebuss merged commit a9ff15a into microsoft:master Jun 30, 2021
@theerebuss theerebuss deleted the text-spec branch June 30, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@layershifter layershifter layershifter left review comments

@khmakoto khmakoto khmakoto approved these changes

+1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tringakrasniqi tringakrasniqi

@theerebuss theerebuss

Labels

Component: Text Type: Spec Component spec PR

Projects

None yet

Milestone

June Project Cycle Q2 2021

Development

Successfully merging this pull request may close these issues.

7 participants

@theerebuss @fabricteam @khmakoto @layershifter @ling1726 @miroslavstastny @tringakrasniqi