(web-components) update DesignSystemProvider to use design tokens #18578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasrice
requested review from
chrisdholt and
EisenbergEffect
as code owners
bheston
approved these changes
Jun 16, 2021
| cssCustomProperty: false, | ||
| default: DesignSystemDefaults.neutralFillCardDelta, | ||
| }) | ||
| public neutralFillCardDelta: number; |
There was a problem hiding this comment.
We probably still want this, though it's neutralFillLayerRestDelta now.
There was a problem hiding this comment.
has that work happened here yet? I don't see that design token, and the recipe is still neutralLayerCard
bheston
changed the title
chrisdholt
pushed a commit
that referenced
this pull request
Jul 2, 2021
…8578) * migrate DSP to design tokens * convert PaletteRGB to Palette Co-authored-by: nicholasrice <nicholasrice@users.noreply.github.com>
chrisdholt
pushed a commit
that referenced
this pull request
Jul 2, 2021
…8578) * migrate DSP to design tokens * convert PaletteRGB to Palette Co-authored-by: nicholasrice <nicholasrice@users.noreply.github.com>
PeterDraex
pushed a commit
to PeterDraex/fluentui
that referenced
this pull request
Aug 6, 2021
…crosoft#18578) * migrate DSP to design tokens * convert PaletteRGB to Palette Co-authored-by: nicholasrice <nicholasrice@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Updates the DSP custom element to leverage DesignToken infrastructure.
Focus areas to test
(optional)