Fixed foregroundOnAccent recipe to work in all states #18765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheston
requested review from
chrisdholt,
EisenbergEffect,
nicholasrice and
a team
as code owners
Hotell
reviewed
Jun 30, 2021
chrisdholt
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
FYI @Hotell - we've reverted the yarn.lock change. I'm going to update eslint and prettier so I'll be pinging you for those and that should be it besides the feature branch merge. Thanks again for catching that odd addition to the yarn.lock.
nicholasrice
approved these changes
Jun 30, 2021
chrisdholt
pushed a commit
that referenced
this pull request
Jul 2, 2021
* Fixed foregroundOnAccent recipe to work in all states * Change files * Revert change to yarn.lock
chrisdholt
pushed a commit
that referenced
this pull request
Jul 2, 2021
* Fixed foregroundOnAccent recipe to work in all states * Change files * Revert change to yarn.lock
PeterDraex
pushed a commit
to PeterDraex/fluentui
that referenced
this pull request
Aug 6, 2021
* Fixed foregroundOnAccent recipe to work in all states * Change files * Revert change to yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Fixed an issue where a previous relationship between accentFill and foregroundOnAccent tried to maintain the same foreground color regardless of fill. This was always problematic with the fill offset deltas as it was possible to specify deltas so far apart that no single foreground color could meet contrast. Going forward I think we want a more layered approach, where the fill color is based on that component's container color, and the foreground color is based on that fill color. For example, it's possible for the foreground to flip between black and white given a large fill delta.
Focus areas to test
Accent-filled components like buttons or switches.