Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate packages to single version policy #18808

Merged
merged 7 commits into from
Jul 8, 2021
Merged

chore: migrate packages to single version policy #18808

merged 7 commits into from
Jul 8, 2021

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jul 2, 2021 •
edited
Loading

Pull request checklist

  • [ ] Addresses an existing issue:
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

@Hotell
Copy link
Contributor Author

Hotell commented Jul 2, 2021 •
edited
Loading

Getting syncpack errors
2021-07-02 at 10 39

why is this happening:

  • we wanna have root package.json => with exact version policy
  • we wanna have package deps => with ^ or ~ (range) version policy

I can't remember how you proposed to tackle those @ecraig12345 😅, can you please refresh my memory 🙏 ?

@DustyTheBot
Copy link

DustyTheBot commented Jul 2, 2021 •
edited
Loading

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against 680f010

@Hotell Hotell mentioned this pull request Jul 2, 2021
Merged
2 tasks
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 2, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 680f010:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

Hotell
Hotell commented Jul 7, 2021
View reviewed changes
package.json
@@ -221,9 +247,24 @@
],
"dependencies": [
"@babel/core",
"@typescript-eslint/eslint-plugin",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied version group for packages that are defined as dependencies for packages that are being published to npm registry

this fixes syncpack error, not sure if this is the right way to go:

#18808 (comment)

Hotell
Hotell commented Jul 7, 2021
View reviewed changes
apps/test-bundles/package.json
@@ -10,12 +10,9 @@
"code-style": "just-scripts code-style",
"just": "just-scripts"
},
"dependencies": {
"devDependencies": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app is not being published to npm, also those deps are devDeps -> applied

@Hotell Hotell force-pushed the hotell/build-system/svp-cleanup-july-1 branch from 0a73fd2 to ff3d0ee Compare July 7, 2021 10:28
@Hotell Hotell changed the title chore: migrate packages(mostly eslint related) to single version policy chore: migrate packages to single version policy Jul 7, 2021
@Hotell Hotell force-pushed the hotell/build-system/svp-cleanup-july-1 branch from 8166b3e to db1d6ef Compare July 7, 2021 14:52
Hotell
Hotell commented Jul 7, 2021
View reviewed changes
packages/eslint-plugin/src/configs/react.js
@@ -220,6 +220,7 @@ const config = {
'react/sort-comp': 'off',
'react/state-in-constructor': 'off',
'react/static-property-placement': 'off',
'react/require-default-props': 'off',
Copy link
Contributor Author

@Hotell Hotell Jul 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prior to moving airbnb rules to exact/single version policy default-props rule was not properly triggered. ...

with this PR it started to work and failed basically all around the monorepo - thus turning it off as our component composition model is more advance than this rule capabilities

@Hotell Hotell force-pushed the hotell/build-system/svp-cleanup-july-1 branch from db1d6ef to 76bec0a Compare July 7, 2021 15:24
@size-auditor
Copy link

size-auditor bot commented Jul 7, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 619fec5ad3ea4ee5177e59e5de589385207e6175 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 796 793 5000
BaseButton mount 880 871 5000
Breadcrumb mount 2619 2584 1000
ButtonNext mount 513 518 5000
Checkbox mount 1498 1477 5000
CheckboxBase mount 1258 1245 5000
ChoiceGroup mount 4616 4686 5000
ComboBox mount 947 981 1000
CommandBar mount 9952 9902 1000
ContextualMenu mount 6241 6213 1000
DefaultButton mount 1098 1091 5000
DetailsRow mount 3696 3758 5000
DetailsRowFast mount 3642 3600 5000
DetailsRowNoStyles mount 3502 3516 5000
Dialog mount 2124 2094 1000
DocumentCardTitle mount 138 141 1000
Dropdown mount 3183 3179 5000
FluentProviderNext mount 7248 7129 5000
FocusTrapZone mount 1753 1750 5000
FocusZone mount 1785 1765 5000
IconButton mount 1678 1660 5000
Label mount 309 333 5000
Layer mount 1742 1727 5000
Link mount 456 460 5000
MakeStyles mount 1764 1739 50000
MenuButton mount 1423 1409 5000
MessageBar mount 1950 1949 5000
Nav mount 3207 3131 1000
OverflowSet mount 1013 1026 5000
Panel mount 2119 2054 1000
Persona mount 801 822 1000
Pivot mount 1464 1382 1000
PrimaryButton mount 1256 1250 5000
Rating mount 7407 7458 5000
SearchBox mount 1311 1313 5000
Shimmer mount 2449 2506 5000
Slider mount 1900 1928 5000
SpinButton mount 4866 4839 5000
Spinner mount 402 410 5000
SplitButton mount 3072 3128 5000
Stack mount 516 493 5000
StackWithIntrinsicChildren mount 1455 1464 5000
StackWithTextChildren mount 4380 4376 5000
SwatchColorPicker mount 9900 10006 5000
Tabs mount 1376 1401 1000
TagPicker mount 2297 2353 5000
TeachingBubble mount 11698 11712 5000
Text mount 420 406 5000
TextField mount 1359 1342 5000
ThemeProvider mount 1156 1161 5000
ThemeProvider virtual-rerender 590 590 5000
Toggle mount 791 773 5000
buttonNative mount 107 122 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 154 142 1.08:1
CarouselMinimalPerf.default 462 432 1.07:1
FormMinimalPerf.default 402 380 1.06:1
SegmentMinimalPerf.default 355 337 1.05:1
ChatMinimalPerf.default 654 626 1.04:1
LayoutMinimalPerf.default 363 349 1.04:1
CardMinimalPerf.default 545 531 1.03:1
ChatDuplicateMessagesPerf.default 285 277 1.03:1
GridMinimalPerf.default 324 316 1.03:1
HeaderMinimalPerf.default 368 357 1.03:1
ListMinimalPerf.default 511 498 1.03:1
PopupMinimalPerf.default 577 559 1.03:1
SliderMinimalPerf.default 1540 1500 1.03:1
AlertMinimalPerf.default 274 269 1.02:1
AnimationMinimalPerf.default 410 402 1.02:1
ChatWithPopoverPerf.default 346 340 1.02:1
DividerMinimalPerf.default 347 341 1.02:1
FlexMinimalPerf.default 279 274 1.02:1
ItemLayoutMinimalPerf.default 1207 1179 1.02:1
ListCommonPerf.default 613 599 1.02:1
RefMinimalPerf.default 234 230 1.02:1
StatusMinimalPerf.default 672 662 1.02:1
CustomToolbarPrototype.default 3769 3698 1.02:1
TreeMinimalPerf.default 794 778 1.02:1
AttachmentSlotsPerf.default 1035 1029 1.01:1
ButtonMinimalPerf.default 166 165 1.01:1
ListNestedPerf.default 543 538 1.01:1
MenuMinimalPerf.default 823 813 1.01:1
PortalMinimalPerf.default 178 177 1.01:1
TextAreaMinimalPerf.default 477 470 1.01:1
ButtonOverridesMissPerf.default 1675 1680 1:1
DatepickerMinimalPerf.default 5228 5243 1:1
DropdownManyItemsPerf.default 650 652 1:1
DropdownMinimalPerf.default 3013 3028 1:1
EmbedMinimalPerf.default 3995 3991 1:1
InputMinimalPerf.default 1231 1229 1:1
LoaderMinimalPerf.default 672 675 1:1
RadioGroupMinimalPerf.default 434 434 1:1
SplitButtonMinimalPerf.default 3630 3637 1:1
IconMinimalPerf.default 598 598 1:1
TableManyItemsPerf.default 1840 1836 1:1
ToolbarMinimalPerf.default 921 917 1:1
AccordionMinimalPerf.default 143 145 0.99:1
AvatarMinimalPerf.default 187 188 0.99:1
BoxMinimalPerf.default 342 347 0.99:1
ButtonSlotsPerf.default 536 541 0.99:1
CheckboxMinimalPerf.default 2684 2704 0.99:1
ImageMinimalPerf.default 359 361 0.99:1
MenuButtonMinimalPerf.default 1538 1555 0.99:1
ProviderMinimalPerf.default 936 947 0.99:1
TooltipMinimalPerf.default 953 964 0.99:1
DialogMinimalPerf.default 724 742 0.98:1
HeaderSlotsPerf.default 730 748 0.98:1
LabelMinimalPerf.default 361 370 0.98:1
ProviderMergeThemesPerf.default 1620 1651 0.98:1
ReactionMinimalPerf.default 365 372 0.98:1
SkeletonMinimalPerf.default 342 349 0.98:1
TableMinimalPerf.default 392 401 0.98:1
TextMinimalPerf.default 333 341 0.98:1
ListWith60ListItems.default 635 653 0.97:1
VideoMinimalPerf.default 610 630 0.97:1
RosterPerf.default 1107 1154 0.96:1
TreeWith60ListItems.default 159 176 0.9:1

@Hotell Hotell marked this pull request as ready for review July 7, 2021 16:40
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-aria@v9.0.0-alpha.8 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/public-docsite-setup@v0.3.6 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/monaco-editor@v1.1.3 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/merge-styles@v8.1.3 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/make-styles@v9.0.0-alpha.27 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/keyboard-key@v0.3.3 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/jest-serializer-merge-styles@v8.0.8 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/jest-serializer-make-styles@v9.0.0-alpha.23 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/foundation-legacy@v8.1.5 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/font-icons-mdl2@v8.1.5 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/example-data@v8.2.4 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/dom-utilities@v2.1.3 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/date-time-utilities@v8.2.1 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/common-styles@v1.0.11 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-popover@v9.0.0-alpha.15 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-link@v9.0.0-alpha.54 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-examples@v8.34.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-components@v9.0.0-alpha.75 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-button@v9.0.0-alpha.56 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-badge@v9.0.0-alpha.54 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-avatar@v9.0.0-alpha.53 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/public-docsite@v8.2.40 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-accordion@v9.0.0-alpha.48 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/public-docsite-resources@v8.1.40 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/eslint-plugin@v1.3.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/codemods@v8.1.4 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/babel-make-styles@v9.0.0-alpha.23 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/azure-themes@v8.1.34 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/api-docs@v8.1.34 has been released which incorporates this pull request.:tada:

Handy links:

PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
@Hotell @PeterDraex
chore: migrate packages to single version policy (microsoft#18808)
eec71ba 
* chore: migrate packages(mostly eslint related)  to single version policy
* chore: migrate packages(express,fsextra)  to single version policy
* fix(eslint-plugin): turn off explicitly react/require-default-props after vers bump
* chore: fix postcss-modules incomatiblity that surfaced when autoprefixer was moved to Single Version policy
* chore(vr-tests): cleanup deps that are already in root
* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdholt chrisdholt chrisdholt approved these changes

@layershifter layershifter layershifter approved these changes

@ling1726 ling1726 ling1726 approved these changes

@EisenbergEffect EisenbergEffect Awaiting requested review from EisenbergEffect

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@nicholasrice nicholasrice Awaiting requested review from nicholasrice

@pompomon pompomon Awaiting requested review from pompomon

Assignees

@miroslavstastny miroslavstastny

Labels
Area: Build System dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
July Project Cycle Q3 2021
Development

Successfully merging this pull request may close these issues.
8 participants
@Hotell @DustyTheBot @fabricteam @msft-fluent-ui-bot @chrisdholt @layershifter @ling1726 @miroslavstastny