Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web components] export horizontal scroll styles #18858

Conversation

chrisdholt
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Exports the horizontal scroll styles from the package.

Focus areas to test

(optional)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 8, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4367114:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 8, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b6e3e9affbad20e1b8ff79d1b5a2b55b379c4de0 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 8, 2021

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 920 909 5000
BaseButton mount 1018 1039 5000
Breadcrumb mount 2862 2853 1000
ButtonNext mount 605 600 5000
Checkbox mount 1767 1762 5000
CheckboxBase mount 1498 1505 5000
ChoiceGroup mount 5435 5353 5000
ComboBox mount 1080 1067 1000
CommandBar mount 11261 11240 1000
ContextualMenu mount 6947 6900 1000
DefaultButton mount 1307 1292 5000
DetailsRow mount 4215 4165 5000
DetailsRowFast mount 4134 4091 5000
DetailsRowNoStyles mount 4024 3931 5000
Dialog mount 2374 2316 1000
DocumentCardTitle mount 157 155 1000
Dropdown mount 3686 3682 5000
FluentProviderNext mount 7482 7342 5000
FocusTrapZone mount 1993 2059 5000
FocusZone mount 1918 1962 5000
IconButton mount 2000 1983 5000
Label mount 383 382 5000
Layer mount 1998 2017 5000
Link mount 524 551 5000
MakeStyles mount 1945 1966 50000
MenuButton mount 1677 1666 5000
MessageBar mount 2226 2255 5000
Nav mount 3675 3613 1000
OverflowSet mount 1151 1186 5000
Panel mount 2227 2225 1000
Persona mount 917 927 1000
Pivot mount 1583 1592 1000
PrimaryButton mount 1447 1451 5000
Rating mount 8790 8823 5000
SearchBox mount 1521 1531 5000
Shimmer mount 2915 2983 5000
Slider mount 2232 2189 5000
SpinButton mount 5565 5558 5000
Spinner mount 445 452 5000
SplitButton mount 3562 3544 5000
Stack mount 569 575 5000
StackWithIntrinsicChildren mount 1741 1811 5000
StackWithTextChildren mount 5266 5285 5000
SwatchColorPicker mount 11319 11536 5000
Tabs mount 1578 1569 1000
TagPicker mount 2684 2745 5000
TeachingBubble mount 12885 12831 5000
Text mount 476 476 5000
TextField mount 1592 1573 5000
ThemeProvider mount 1321 1312 5000
ThemeProvider virtual-rerender 650 639 5000
Toggle mount 893 923 5000
buttonNative mount 129 120 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
DividerMinimalPerf.default 443 411 1.08:1
AnimationMinimalPerf.default 487 461 1.06:1
ImageMinimalPerf.default 458 434 1.06:1
RadioGroupMinimalPerf.default 559 529 1.06:1
FormMinimalPerf.default 478 454 1.05:1
ListWith60ListItems.default 763 724 1.05:1
BoxMinimalPerf.default 423 405 1.04:1
ButtonMinimalPerf.default 202 195 1.04:1
ButtonSlotsPerf.default 650 628 1.04:1
ChatDuplicateMessagesPerf.default 343 329 1.04:1
LabelMinimalPerf.default 461 444 1.04:1
ListCommonPerf.default 747 718 1.04:1
ListMinimalPerf.default 622 596 1.04:1
IconMinimalPerf.default 722 693 1.04:1
TreeWith60ListItems.default 204 197 1.04:1
AccordionMinimalPerf.default 184 178 1.03:1
GridMinimalPerf.default 402 392 1.03:1
HeaderMinimalPerf.default 439 427 1.03:1
LayoutMinimalPerf.default 427 415 1.03:1
SkeletonMinimalPerf.default 417 406 1.03:1
TreeMinimalPerf.default 921 898 1.03:1
VideoMinimalPerf.default 717 696 1.03:1
AttachmentSlotsPerf.default 1242 1216 1.02:1
DropdownManyItemsPerf.default 800 781 1.02:1
FlexMinimalPerf.default 339 333 1.02:1
LoaderMinimalPerf.default 777 765 1.02:1
PortalMinimalPerf.default 198 195 1.02:1
AlertMinimalPerf.default 318 314 1.01:1
ButtonOverridesMissPerf.default 1905 1877 1.01:1
CarouselMinimalPerf.default 547 539 1.01:1
DialogMinimalPerf.default 860 855 1.01:1
DropdownMinimalPerf.default 3389 3365 1.01:1
InputMinimalPerf.default 1396 1380 1.01:1
SliderMinimalPerf.default 1757 1748 1.01:1
SplitButtonMinimalPerf.default 4313 4253 1.01:1
TableManyItemsPerf.default 2268 2236 1.01:1
TableMinimalPerf.default 475 468 1.01:1
TextAreaMinimalPerf.default 598 593 1.01:1
CustomToolbarPrototype.default 4252 4215 1.01:1
ToolbarMinimalPerf.default 1076 1069 1.01:1
CheckboxMinimalPerf.default 3059 3061 1:1
DatepickerMinimalPerf.default 6197 6218 1:1
EmbedMinimalPerf.default 4573 4594 1:1
ItemLayoutMinimalPerf.default 1408 1412 1:1
PopupMinimalPerf.default 638 638 1:1
ProviderMinimalPerf.default 1107 1106 1:1
ReactionMinimalPerf.default 437 439 1:1
StatusMinimalPerf.default 812 809 1:1
TextMinimalPerf.default 407 405 1:1
TooltipMinimalPerf.default 1122 1125 1:1
AttachmentMinimalPerf.default 187 189 0.99:1
CardMinimalPerf.default 645 654 0.99:1
ChatMinimalPerf.default 752 756 0.99:1
HeaderSlotsPerf.default 889 902 0.99:1
ListNestedPerf.default 623 629 0.99:1
MenuMinimalPerf.default 959 969 0.99:1
MenuButtonMinimalPerf.default 1820 1831 0.99:1
ProviderMergeThemesPerf.default 1772 1796 0.99:1
SegmentMinimalPerf.default 417 421 0.99:1
AvatarMinimalPerf.default 220 224 0.98:1
ChatWithPopoverPerf.default 409 418 0.98:1
RefMinimalPerf.default 261 266 0.98:1
RosterPerf.default 1257 1308 0.96:1

@chrisdholt chrisdholt force-pushed the users/chhol/export-horizontal-scroll-styles branch 2 times, most recently from 85e7e00 to 3ddfcf8 Compare July 8, 2021 06:51
@chrisdholt chrisdholt force-pushed the users/chhol/export-horizontal-scroll-styles branch from 3ddfcf8 to 4367114 Compare July 8, 2021 07:03
@chrisdholt chrisdholt merged commit f99a295 into microsoft:master Jul 9, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/web-components@v1.0.2 has been released which incorporates this pull request.:tada:

Handy links:

PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
* export horizontal scroll styles

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants