Skip to content

Conversation

@chpalac
Copy link
Contributor

@chpalac chpalac commented Jul 9, 2021

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

..triggerElement.props, and ...triggerProps should have priority over unhandledProps, this PR sets the proper spread order

Focus areas to test

(optional)

@layershifter layershifter changed the title fix: order os spread props for tooltip trigger fix(Tooltip): fix order of spread for trigger Jul 9, 2021
@chpalac chpalac enabled auto-merge (squash) July 9, 2021 09:02
@size-auditor
Copy link

size-auditor bot commented Jul 9, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 394b16b92fae7773125c32edc1df56c7758cba4e (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 853 794 5000
BaseButton mount 911 919 5000
Breadcrumb mount 2499 2505 1000
ButtonNext mount 526 537 5000
Checkbox mount 1564 1575 5000
CheckboxBase mount 1316 1331 5000
ChoiceGroup mount 4877 4817 5000
ComboBox mount 990 983 1000
CommandBar mount 9751 9733 1000
ContextualMenu mount 6191 6060 1000
DefaultButton mount 1154 1149 5000
DetailsRow mount 3701 3680 5000
DetailsRowFast mount 3670 3680 5000
DetailsRowNoStyles mount 3499 3542 5000
Dialog mount 2071 2125 1000
DocumentCardTitle mount 149 140 1000
Dropdown mount 3213 3291 5000
FluentProviderNext mount 6596 6618 5000
FocusTrapZone mount 1767 1769 5000
FocusZone mount 1667 1717 5000
IconButton mount 1799 1780 5000
Label mount 354 341 5000
Layer mount 1786 1792 5000
Link mount 471 478 5000
MakeStyles mount 1730 1735 50000
MenuButton mount 1473 1486 5000
MessageBar mount 1970 1943 5000
Nav mount 3268 3250 1000
OverflowSet mount 1014 1020 5000
Panel mount 1346 2053 1000
Persona mount 804 823 1000
Pivot mount 1376 1374 1000
PrimaryButton mount 1296 1284 5000
Rating mount 7894 7912 5000
SearchBox mount 1354 1350 5000
Shimmer mount 2658 2607 5000
Slider mount 1929 1949 5000
SpinButton mount 5004 4970 5000
Spinner mount 404 413 5000
SplitButton mount 3458 3133 5000
Stack mount 518 518 5000
StackWithIntrinsicChildren mount 1573 1600 5000
StackWithTextChildren mount 4693 4728 5000
SwatchColorPicker mount 10160 10199 5000
Tabs mount 1404 1371 1000
TagPicker mount 2443 2499 5000
TeachingBubble mount 11556 11564 5000
Text mount 442 428 5000
TextField mount 1375 1379 5000
ThemeProvider mount 1153 1162 5000
ThemeProvider virtual-rerender 583 563 5000
Toggle mount 786 818 5000
buttonNative mount 111 116 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 181 155 1.17:1
AccordionMinimalPerf.default 175 159 1.1:1
SegmentMinimalPerf.default 377 344 1.1:1
AnimationMinimalPerf.default 444 410 1.08:1
SkeletonMinimalPerf.default 391 367 1.07:1
VideoMinimalPerf.default 661 617 1.07:1
ChatDuplicateMessagesPerf.default 303 285 1.06:1
FlexMinimalPerf.default 295 279 1.06:1
ListMinimalPerf.default 553 522 1.06:1
PortalMinimalPerf.default 176 166 1.06:1
DropdownManyItemsPerf.default 714 683 1.05:1
InputMinimalPerf.default 1285 1224 1.05:1
IconMinimalPerf.default 631 602 1.05:1
TextAreaMinimalPerf.default 548 521 1.05:1
TreeWith60ListItems.default 179 170 1.05:1
ChatWithPopoverPerf.default 365 352 1.04:1
ImageMinimalPerf.default 403 388 1.04:1
RefMinimalPerf.default 231 222 1.04:1
TreeMinimalPerf.default 830 801 1.04:1
GridMinimalPerf.default 364 352 1.03:1
LoaderMinimalPerf.default 688 665 1.03:1
TableManyItemsPerf.default 2003 1937 1.03:1
TextMinimalPerf.default 370 359 1.03:1
ToolbarMinimalPerf.default 975 947 1.03:1
AttachmentSlotsPerf.default 1105 1083 1.02:1
CardMinimalPerf.default 581 570 1.02:1
DropdownMinimalPerf.default 3049 2996 1.02:1
HeaderSlotsPerf.default 797 783 1.02:1
PopupMinimalPerf.default 561 551 1.02:1
RadioGroupMinimalPerf.default 465 455 1.02:1
ReactionMinimalPerf.default 394 387 1.02:1
SplitButtonMinimalPerf.default 3868 3774 1.02:1
TableMinimalPerf.default 422 413 1.02:1
AvatarMinimalPerf.default 200 199 1.01:1
BoxMinimalPerf.default 368 366 1.01:1
ButtonMinimalPerf.default 180 179 1.01:1
ChatMinimalPerf.default 665 657 1.01:1
CheckboxMinimalPerf.default 2698 2679 1.01:1
DatepickerMinimalPerf.default 5384 5339 1.01:1
DialogMinimalPerf.default 760 755 1.01:1
SliderMinimalPerf.default 1544 1522 1.01:1
AlertMinimalPerf.default 278 278 1:1
ButtonOverridesMissPerf.default 1693 1695 1:1
CarouselMinimalPerf.default 473 475 1:1
EmbedMinimalPerf.default 4071 4079 1:1
FormMinimalPerf.default 452 450 1:1
HeaderMinimalPerf.default 370 369 1:1
ItemLayoutMinimalPerf.default 1251 1254 1:1
LabelMinimalPerf.default 390 389 1:1
TooltipMinimalPerf.default 985 983 1:1
ButtonSlotsPerf.default 577 583 0.99:1
MenuMinimalPerf.default 860 871 0.99:1
MenuButtonMinimalPerf.default 1591 1609 0.99:1
ProviderMergeThemesPerf.default 1563 1572 0.99:1
CustomToolbarPrototype.default 3737 3768 0.99:1
LayoutMinimalPerf.default 372 379 0.98:1
RosterPerf.default 1204 1226 0.98:1
ProviderMinimalPerf.default 992 1014 0.98:1
StatusMinimalPerf.default 676 690 0.98:1
DividerMinimalPerf.default 371 381 0.97:1
ListCommonPerf.default 655 675 0.97:1
ListNestedPerf.default 566 587 0.96:1
ListWith60ListItems.default 626 666 0.94:1

@chpalac chpalac merged commit 2b6f9b6 into microsoft:master Jul 9, 2021
@chpalac chpalac deleted the fix/tooltip-props-order branch July 9, 2021 09:27
PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
* fix: order os spread props for tooltip trigger

* add changelog

Co-authored-by: Charles Assuncao <charles.assuncao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fluent UI react-northstar (v0) Work related to Fluent UI V0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants